Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USAGE.md - Retrieve all recipients on a List, list_id should not be part of queyparams #351

Closed
robledosm opened this issue Oct 18, 2016 · 1 comment
Closed

USAGE.md - Retrieve all recipients on a List, list_id should not be part of queyparams #351

robledosm opened this issue Oct 18, 2016 · 1 comment
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: bug bug in the library

Comments

@robledosm
Copy link

There is an error in Retrieve all recipients on a List example in USAGE.md document. The parameter list_id should not be part of the queryParams, otherwise you get an error (BadRequest) saying that list_id is not part of the custom filters. Removing list_id from queryParams fixes the issue.
@thinkingserious thinkingserious added type: bug bug in the library status: help wanted requesting help from the community labels Oct 19, 2016
@thinkingserious
Copy link
Contributor

Thanks for the heads up @robledosm!

I've added this to our backlog for a fix.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Sep 30, 2017
Gimly added a commit to Gimly/sendgrid-csharp that referenced this issue Sep 30, 2017
@Gimly
Corrected list all recipients documentation
16d0a15 
Fixed the example query for list all recipients to be the same as the one in SendGrid's documentation. Removed the list_id parameter that was incorrect.

Fixes sendgrid#351
@Gimly Gimly mentioned this issue Sep 30, 2017
Merged
mbernier pushed a commit that referenced this issue Oct 22, 2017
Merge pull request #527 from Gimly/351-FixRetrieveAllRecipientsDoc
53b042a 
Corrected list all recipients documentation Fixes #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkingserious @robledosm