feat: add IsSuccessStatusCode (#1077)

sendgrid · Dec 14, 2020 · a00a259 · a00a259
1 parent fbb3764
commit a00a259
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/src/SendGrid/Response.cs b/src/SendGrid/Response.cs
@@ -62,6 +62,14 @@ public HttpStatusCode StatusCode
             }
         }
 
+        /// <summary>
+        /// Gets a value indicating whether Status Code of this response indicates success.
+        /// </summary>
+        public bool IsSuccessStatusCode
+        {
+            get { return ((int)StatusCode >= 200) && ((int)StatusCode <= 299); }
+        }
+
         /// <summary>
         /// Gets or sets the response body returned from Twilio SendGrid.
         /// </summary>

diff --git a/tests/SendGrid.Tests/Integration.cs b/tests/SendGrid.Tests/Integration.cs
@@ -4,6 +4,7 @@
     using System.Collections.Generic;
     using System.Net;
     using System.Net.Http;
+    using System.Net.Http.Headers;
     using System.Text;
     using System.Threading;
     using System.Threading.Tasks;
@@ -2725,6 +2726,7 @@ public void TestSetGoogleAnalytics()
             msg.SetGoogleAnalytics(true, "campaign3", "content3", "medium3", "source3", "term3");
             Assert.Equal("{\"tracking_settings\":{\"ganalytics\":{\"enable\":true,\"utm_source\":\"source3\",\"utm_medium\":\"medium3\",\"utm_term\":\"term3\",\"utm_content\":\"content3\",\"utm_campaign\":\"campaign3\"}}}", msg.Serialize());
         }
+
         [Fact]
         public async Task TestAccessSettingsActivityGet()
         {
@@ -6004,6 +6006,33 @@ public void TestInjectSameHttpClientWithMultipleInstance()
             var sg1 = new SendGridClient(clientToInject, fixture.apiKey);
             var sg2 = new SendGridClient(clientToInject, fixture.apiKey);
         }
+
+        [Fact]
+        public void TestBadRequestIsSuccessStatusCodeReturnsFalse()
+        {
+            var message = new HttpResponseMessage();
+            var response = new Response(HttpStatusCode.BadRequest, message.Content, message.Headers);
+            Assert.False(response.IsSuccessStatusCode);
+        }
+
+        [Fact]
+        public void TestOkRequestIsSuccessStatusCodeReturnsTrue()
+        {
+            var message = new HttpResponseMessage();
+            var response = new Response(HttpStatusCode.OK, message.Content, message.Headers);
+            Assert.True(response.IsSuccessStatusCode);
+        }
+
+        [Fact]
+        public void TestIsSuccessStatusCodeEvery2xxCodeReturnsTrue()
+        {
+            for (int i = 200; i <= 299; ++i)
+            {
+                var message = new HttpResponseMessage();
+                var response = new Response((HttpStatusCode)i, message.Content, message.Headers);
+                Assert.True(response.IsSuccessStatusCode);
+            }
+        }
     }
 
     public class FakeWebProxy : IWebProxy