Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix rubocop.yml formatting warnings #98

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

RolandBurrows
Copy link
Contributor

Short description of what this PR does:

Previous rubocop output:

ruby-http-client$ rubocop
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
Inspecting 7 files
.......
7 files inspected, no offenses detected

After this PR's changes:

ruby-http-client$ rubocop
Inspecting 7 files
.......
7 files inspected, no offenses detected

This change required re-alphabetizing the rubocop.yml entries list, and there were pre-existing mis-ordered entries that are now properly alphabetized as well.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • (N/A) I have added tests that prove my fix is effective or that my feature works
  • (N/A) I have added necessary documentation about the functionality in the appropriate .md file
  • (N/A) I have added in line documentation to the code I modified

example: .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #98 into master will increase coverage by 1.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   94.14%   95.45%   +1.31%     
==========================================
  Files           2        2              
  Lines         239      286      +47     
==========================================
+ Hits          225      273      +48     
+ Misses         14       13       -1
Impacted Files Coverage Δ
test/test_ruby_http_client.rb 97.43% <100%> (+0.66%) ⬆️
lib/ruby_http_client.rb 91.2% <100%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd5461...80b9827. Read the comment docs.

@childish-sambino childish-sambino changed the title Fix rubocop.yml formatting warnings test: Fix rubocop.yml formatting warnings Feb 21, 2020
@childish-sambino childish-sambino merged commit 127083f into sendgrid:master Feb 21, 2020
@thinkingserious
Copy link
Contributor

Hello @RolandBurrows,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants