Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update contribution to branch off development #91

Merged
merged 2 commits into from
Oct 29, 2018
Merged

docs: update contribution to branch off development #91

merged 2 commits into from
Oct 29, 2018

Conversation

vikasnautiyal
Copy link
Contributor

@vikasnautiyal vikasnautiyal commented Oct 13, 2018 •
edited
Loading

Fixes #90

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update CONTRIBUTING.md to for devs to branch off from development instead of master

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 13, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vikasnautiyal vikasnautiyal changed the title Enhancement/contribution update update contribution to branch off development Oct 13, 2018
@vikasnautiyal
Copy link
Contributor Author

Hi @thinkingserious, any updates on this?

@devchas devchas added difficulty: easy fix is easy in difficulty good first issue type: docs update documentation change not affecting the code labels Oct 17, 2018
@kplimack kplimack self-assigned this Oct 19, 2018
@kplimack kplimack added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious
Copy link
Contributor

Hello @vikasnautiyal,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @vikasnautiyal,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 7fff332 into sendgrid:master Oct 29, 2018
@thinkingserious
Copy link
Contributor

Hello @vikasnautiyal,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@thinkingserious thinkingserious changed the title update contribution to branch off development docs: update contribution to branch off development Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kplimack kplimack kplimack approved these changes

Assignees

@kplimack kplimack

Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document new Git workflow in CHANGELOG.md
5 participants
@vikasnautiyal @SendGridDX @thinkingserious @kplimack @devchas