Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Corrected *.md files using Grammarly #84

Merged
merged 2 commits into from
Feb 21, 2020
Merged

docs: Corrected *.md files using Grammarly #84

merged 2 commits into from
Feb 21, 2020

Conversation

pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 5, 2018

Fixes #83

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Corrected *.md files using Grammarly

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest type: docs update documentation change not affecting the code labels Oct 12, 2018
@thinkingserious
Copy link
Contributor

Hello @pushkyn,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@e5a728f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage          ?   95.01%           
=========================================
  Files             ?        2           
  Lines             ?      281           
  Branches          ?        0           
=========================================
  Hits              ?      267           
  Misses            ?       14           
  Partials          ?        0
Impacted Files Coverage Δ
test/test_ruby_http_client.rb 97.43% <100%> (ø)
lib/ruby_http_client.rb 89.53% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a728f...a74a025. Read the comment docs.

@childish-sambino childish-sambino changed the title Corrected *.md files using Grammarly docs: Corrected *.md files using Grammarly Feb 21, 2020
@childish-sambino childish-sambino merged commit eee424a into sendgrid:master Feb 21, 2020
@thinkingserious
Copy link
Contributor

Hello @pushkyn,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run our *.md documents in this repo through the Grammer.ly service and update
3 participants