chore: Missing Dev Dependencies + rubocop #79

[kplimack]

Signed-off-by: Jake Plimack [email protected]

Resolves #79

• provides missing gems needed for development ( minitest )
• lints code w/rubocop, provides .rubocop.yml
• expanded Rakefile to drive linting + testing

You can now use the Rakefile to drive testing.

bundle exec rake 
rubocop -c .rubocop.yml
.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
Inspecting 7 files
.......

7 files inspected, no offenses detected
Run options: --seed 54688

# Running:

F....FF.....F.................F

Finished in 0.005653s, 5483.5423 runs/s, 7783.0923 assertions/s.

  1) Failure:
TestClient#test_usage_exists [/Users/jplimack/repos/ruby-http-client/test/test_ruby_http_client.rb:245]:
Expected false to be truthy.

  2) Failure:
TestClient#test_docker_exists [/Users/jplimack/repos/ruby-http-client/test/test_ruby_http_client.rb:189]:
Expected false to be truthy.

  3) Failure:
TestClient#test_docker_compose_exists [/Users/jplimack/repos/ruby-http-client/test/test_ruby_http_client.rb:193]:
Expected false to be truthy.

  4) Failure:
TestClient#test_use_cases_exists [/Users/jplimack/repos/ruby-http-client/test/test_ruby_http_client.rb:249]:
Expected false to be truthy.

  5) Failure:
TestClient#test_license_date_is_updated [/Users/jplimack/repos/ruby-http-client/test/test_ruby_http_client.rb:255]:
Expected: 2018
  Actual: 2017

31 runs, 44 assertions, 5 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -I"lib:test" -I"/Users/jplimack/repos/ruby-http-client/vendor/ruby/2.3.0/gems/rake-0.9.6/lib" "/Users/jplimack/repos/ruby-http-client/vendor/ruby/2.3.0/gems/rake-0.9.6/lib/rake/rake_test_loader.rb" "test/test*.rb" ]
/Users/jplimack/repos/ruby-http-client/Rakefile:19:in `block in <top (required)>'
/Users/jplimack/repos/ruby-http-client/Rakefile:28:in `block (2 levels) in <top (required)>'
Tasks: TOP => test
(See full trace by running task with --trace)

Checklist

• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the [Contribution Guide] and my PR follows them.
• I updated my branch with the master branch.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation about the functionality in the appropriate .md file
• I have added in line documentation to the code I modified

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

[thinkingserious]

Hello @kplimack,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

[kplimack]

Thanks to @tachyons for his help on this!

[thinkingserious]

Hello @kplimack,

Thanks again for the PR!

We noticed that you have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

[thinkingserious]

Hello @kplimack,

Thanks again for the PR!

You have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid