-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to set proxy #75
feat: Add ability to set proxy #75
Conversation
# request_headers: headers, | ||
# proxy_options: { host: '127.0.0.1', port: 8080 }) | ||
# | ||
# (2) Set 'http_proxy' environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about https_proxy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you cannot use https_proxy
. It is from ruby's `URI::Generic#find_proxy'.
@eitoball I'm not sure that it is a safe idea for the client code to mutate environment variables. If one of those is set the client should respect it. It makes more sense to instantiate the class like you have in example#1 passing the proxy settings explicitly. |
@kplimack I am not sure what you mean by "mutate environment variables". Example (2) in |
Hello @eitoball, |
Hello @eitoball, |
Hello @eitoball, |
Fixes #70
Checklist
.mdexample fileShort description of what this PR does:
Sendgrid::Client
.Sample