Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete PULL_REQUEST_TEMPLATE.md #66

Merged
merged 1 commit into from
Oct 3, 2018
Merged

chore: delete PULL_REQUEST_TEMPLATE.md #66

merged 1 commit into from
Oct 3, 2018

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Nov 2, 2017 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This file should be renamed to 'PULL_REQUEST_TEMPLATE' and be under '.github/' directory.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thepriefy
delete PULL_REQUEST_TEMPLATE.md
7170fee 
This file should be renamed to 'PULL_REQUEST_TEMPLATE' and be under '.github/' directory.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 2, 2017
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio labels Nov 9, 2017
mbernier
mbernier approved these changes Dec 12, 2017
View reviewed changes
Copy link

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@thinkingserious thinkingserious added type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Mar 6, 2018
@thinkingserious thinkingserious merged commit a6894c8 into sendgrid:master Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thepriefy thepriefy deleted the patch-4 branch October 5, 2018 05:47
@thinkingserious thinkingserious changed the title delete PULL_REQUEST_TEMPLATE.md chore: delete PULL_REQUEST_TEMPLATE.md Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thepriefy @thinkingserious @mbernier