Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [Closes #55] Add code coverage reporting to CC #58

Merged
merged 1 commit into from
Dec 12, 2017
Merged

chore: [Closes #55] Add code coverage reporting to CC #58

merged 1 commit into from
Dec 12, 2017

Conversation

lauratpa
Copy link
Contributor

@lauratpa lauratpa commented Oct 30, 2017

This PR add code coverage reporting and integrates it with code climate.

Closes #55

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Add code coverage and integration to Code Climate

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@lauratpa
Copy link
Contributor Author

For this PR to work on CI, a maintainer (who has access to cc) needs to add the TEST REPORT ID for this repo in code climate to be available as an environment variable in TRAVIS (CC_TEST_REPORT_ID).

https://docs.codeclimate.com/docs/finding-your-test-coverage-token
https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings

This PR add code coverage reporting and integrates it with code climate.

Closes #55
@lauratpa lauratpa changed the title Add code coverage reporting to CC [Closes #55] Add code coverage reporting to CC Oct 30, 2017
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@mbernier
Copy link

I added the variable to the Travis build and asked Travis nicely to rebuild! Let's see what happens.

@mbernier mbernier merged commit 22935da into sendgrid:master Dec 12, 2017
@thinkingserious
Copy link
Contributor

Hello @jekuta,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Dec 12, 2017
@lauratpa lauratpa deleted the 55-add-code-coverage-for-codeclimate branch December 15, 2017 08:17
@thinkingserious thinkingserious changed the title [Closes #55] Add code coverage reporting to CC chore: [Closes #55] Add code coverage reporting to CC Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing support to codeclimate checks
4 participants