Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [Closes #56] Fix some rubocop issues #57

Merged
merged 1 commit into from
Dec 11, 2017
Merged

chore: [Closes #56] Fix some rubocop issues #57

merged 1 commit into from
Dec 11, 2017

Conversation

lauratpa
Copy link
Contributor

@lauratpa lauratpa commented Oct 30, 2017

Closes #56

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Fixing issues reported by ruboocop

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@lauratpa lauratpa changed the title Fix some rubocop issues [Closes #56] Fix some rubocop issues Oct 30, 2017
@thinkingserious
Copy link
Contributor

@jekuta

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@mbernier mbernier added the difficulty: medium fix is medium in difficulty label Dec 11, 2017
@mbernier
Copy link

@jekuta

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid-ci

@mbernier mbernier merged commit 36df726 into sendgrid:master Dec 11, 2017
@thinkingserious
Copy link
Contributor

Hello @jekuta,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title [Closes #56] Fix some rubocop issues chore: [Closes #56] Fix some rubocop issues Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bunch of small cleanup tasks -
4 participants