Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add License end year test #51

Merged
merged 1 commit into from
Oct 31, 2017
Merged

chore: Add License end year test #51

merged 1 commit into from
Oct 31, 2017

Conversation

diegous
Copy link
Contributor

@diegous diegous commented Oct 28, 2017 •
edited
Loading

Fixes #46

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
Copy link

I merged in current sendgrid master, to test that your unittest now passes.

@diegous
Copy link
Contributor Author

diegous commented Oct 31, 2017

Oh cool! Wasn't it rebased? Sorry, my bad

@mbernier
Copy link

We have had so many PRs, that everyone's PRs are out of date about the same time they post them :)

@mbernier mbernier merged commit b4b9460 into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

Hello @diegous,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier
Copy link

@diegous

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@thinkingserious thinkingserious changed the title Add License end year test chore: Add License end year test Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
4 participants
@diegous @SendGridDX @mbernier @thinkingserious