Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Create PULL_REQUEST_TEMPLATE.md #41

Merged
merged 1 commit into from
Oct 30, 2017
Merged

docs: Create PULL_REQUEST_TEMPLATE.md #41

merged 1 commit into from
Oct 30, 2017

Conversation

flaredragon
Copy link
Contributor

Added descriptive pull request template
Fixes #31

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 27, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link

Pending #33 #32

@flaredragon
Copy link
Contributor Author

flaredragon commented Oct 29, 2017 •
edited
Loading

If they don't sign the CLA could my get merged today? @mbernier

@mbernier
Copy link

Done!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 30, 2017
@mbernier mbernier merged commit 0fb3f36 into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @flaredragon,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

This was referenced Oct 30, 2017
Closed
Closed
@thinkingserious thinkingserious changed the title Create PULL_REQUEST_TEMPLATE.md docs: Create PULL_REQUEST_TEMPLATE.md Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a PULL_REQUEST_TEMPLATE
4 participants
@flaredragon @SendGridDX @mbernier @thinkingserious