Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JSON-encode array request bodies #118

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

childish-sambino
Copy link
Contributor

Fixes #117

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #118 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   95.48%   95.60%   +0.11%     
==========================================
  Files           2        2              
  Lines         332      341       +9     
==========================================
+ Hits          317      326       +9     
  Misses         15       15              
Impacted Files Coverage Δ
lib/ruby_http_client.rb 91.22% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248b8cd...3077b9b. Read the comment docs.

@childish-sambino childish-sambino merged commit fa5d47b into master Feb 25, 2020
@childish-sambino childish-sambino deleted the json-array branch February 25, 2020 15:52
@thinkingserious
Copy link
Contributor

Hello @childish-sambino,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gem Release 6.1.0 Passing Post Body Results in Error
2 participants