Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid mutating @url_path to avoid unexpected side effects #108

Merged
merged 1 commit into from
Dec 8, 2018
Merged

fix: Avoid mutating @url_path to avoid unexpected side effects #108

merged 1 commit into from
Dec 8, 2018

Conversation

tachyons
Copy link
Contributor

@tachyons tachyons commented Oct 31, 2018 •
edited
Loading

Fixes #93

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

method _ mutates @url_path and it can have unintended side effects like #93. This PR remove that mutation

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious merged commit 37fb694 into sendgrid:master Dec 8, 2018
@thinkingserious
Copy link
Contributor

Hello @tachyons,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Avoid mutating @url_path to avoid unexpected side effects fix: Avoid mutating @url_path to avoid unexpected side effects Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client instance clobbers internal state
3 participants
@tachyons @SendGridDX @thinkingserious