Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Grammerly checks on *.md files #101

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

prathamsharma92
Copy link
Contributor

#83

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2018

CLA assistant check
All committers have signed the CLA.

@childish-sambino childish-sambino changed the title Grammerly checks on *.md files #83 docs: Grammerly checks on *.md files Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   94.14%   95.01%   +0.87%     
==========================================
  Files           2        2              
  Lines         239      281      +42     
==========================================
+ Hits          225      267      +42     
  Misses         14       14
Impacted Files Coverage Δ
lib/ruby_http_client.rb 89.53% <0%> (+0.24%) ⬆️
test/test_ruby_http_client.rb 97.43% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f27cf...7bbda4e. Read the comment docs.

@childish-sambino childish-sambino merged commit 641c6ec into sendgrid:master Feb 21, 2020
@thinkingserious
Copy link
Contributor

Hello @prathamsharma92,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio status: duplicate duplicate issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants