Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding code review section under contributing.md #100

Merged
merged 1 commit into from
Feb 21, 2020
Merged

docs: adding code review section under contributing.md #100

merged 1 commit into from
Feb 21, 2020

Conversation

prathamsharma92
Copy link
Contributor

@prathamsharma92 prathamsharma92 commented Oct 30, 2018 •
edited by childish-sambino
Loading

Added Code Reviews section under CONTRIBUTING.md

Closes #63

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@childish-sambino childish-sambino mentioned this pull request Feb 21, 2020
Closed
6 tasks
@childish-sambino childish-sambino changed the title adding code review section under contributing.md docs: adding code review section under contributing.md Feb 21, 2020
@childish-sambino childish-sambino merged commit 14ca086 into sendgrid:master Feb 21, 2020
@thinkingserious
Copy link
Contributor

Hello @prathamsharma92,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md
4 participants
@prathamsharma92 @SendGridDX @thinkingserious @childish-sambino