Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python #90

Merged
merged 7 commits into from
Oct 11, 2018
Merged

Drop support for EOL Python #90

merged 7 commits into from
Oct 11, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 1, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

  • Drop support for EOL Pyhon

Python 2.6 and 3.2-3.3 are EOL and no longer receiving security updates (or any updates) from the core Python team.

Version Release date Supported until
2.6 2008-10-01 2013-10-29
3.0 2008-12-03 2009-06-27
3.1 2009-06-27 2012-04-09
3.2 2011-02-20 2016-02-27
3.3 2012-09-29 2017-09-29

They're also little used.

This PR drops support for them, removes old compatibility code, upgrades some code to make use of newer Python features, and fixes some typos.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 1, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #90 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   91.61%   91.34%   -0.27%     
==========================================
  Files           6        6              
  Lines         298      289       -9     
==========================================
- Hits          273      264       -9     
  Misses         25       25
Impacted Files Coverage Δ
python_http_client/client.py 77.66% <100%> (ø) ⬆️
tests/test_unit.py 99.2% <100%> (-0.02%) ⬇️
tests/test_repofiles.py 100% <100%> (ø) ⬆️
tests/test_daterange.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a3ba0...41d56fe. Read the comment docs.

setup.py Outdated Show resolved Hide resolved
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty hacktoberfest status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @hugovk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 9196b9f into sendgrid:master Oct 11, 2018
@hugovk hugovk deleted the rm-eol branch October 11, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants