Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include code reviews section Fixes #76 #77

Merged
merged 1 commit into from
May 22, 2018
Merged

include code reviews section Fixes #76 #77

merged 1 commit into from
May 22, 2018

Conversation

jlax47
Copy link
Contributor

@jlax47 jlax47 commented Oct 31, 2017 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Updates contributing.md to include a section on code review.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jlax47 jlax47 mentioned this pull request Oct 31, 2017
Closed
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious thinkingserious merged commit ecb28e5 into sendgrid:master May 22, 2018
@thinkingserious
Copy link
Contributor

Hello @jlax47,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlax47 @SendGridDX @thinkingserious @apigirl