Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License date range UnitTest #61

Merged
merged 2 commits into from
Nov 1, 2017
Merged

License date range UnitTest #61

merged 2 commits into from
Nov 1, 2017

Conversation

dinosaurfiles-zz
Copy link
Contributor

Checks if LICENSE.txt file is within the current year range. This PR resolves #57

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier mbernier merged commit e68e64c into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @dinosaurfiles,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@dinosaurfiles-zz
Copy link
Contributor Author

Thank you @thinkingserious & @sendgrid! 😍

@thinkingserious thinkingserious mentioned this pull request Nov 2, 2017
Closed
@mbernier
Copy link
Contributor

@dinosaurfiles

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
5 participants
@dinosaurfiles-zz @SendGridDX @thinkingserious @mbernier @apigirl