Fix a year in LICENSE.txt file to fix test__daterange. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
misterdorm
added
type: bug
misterdorm
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
@frenzymadness Agreed, it would probably be best to update that test. Would you mind opening an issue in this repo detailing the current behavior and your suggestion to change it? Thanks!
|
Hello @frenzymadness, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Because the test
test__daterangerely on the current year in the license file, the LICENSE.txt should be updated every year because otherwise the test will be broken.Honestly, I don't think that test like this is a good idea but it's up to you.