-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw InvalidRequest exception on invalid CURL request #99
Throw InvalidRequest exception on invalid CURL request #99
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
+ Coverage 84.7% 88% +3.29%
=======================================
Files 3 4 +1
Lines 170 175 +5
=======================================
+ Hits 144 154 +10
+ Misses 26 21 -5
Continue to review full report at Codecov.
|
Hey, |
Hello @Rezouce, I do not, but for this issue to gain priority in our backlog, we need additional +1's or comments. My apologies for the delay and thanks for your patience. With Best Regards, Elmer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed these changes and they're basically what I envisioned when I wrote sendgrid/sendgrid-php#328 (comment). Looks good to me, lets get this moving!
Why is this not merged already? Can someone for Sendgrid please explain what the holdup is? This is an important issue that needs to be fixed. |
Now somebody just needs to push this to packagist, so we can actually benefit from this fix. |
Fixes
#90
Checklist
Short description of what this PR does: