Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonSerializable type to phpDoc of $body parameter in makeRequest method #82

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

jankonas
Copy link
Contributor

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

I have not added any documentation because I don't think it's necessary for this change. Also I haven't added any tests, because this type of issues can only be detected by static analysis on files using this package.

Short description of what this PR does:

This PR updates phpDoc comment to reflect the code (not only array, but also JsonSerializable can be passed to makeRequest method). That allows usage of this package in projects using static analysis without the need of suppressing some error messages.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 18, 2017
@SendGridDX
Copy link

SendGridDX commented Dec 18, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thank you @jankonas!

This has been added to our backlog for review.

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit 36693c5 into sendgrid:master Jan 23, 2018
@thinkingserious
Copy link
Contributor

Hello @jankonas,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Add JsonSerializable type to phpDoc of $body parameter in makeRequest method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants