Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor makeRequest method #79

Merged

Conversation

michaeljdennis
Copy link
Contributor

Fixes #63

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR reduces the size of the makeRequest method by moving some functionality out to other methods. This fixes the following code climate warning: https://codeclimate.com/github/sendgrid/php-http-client/lib/Client.php#issue_59f3f044c7fa44000100001a

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@michaeljdennis michaeljdennis mentioned this pull request Nov 1, 2017
6 tasks
@thinkingserious
Copy link
Contributor

@michaeljdennis

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #79 into master will increase coverage by 4.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   82.68%   87.05%   +4.37%     
==========================================
  Files           3        3              
  Lines         179      170       -9     
==========================================
  Hits          148      148              
+ Misses         31       22       -9
Impacted Files Coverage Δ
lib/Client.php 84.67% <0%> (+5.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d23d92...d350c2a. Read the comment docs.

@thinkingserious thinkingserious merged commit b557c76 into sendgrid:master Jan 23, 2018
@thinkingserious
Copy link
Contributor

Hello @michaeljdennis,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Client to handle response data in a new method
2 participants