Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds unit test for checking year on licence #61

Merged
merged 3 commits into from
Dec 19, 2017
Merged

Adds unit test for checking year on licence #61

merged 3 commits into from
Dec 19, 2017

Conversation

micheleorselli
Copy link
Contributor

Fixes #57

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR adds a unit test for checking the year in the license.txt files matches the current year

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mbernier
mbernier suggested changes Nov 16, 2017
View reviewed changes
test/unit/LicenceYearTest.php Outdated
{
public function testConstructor()
{
$license = explode("\n", file_get_contents('./LICENSE.txt'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous build on Travis, the test was failing because it couldn't find this file. I am wondering if we are running into a file path issue?
The test is running from a different directory than the License file, should we be using a path relative to the file system, rather than the repo, instead?

@mbernier
Copy link

@micheleorselli do you think this is similar to the issue you fixed on #60?

@micheleorselli
Copy link
Contributor Author

@mbernier yeah, it could be. I'll provide a fix also for this

@mbernier
Copy link

mbernier commented Dec 14, 2017 via email •
edited by thinkingserious
Loading

@thinkingserious thinkingserious merged commit 3433bf2 into sendgrid:master Dec 19, 2017
@thinkingserious
Copy link
Contributor

Hello @micheleorselli,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#61 from micheleorselli/unittest_for_year_…
3fe5cd7 
…in_licence

Adds unit test for checking year on licence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier requested changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
5 participants
@micheleorselli @SendGridDX @mbernier @thinkingserious @apigirl