Added ability to get headers as associative array #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
thinkingserious
added a commit
that referenced
this pull request
May 5, 2017
alexpts
reviewed
May 5, 2017
| * | ||
| * @throws \InvalidArgumentException | ||
| */ | ||
| private function prettifyHeaders($headers) |
There was a problem hiding this comment.
private function prettifyHeaders(array $headers)
alexpts
reviewed
May 5, 2017
| */ | ||
| private function prettifyHeaders($headers) | ||
| { | ||
| if (!is_array($headers)) { |
There was a problem hiding this comment.
remove condition and exception, you can pass only array type for first argument
alexpts
reviewed
May 5, 2017
| } | ||
|
|
||
| return array_reduce( | ||
| array_filter($headers), |
There was a problem hiding this comment.
Remove array_filter, you can filter in reduce function
alexpts
reviewed
May 5, 2017
|
|
||
| return array_reduce( | ||
| array_filter($headers), | ||
| function ($result, $header) { |
alexpts
reviewed
May 5, 2017
| return $result; | ||
| } | ||
|
|
||
| if (false === strpos($header, ':')) { |
There was a problem hiding this comment.
Why header not name? Can you provider description this case?
I think is dirty hack
|
@mazanax, I added some minor comment for PR |
|
Hi @alexpts, Thanks for taking the time to review! Would you mind creating your own PR, since this one is already merged? Thanks! With Best Regards, Elmer |
Falseclock
pushed a commit
to Falseclock/php-http-client
that referenced
this pull request
Jan 30, 2019
Added ability to get headers as associative array
Falseclock
pushed a commit
to Falseclock/php-http-client
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented sendgrid/sendgrid-php#361