Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: removed tests that were testing for files that didnt exist, bumped gradle version to 4.10.2 #93

Merged
merged 2 commits into from
Oct 9, 2018
Merged

test: removed tests that were testing for files that didnt exist, bumped gradle version to 4.10.2 #93

merged 2 commits into from
Oct 9, 2018

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Oct 2, 2018 •
edited
Loading

Fixes

Checklist

  • I have read the [Contribution Guide] and my PR follows them.
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works No new tests needed
  • I have added necessary documentation about the functionality in the appropriate .md file No new code added
  • I have added in line documentation to the code I modified No new code added

Short description of what this PR does:

Updated gradle version from 3.3 to 4.10.2
Tiny cleanup in Client.java
Removed tests that were testing for files that didn't exist

@Strum355
Bumped LICENSE year
0e0c002 
Updated gradle version
Tiny cleanup in Client.java
Fixed tests that were testing for files that didnt exist
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Strum355 Strum355 changed the title Removed tests that were testing for files that didnt exist, bumped gradle version to 4.10.2 Fixed tests: removed tests that were testing for files that didnt exist, bumped gradle version to 4.10.2 Oct 2, 2018
thinkingserious
thinkingserious requested changes Oct 3, 2018
View reviewed changes
src/test/java/com/sendgrid/TestRequiredFilesExist.java
@@ -13,18 +13,6 @@
assertTrue(dockerExists);
}

// ./docker-compose.yml or ./docker/docker-compose.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please just comment out these tests for now? Eventually we want them to pass. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, changes are commited 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should i only re-add the docker-compose ones or USE-CASES.md and .env-sample as well?

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy status: hacktoberfest approved and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 9, 2018
@thinkingserious
Copy link
Contributor

Hello @Strum355,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 0c44a1d into sendgrid:master Oct 9, 2018
@eshanholtz eshanholtz changed the title Fixed tests: removed tests that were testing for files that didnt exist, bumped gradle version to 4.10.2 test: removed tests that were testing for files that didnt exist, bumped gradle version to 4.10.2 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strum355 @SendGridDX @thinkingserious