Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test to check year in license file #66

Merged
merged 1 commit into from
Oct 31, 2017
Merged

test: Test to check year in license file #66

merged 1 commit into from
Oct 31, 2017

Conversation

pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 28, 2017 •
edited
Loading

Fixes #61

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
mithunsasidharan
mithunsasidharan reviewed Oct 29, 2017
View reviewed changes
src/test/java/com/sendgrid/LicenseTest.java Outdated
@Test
public void testLicenseShouldHaveCorrectYear() throws IOException {
String copyrightText = null;
try (BufferedReader br = new BufferedReader(new FileReader("./LICENSE.txt"))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid file name

Copy link
Contributor Author

@pushkyn pushkyn Oct 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
Copy link
Contributor

Thank you!

@mbernier mbernier merged commit 39ee7b5 into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

Hello @pushkyn,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier mbernier mentioned this pull request Nov 1, 2017
Closed
6 tasks
JyotsnaC pushed a commit to JyotsnaC/java-http-client that referenced this pull request Nov 3, 2017
Merge pull request sendgrid#66 from pushkyn/test-release-date-range
ad93da8 
Test to check year in license file
@eshanholtz eshanholtz changed the title Test to check year in license file test: Test to check year in license file Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithunsasidharan mithunsasidharan mithunsasidharan left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
4 participants
@pushkyn @mbernier @thinkingserious @mithunsasidharan