Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No longer throwing IOExceptions on non 2xx response codes. #36

Merged
merged 3 commits into from
Dec 21, 2017
Merged

fix: No longer throwing IOExceptions on non 2xx response codes. #36

merged 3 commits into from
Dec 21, 2017

Conversation

andy-trimble
Copy link
Contributor

This fixes issues sendgrid/sendgrid-java#184 and sendgrid/sendgrid-java#212. This was done as part of issue sendgrid/sendgrid-java#221.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 12, 2017
@mbernier
Copy link
Contributor

This last merge should fix the build issues.

@mbernier mbernier added difficulty: hard fix is hard in difficulty and removed difficulty: medium fix is medium in difficulty labels Oct 28, 2017
@thinkingserious thinkingserious merged commit f049401 into master Dec 21, 2017
@thinkingserious
Copy link
Contributor

Hello @andy-trimble,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@jmayday
Copy link

jmayday commented Nov 16, 2018

Hi. Thanks for your work @andy-trimble
When this will be released? This change is only on master, not available on newest version of java-http-client (which is 4.2.0)
BTW. Shouldn't the sendgrid-java be updated to use java-http-client 4.2.0 and not 4.1.0?

@kwang1 kwang1 mentioned this pull request Jun 21, 2019
Closed
@childish-sambino childish-sambino deleted the response_fix branch January 16, 2020 23:31
@eshanholtz eshanholtz changed the title No longer throwing IOExceptions on non 2xx response codes. fix: No longer throwing IOExceptions on non 2xx response codes. Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andy-trimble @SendGridDX @mbernier @thinkingserious @jmayday @apigirl