Assign server response outside try block

[bluestealth]

An attempt to fix Sendgrid client doesn't close TCP connection properly #165.

[thinkingserious]

Hello @bluestealth,

Thanks for the PR!

Could you please take a moment to sign our CLA so we can review?

[thinkingserious]

I don't understand how this fixes sendgrid/sendgrid-java#165. It seems like the original code should be closing the connection at the end. Could you please elaborate on how your solution fixes the issue?

Some other questions:

1. Did you test this? If so, could you describe them? I'd like to reproduce.
2. By moving the httpClient.execute out of the try/catch/finally, how will we handle any exceptions at that function call.

Thanks!

[bluestealth]

You are correct that this doesn't fix the error, and could result in some exceptional states not being caught, but I can imagine some sequence of events where serverResponse.close() isn't called with the existing code. Give me a bit to think about that.

With this finalizer as long as the client nulls their reference to Class SendGrid or the class goes out of scope the port should be released. I have tested this on my own machine by nulling my reference, forcing garbage collection and then busy waiting to keep the process open.

    @Override
    public void finalize() throws Throwable {
        try {
            this.httpClient.close();
        } catch(IOException e) {
            throw new Throwable(e.getMessage());
        } finally {
            super.finalize();
        }
    }

[thinkingserious]

Thanks for the follow up!

I'm not quite sure what is going on here, but I plan to investigate further.

[thinkingserious]

It looks like this plugin is no longer under development, per: https://github.com/musketyr/gradle-fatjar-plugin

Do you mind converting to https://github.com/johnrengelman/shadow?

[thinkingserious]

@bluestealth,

Thanks again for your support! Please take a moment to fill out this form so that we send you some swag :)