Update the request object with sensible defaults and access methods, #13 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
requested changes
Oct 5, 2016
| Map<String,String> requestHeaders = new HashMap<String, String>(); | ||
| requestHeaders.put("Authorization", "Bearer " + System.getenv("SENDGRID_API_KEY")); | ||
| request.headers = requestHeaders; | ||
| request.getHeaders().put("Authorization", "Bearer " + System.getenv("SENDGRID_API_KEY")); |
There was a problem hiding this comment.
Can we use a setter here instead?
e.g. request.addHeader("Authorization", "Bearer " + System.getenv("SENDGRID_API_KEY"));
| queryParams.put("offset", "0"); | ||
| request.queryParams = queryParams; | ||
| request.getQueryParams().put("limit", "100"); | ||
| request.getQueryParams().put("offset", "0"); |
There was a problem hiding this comment.
Can we use a setter here instead?
e.g. request.addQueryParam("offset", "0");
| @@ -39,7 +35,7 @@ public static void main(String[] args) throws IOException { | |||
| } catch (IOException ex) { | |||
| throw ex; | |||
| } | |||
| request.queryParams = null; | |||
| request.getQueryParams().clear(); | |||
There was a problem hiding this comment.
How about request.clearQueryParams();
|
Will update it later tonight! Thanks for the feedback |
thinkingserious
added
type: community enhancement
…//github.com/belfazt/java-http-client into make-request-object-have-sensible-default-13
|
fixed! |
thinkingserious
approved these changes
Oct 7, 2016
thinkingserious
added a commit
that referenced
this pull request
Oct 7, 2016
…th sensible defaults and access methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.