Improve Error Handling

[boazca]

In The Client you use BasicResponseHandler to handle the response.
The problem is that when the status code is >= 300 HttpResponseException is thrown, ignoring the response body.
In Sendgrid v3 web API all the details of the failure are in the response body.
so when there is a failure, you have no information about what caused the problem.

You should either insert the response body to the exception message or return your Response even if the status code is >=300 (I think the second option is better).

[thinkingserious]

Thanks for the feedback @boazca!

This is on our roadmap and we appreciate your detailed feedback. I'll leave this ticket open to track when we implement this.

[thinkingserious]

@boazca,

This issue is resolved now: https://github.com/sendgrid/java-http-client/releases/tag/v2.3.3

Thanks again for the feedback!

I'll next be updating the dependency at sendgrid-java

[ifcwlme]

I think the problem haven't solved yet.

I am trying to get error response message from Response object. But the api call throws IOException, which should happen only when there is network error.

For http response code 400, 401, 413 error, It should be handled by Response java object, instead of IOException.

The relevant source code is in executeApiCall in com.sendgrid.Client.