-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #48 from pushkyn/add-pull-request-template
add github PR template
- Loading branch information
Showing
1 changed file
with
29 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<!-- | ||
Please explain WHAT you changed and WHY. | ||
|
||
The title should be descriptive, for example: | ||
|
||
* *Fixed a typo in the apikeypermissions.md page* | ||
* *Added the maximum number of domain whitelabels you can create to domains.md* | ||
* *Fixing the number of days a batch id is valid in scheduling_parameters.md* | ||
|
||
Fill out this form in the body: | ||
--> | ||
|
||
**Description of the change**: | ||
**Reason for the change**: | ||
**Link to original source**: | ||
<!-- | ||
If this pull request closes an issue, add in the issue number here | ||
--> | ||
Closes # | ||
|
||
### Checklist | ||
|
||
Make sure all of these items are complete, or else the PR will be ineligible for a code review. | ||
|
||
- [ ] Code passes all existing [tests](https://github.com/sendgrid/java-http-client/blob/master/src/test/java/com/sendgrid/ClientTest.java) | ||
- [ ] Any new functionality added includes new unit tests | ||
- [ ] Create or update example code to show the new functionality in action. | ||
- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/java-http-client/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions)) | ||
- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/java-http-client/blob/master/CONTRIBUTING.md#creating-a-pull-request)). |