-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add depositMany and unassigned convenience functions #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColePBryan
reviewed
Oct 19, 2023
ColePBryan
suggested changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small suggestions/ clarifying questions.
Closed
tmigone
force-pushed
the
tmigone/deposit-many
branch
from
October 19, 2023 16:51
df977c0
to
1b0af0a
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/deposit-many
branch
from
October 19, 2023 16:53
1b0af0a
to
daedadd
Compare
Signed-off-by: Tomás Migone <[email protected]>
@ColePBryan addressed the comments |
ColePBryan
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge
We'll wait for audit then merge. |
pcarranzav
reviewed
Oct 20, 2023
Signed-off-by: Tomás Migone <[email protected]>
feat: add unassigned deposits convenience methods
tmigone
changed the title
feat: add depositMany convenience function
feat: add depositMany and unassigned convenience functions
Nov 13, 2023
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/deposit-many
branch
from
December 6, 2023 14:34
9126869
to
17a3741
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/deposit-many
branch
from
December 6, 2023 14:41
244b9ac
to
e607248
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few convenience methods to facilitate deposit management for the gateway/sender:
depositMany()
: allows a sender to make multiple deposits with a single transactiondepositUnassigned()
: allows a third party to deposit escrow amount on behalf of a sender, and more importantly does not assign it to a receiver.assignDeposit()
: allows a sender to assign unassigned escrow to a receiverassignDepositMany()
: same as previous but allows assigning multiple amounts to multiple receivers at once.