Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add depositMany and unassigned convenience functions #69

Merged
merged 20 commits into from
Dec 6, 2023

Conversation

tmigone
Copy link
Collaborator

@tmigone tmigone commented Oct 19, 2023

This PR adds a few convenience methods to facilitate deposit management for the gateway/sender:

  • depositMany(): allows a sender to make multiple deposits with a single transaction
  • depositUnassigned(): allows a third party to deposit escrow amount on behalf of a sender, and more importantly does not assign it to a receiver.
  • assignDeposit(): allows a sender to assign unassigned escrow to a receiver
  • assignDepositMany(): same as previous but allows assigning multiple amounts to multiple receivers at once.

src/Escrow.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@ColePBryan ColePBryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small suggestions/ clarifying questions.

test/Escrow.t.sol Outdated Show resolved Hide resolved
test/Escrow.t.sol Outdated Show resolved Hide resolved
@ColePBryan ColePBryan linked an issue Oct 19, 2023 that may be closed by this pull request
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
Copy link
Collaborator Author

tmigone commented Oct 19, 2023

@ColePBryan addressed the comments

Copy link
Contributor

@ColePBryan ColePBryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Looks good to merge

@ColePBryan ColePBryan added the enhancement New feature or request label Oct 20, 2023
@tmigone
Copy link
Collaborator Author

tmigone commented Oct 20, 2023

We'll wait for audit then merge.

feat: add unassigned deposits convenience methods
@tmigone tmigone changed the title feat: add depositMany convenience function feat: add depositMany and unassigned convenience functions Nov 13, 2023
Signed-off-by: Tomás Migone <[email protected]>
@tmigone tmigone merged commit 8f21c1c into main Dec 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for batch deposits
3 participants