Skip to content

Conversation

skipi
Copy link
Contributor

@skipi skipi commented Sep 9, 2025

πŸ“ Description

Ephemeral environments UI

βœ… Checklist

  • I have tested this change
  • This change requires documentation update

@github-project-automation github-project-automation bot moved this to Backlog in Roadmap Sep 9, 2025
@skipi skipi force-pushed the mk/ephemeral-env/front-bootstrap branch from 56714b3 to 60824fb Compare September 9, 2025 12:41
@skipi skipi force-pushed the mk/ephemeral-env/front-bootstrap branch 2 times, most recently from 9838874 to 0308171 Compare October 6, 2025 07:12
@skipi skipi marked this pull request as ready for review October 6, 2025 07:13
@skipi skipi force-pushed the mk/ephemeral-env/front-bootstrap branch from 0308171 to 02d86bd Compare October 6, 2025 07:28
@skipi skipi force-pushed the mk/ephemeral-env/front-bootstrap branch from 02d86bd to 285c76f Compare October 6, 2025 07:30
@skipi skipi requested review from Copilot and removed request for TomFern October 6, 2025 08:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive UI for managing ephemeral environments. The implementation provides a complete CRUD interface for creating, editing, viewing, and managing ephemeral environment types and their configurations.

Key changes include:

  • Full UI implementation for ephemeral environments with React components and TypeScript
  • Backend controllers, models, and API endpoints for environment management
  • Mock and testing infrastructure for the new feature
  • Permission system integration and feature flag support

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
front/lib/front_web/controllers/ephemeral_environment_controller.ex Main controller handling CRUD operations for ephemeral environments
front/lib/front/models/ephemeral_environment.ex Data model and business logic for environment types
front/assets/js/ephemeral_environments/ Complete React/TypeScript UI implementation
front/test/front_web/controllers/ephemeral_environment_controller_test.exs Comprehensive test coverage for the controller
front/lib/front_web/router.ex Route definitions for the new endpoints
Comments suppressed due to low confidence (1)

front/assets/js/ephemeral_environments/components/EnvironmentDetails.tsx:1

  • The void operator is incorrectly applied to a callback function. This will always pass undefined instead of the actual callback function.
import { useState } from "preact/hooks";

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@skipi skipi requested a review from Copilot October 6, 2025 09:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 62 out of 62 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@skipi skipi changed the title Bootstraping UI for ephemeral environments Bootstrapping UI for ephemeral environments Oct 6, 2025
@skipi skipi requested a review from hamir-suspect October 7, 2025 08:25
@skipi skipi merged commit cde4ce4 into feat/ephemeral_environments Oct 7, 2025
2 checks passed
@skipi skipi deleted the mk/ephemeral-env/front-bootstrap branch October 7, 2025 10:54
skipi added a commit that referenced this pull request Oct 7, 2025
## πŸ“ Description
Ephemeral environments UI

## βœ… Checklist
- [x] I have tested this change
- [ ] This change requires documentation update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants