Skip to content
This repository was archived by the owner on Jan 20, 2023. It is now read-only.

fix(deps): update dependency @semantic-release/error to v3#144

Merged
UziTech merged 1 commit intomasterfrom
renovate/major-semantic-release-monorepo
Nov 18, 2021
Merged

fix(deps): update dependency @semantic-release/error to v3#144
UziTech merged 1 commit intomasterfrom
renovate/major-semantic-release-monorepo

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 17, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@semantic-release/error ^2.2.0 -> ^3.0.0 age adoption passing confidence

Release Notes

semantic-release/error

v3.0.0

Compare Source

BREAKING CHANGES
  • node-version: the minimum required version of node is now v14.17

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update includes breaking changes because of the restricted engines range that does not cover all that is defined for this plugin. we need to update the range of this plugin, which is breaking, in order to include these changes. we should add ls-engines to the build to protect from this situation going forward

@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch 2 times, most recently from 938efc7 to 8c8b61c Compare September 20, 2021 02:50
@UziTech
Copy link
Member

UziTech commented Sep 20, 2021

This is extending the range not restricting it. If anything this is a minor update since it is adding the ability to work with semantic-release v18.x

Edit: unless you are talking about the semantic-release/error update then I agree.

@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch from 8c8b61c to 84a5e5d Compare September 21, 2021 04:03
@renovate renovate bot changed the title fix(deps): update semantic-release monorepo (major) fix(deps): update dependency @semantic-release/error to v3 Sep 21, 2021
@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch 3 times, most recently from 7091e6e to 8479ca4 Compare September 27, 2021 06:28
@renovate renovate bot force-pushed the renovate/major-semantic-release-monorepo branch from 8479ca4 to e0f3f42 Compare October 2, 2021 20:40
@UziTech
Copy link
Member

UziTech commented Oct 2, 2021

@travi looks like this can be merged.

@travi
Copy link
Member

travi commented Oct 3, 2021

there isnt a big rush on this one, so i think i'd rather wait to see if ls-engines will have a new version released soon based on ljharb/ls-engines#23 to resolve the failure that was blocking the build from passing.

@UziTech UziTech force-pushed the renovate/major-semantic-release-monorepo branch from 254bef3 to 7ff3f8e Compare November 18, 2021 05:28
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for bringing this back to the top!

@UziTech UziTech merged commit 71a2090 into master Nov 18, 2021
@UziTech UziTech deleted the renovate/major-semantic-release-monorepo branch November 18, 2021 05:31
@travi
Copy link
Member

travi commented Nov 18, 2021

doesnt need to be part of this PR, but lets get the ls-engines check re-enabled in the workflow soon too

@github-actions
Copy link

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants