Skip to content
This repository was archived by the owner on Jan 20, 2023. It is now read-only.

feat(node-version): raised the minimum required version to v14.17#157

Merged
travi merged 4 commits intosemantic-release:masterfrom
UziTech:semantic-release-18
Sep 22, 2021
Merged

feat(node-version): raised the minimum required version to v14.17#157
travi merged 4 commits intosemantic-release:masterfrom
UziTech:semantic-release-18

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Sep 21, 2021

This includes an update for engines and ls-engines in ci

closes #155

travi
travi previously approved these changes Sep 21, 2021
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@travi
Copy link
Member

travi commented Sep 21, 2021

the ls-engines error in the ci run is the one related to ljharb/ls-engines#23. if we want to merge this before that is fixed in ls-engines, we could comment out that step in the workflow and open a follow up PR to uncomment.

travi
travi previously approved these changes Sep 21, 2021
@travi
Copy link
Member

travi commented Sep 21, 2021

looks like we need one more change to the workflow. with the addition of the node version matrix, the jobs no longer match the required "test"

in other projects, we have been handling this by including an additional job for verification steps that do not need to run against each node version. an example: https://github.com/semantic-release/github/blob/d1e09d958400db971ac9c1114699e58ff9f29900/.github/workflows/test.yml#L30-L43

if you would like to take a stab at including similar, you wouldnt need to include the ls-engines step a second time. based on what we have seen in your other contributions, i think that should be in the matrix job anyway. otherwise, i can try to get this worked out tonight.

@travi travi changed the title fix(deps): update semantic-release monorepo feat(node-version): raised the minimum required version to v14.17 Sep 22, 2021
@travi travi merged commit d0cb730 into semantic-release:master Sep 22, 2021
@github-actions
Copy link

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants