Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very nice lib! But a few things to add #3

Closed
burzum opened this issue Jul 22, 2013 · 15 comments
Closed

Very nice lib! But a few things to add #3

burzum opened this issue Jul 22, 2013 · 15 comments
Assignees
@selvinortiz

Comments

@burzum
Copy link

burzum commented Jul 22, 2013

  • unit tests
  • composer
  • maybe namespace it?
  • PSR compliance (but tabs over spaces, PLEASE)

Except this it's a great lib!
@krolow
Copy link
Contributor

krolow commented Jul 22, 2013

👍

@ghost ghost assigned selvinortiz Jul 22, 2013
@selvinortiz
Copy link
Owner

@burzum All great suggestions, thanks for the feedback.

  • Unit Tests (definitely)
  • Composer (maybe @ 0.5.0)
  • Namespacing (debated it but will add it for PSR compliance)
  • PSR Compliance (on next update) Tabs FTW: )

selvinortiz added a commit that referenced this issue Jul 23, 2013
@selvinortiz
[Issue #3] Flux 0.4.0
bc12685 
- Adds Flux to the Sortiz\Tools namespace
- Implements PSR-2 Compliance (Tabs over Spaces)
- Updates version number on Flux and this readme file
- Updates the class instantiation with fully qualified class name on example.php
- Adds references to other repos that have ported flux
- Addresses concerns outlined in [Issue #3](#3)
@selvinortiz
Copy link
Owner

@burzum @krolow Not fully PSR compliant or namespaced yet but getting there, tests and composer support will be next.

@krolow
Copy link
Contributor

krolow commented Jul 23, 2013

@selvinortiz cool, anything that you want help let me know, really great project!

@tristanbes
Copy link

composer is a must for any PHP library ! Let's hope it comes quickly ;-)

@burzum
Copy link
Author

burzum commented Jul 23, 2013

@selvinortiz 👍 Thanks for the fast response.

selvinortiz added a commit that referenced this issue Jul 23, 2013
@selvinortiz
Flux 0.4.5
9112f0a 
~- Fixes internal namespace conflict
- Changes namespace from Sortiz\Tools to SelvinOrtiz\Utils\Flux
- Adds composer support [Issue #3](#3)
- Adds the addSeed() and removeSeed() methods [Issue #4](#4)
- Adds the getInstance() static method
- Adds FluxUrlExample.php, FluxDateExample.php, and FluxPhoneExample.php
- Adds getSeed() to get the seed without forcing __toString on the object
- Adds getSegment() to extract a segment (capturing group) from the pattern
- Implements unit tests (60% coverage) [Issue #3](#3)
- Implements Full PSR-2 Compliance (Tabs over Spaces)
- Enables the seed on match() and replace() [Issue #4](#4)
- Removes example.php and defines them elsewhere
- Moves examples into /etc and defines one example per file
- Other small fixes and additions
@selvinortiz
Copy link
Owner

I've got unit tests in place (60% coverage), namespace, PSR-2 compliance (tabs over spaces), and composer support. I'll be uploading to packagist.org some time today and update the readme when it's done.

Thank you all for your feedback and support!

@selvinortiz
Copy link
Owner

@krolow Thank you. I'll try to find some time to add contributing notes and a TODO for more complex issues that arise from more advanced use cases of regular expressions via the fluent builder.

@moacirosa
Copy link

👍

@moacirosa
Copy link

I'd noticed that you have some system to create tags but the repository doesn't have tags (releases) itself. I'll suggest making use of Semantic Version. By the way it will be important to Composer.

@burzum
Copy link
Author

burzum commented Jul 23, 2013

Just another 👍 for the good work :)

@selvinortiz
Copy link
Owner

Thanks @burzum : )

Great point @moacirosa and yes, tagged releases are definitely important for composer...

This weekend project of mine has gotten more interest than I had anticipated so I'm sorry for not getting everything setup properly right out of the gate but my goal is to ultimately make the library usable, standards compliant, environment friendly, and robust. I work in an enterprise, team environment so I know this things are important and I'll treat them as such.

Again, thanks for all your feedback and support!

@selvinortiz
Copy link
Owner

@moacirosa Tagged releases have been enabled https://github.com/selvinortiz/flux/releases and will be used from now on using Semantic Version as suggested by you and good practices in general.

@moacirosa
Copy link

💯 Man... Its awesome! 3 days and all this progress. Thanks for accepting the sugestion and I'll try to help in some way at night (UTC-3)

@selvinortiz
Copy link
Owner

@moacirosa Thanks bro, I appreciate that!

@selvinortiz selvinortiz reopened this Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@selvinortiz selvinortiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@krolow @burzum @moacirosa @tristanbes @selvinortiz