Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Improvement of gilded-rose-kata repo: Js code #1

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

selma-belhadj
Copy link
Owner

What does this PR do?

  • This PR is raised to review & improve the js code in this forked repo

Description of the task to be completed

  • Suggest DRY, KISS, YAGNI pieces of code
  • Suggest renaming variables and functions following the best practices of JS
  • Suggest using let instead of var
  • Suggest using forEach instead of for
  • Define Item as a class instead of just function & define needed methods
  • Add tests for item class methods using jest framework
  • Add tests for updateQuality method using jest framework

How should it be tested

  • clone the repository by running
    git clone https://github.com/CircleCI-Archived/gilded-rose-kata.git
  • navigate to the folder
    cd gilded-rose-kata
  • Install packages
    npm install
  • Run the app
    npm start
  • Run the test
    npm run test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant