Chore fix ios nfc scanning and compiling

[transphorm]

Summary by CodeRabbit

• New Features

  • Added in-app analytics event tracking and manual flush controls.
  • Queues analytics during NFC scans and auto-flushes afterward; added API to mark scanning active.
  • Introduced a unified cross-platform passport scanning bridge with safe fallbacks.

• Bug Fixes

  • Clearer user-facing errors when NFC scanning is unavailable.
  • Prevented analytics flushes during active NFC scans to avoid interruptions.

• Refactor

  • Consolidated passport reader imports into a new utility and standardized scan options/results.

• Tests

  • Updated mocks and tests to the new module, including reset support.

[coderabbitai]

Walkthrough

Adds RN bridge methods trackEvent and flush to iOS PassportReader; integrates SelfAnalytics/Mixpanel flush; introduces a cross-platform PassportReader JS wrapper; updates analytics to queue/flush events based on NFC scanning state; adds runtime guards in nfcScanner; updates tests and Jest mocks; wires NFC scanning state in PassportNFCScanScreen.

Changes

Cohort / File(s)	Summary
iOS RN Bridge Methods app/ios/PassportReader.m, app/ios/PassportReader.swift	Exported trackEvent(name:properties:) and flush to React Native; PassportReader now holds an analytics instance and forwards events/flush; integrates analytics into NFCPassportReader init.
iOS Analytics app/ios/SelfAnalytics.swift	Added flush() delegating to Mixpanel; added console print in trackEvent; formatting tweaks.
Cross-platform PassportReader wrapper app/src/utils/passportReader.ts	New platform-adaptive module exporting PassportReader, reset, scan, and type ScanOptions; dynamic require on Android, NativeModules on iOS, no-op on unsupported platforms; normalizes scan result.
Analytics queueing and flush policy app/src/utils/analytics.ts	Introduced isNfcScanningActive, eventQueue, setNfcScanningActive; guarded flushes during NFC scans; queued events when offline/scanning; batch flush after threshold; updated imports to new wrapper.
NFC Scanner guards app/src/utils/nfcScanner.ts	Switched to new wrapper; added runtime guards for missing native module on Android/iOS with user-facing errors.
Screen wiring for NFC state app/src/screens/passport/PassportNFCScanScreen.tsx	Calls setNfcScanningActive(true/false) on scan start/cleanup/timeout; queues failure events on timeout; removed a prior flush call before opening settings.
Tests and Jest setup app/tests/src/nativeModules/passportReader.simple.test.ts, app/tests/utils/nfcScanner.test.ts, app/jest.setup.js	Updated imports to new wrapper; expanded Jest mock for ./src/utils/passportReader with trackEvent/flush/reset; added reset to NativeModules mock; set mocked scan arity.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor UI as PassportNFCScanScreen
  participant A as analytics.ts
  participant PR as PassportReader (JS wrapper)
  participant iOS as iOS Native (PassportReader.swift)
  participant MP as Mixpanel

  rect rgb(245,248,255)
  note over UI,A: Start NFC scan
  UI->>A: setNfcScanningActive(true)
  end

  rect rgb(244,255,245)
  note over UI,A: Track NFC events during scan
  UI->>A: trackNfcEvent(name, props)
  alt scanning active or offline
    A->>A: enqueue event
  else connected and not scanning
    A->>PR: PassportReader.trackEvent(name, props)
    PR->>iOS: trackEvent(name, props)
    iOS->>MP: trackEvent(name, props)
    opt threshold reached
      A->>PR: PassportReader.flush()
      PR->>iOS: flush()
      iOS->>MP: flush()
    end
  end
  end

  rect rgb(255,250,240)
  note over UI,A: Scan ends (success or timeout)
  UI->>A: setNfcScanningActive(false)
  A->>PR: drain queued -> trackEvent(...)
  PR->>iOS: trackEvent(...)
  iOS->>MP: trackEvent(...)
  A->>PR: flush()
  PR->>iOS: flush()
  iOS->>MP: flush()
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• feat: improve mixpanel flush strategy #960 — Adds/adjusts analytics bridge methods (trackEvent/flush) and related flush logic; overlaps with new RN/iOS analytics surface.
• Fix nfc configuration scanning issue #978 — Updates native/Jest mocks for PassportReader including trackEvent/flush/reset; mirrors the mocking changes here.
• SELF-501: Integrate Loki and Sentry logging #791 — Modifies iOS analytics integration (SelfAnalytics/PassportReader); related to adding analytics methods and wiring.

Suggested labels

codex

Suggested reviewers

• remicolin

Poem

Beeps of the chip, a whisper near,
Events queue softly—hold them here.
When scans subside, the floodgates push,
Mixpanel sips a timely flush.
Bridge now speaks in measured tone,
Passport read, and data flown. ✈️📱

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch justin/chore-fix-ios-nfc-scanning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (9)

app/ios/SelfAnalytics.swift (2)

15-27: Stop logging analytics properties in production (PII risk).

trackEvent prints and forwards raw properties unconditionally. This can leak PII and adds overhead during high-frequency NFC events. Gate all console/log bridge emissions behind enableDebugLogs.

Apply this diff:

     public override func trackEvent(_ name: String, properties: Properties? = nil) {
         super.trackEvent(name, properties: properties)
-
-        print("[NFC Analytics] Event: \(name), Properties: \(properties ?? [:])")
-
-        if let logger = NativeLoggerBridge.shared {
-            logger.sendEvent(withName: "logEvent", body: [
-                "level": "info",
-                "category": "NFC",
-                "message": "Analytics Event: \(name)",
-                "data": properties ?? [:]
-            ])
-        }
+        if enableDebugLogs {
+            print("[NFC Analytics] Event: \(name), Properties: \(properties ?? [:])")
+            if let logger = NativeLoggerBridge.shared {
+                logger.sendEvent(withName: "logEvent", body: [
+                    "level": "info",
+                    "category": "NFC",
+                    "message": "Analytics Event: \(name)",
+                    "data": properties ?? [:]
+                ])
+            }
+        }
     }

---

47-64: Avoid leaking detailed error info to console in production.

trackError prints the full error message unconditionally. Print only when enableDebugLogs is true; keep structured logging if needed.

     public override func trackError(_ error: Error, context: String) {
         super.trackError(error, context: context)
-
-        print("[NFC Analytics Error] Context: \(context), Error: \(error.localizedDescription)")
+        if enableDebugLogs {
+            print("[NFC Analytics Error] Context: \(context), Error: \(error.localizedDescription)")
+        }
 
         if let logger = NativeLoggerBridge.shared {
             logger.sendEvent(withName: "logEvent", body: [
                 "level": "error",
                 "category": "NFC",
                 "message": "Analytics Error: \(error.localizedDescription)",
                 "data": [
                     "error_type": String(describing: type(of: error)),
                     "error_description": error.localizedDescription,
                     "context": context
                 ]
             ])
         }
     }

app/src/utils/analytics.ts (3)

176-198: Fix event loss on flush failures and prevent concurrent flushes.

Current logic shifts events before send and never re-queues on failure; duplicates can also occur if flushMixpanelEvents runs concurrently. Add a single-flight guard and re-queue unsent events.

Apply this diff:

 const flushMixpanelEvents = async () => {
   if (!MIXPANEL_NFC_PROJECT_TOKEN) return;
-  try {
-    if (__DEV__) console.log('[Mixpanel] flush');
-    // Send any queued events before flushing
-    while (eventQueue.length > 0) {
-      const evt = eventQueue.shift()!;
-      if (PassportReader.trackEvent) {
-        await Promise.resolve(
-          PassportReader.trackEvent(evt.name, evt.properties),
-        );
-      }
-    }
-    if (PassportReader.flush) await Promise.resolve(PassportReader.flush());
-    eventCount = 0;
-  } catch (err) {
-    if (__DEV__) console.warn('Mixpanel flush failed', err);
-    // re-queue on failure
-    if (typeof err !== 'undefined') {
-      // no-op, events are already queued if failure happened before flush
-    }
-  }
+  if (isFlushing) return;
+  isFlushing = true;
+  try {
+    if (__DEV__) console.log('[Mixpanel] flush');
+    const batch = eventQueue.splice(0); // drain
+    for (let idx = 0; idx < batch.length; idx++) {
+      const evt = batch[idx];
+      try {
+        if (PassportReader.trackEvent) {
+          await Promise.resolve(PassportReader.trackEvent(evt.name, evt.properties));
+        }
+      } catch (err) {
+        if (__DEV__) console.warn('Mixpanel event send failed; re-queuing', err);
+        // Re-queue current and remaining events
+        eventQueue.unshift(...batch.slice(idx));
+        return;
+      }
+    }
+    if (PassportReader.flush) await Promise.resolve(PassportReader.flush());
+    eventCount = 0;
+  } finally {
+    isFlushing = false;
+  }
 };

Add these module-level declarations (outside this range):

// near other module-level vars
let isFlushing = false;

---

245-261: Bound the offline event queue to avoid unbounded memory growth.

Add a capacity and drop oldest to prevent leaks/crashes.

Apply this diff:

   if (!isConnected) {
-    eventQueue.push({ name, properties });
+    if (eventQueue.length >= MAX_QUEUE) eventQueue.shift();
+    eventQueue.push({ name, properties });
     return;
   }
 ...
-  } catch {
-    eventQueue.push({ name, properties });
+  } catch {
+    if (eventQueue.length >= MAX_QUEUE) eventQueue.shift();
+    eventQueue.push({ name, properties });
   }

Add this module-level constant:

// near other module-level vars
const MAX_QUEUE = 500;

---

200-224: Prevent duplicate configuration and listener registration (race).

configureNfcAnalytics can be invoked concurrently, leading to multiple listeners. Add an in-flight guard and finalize it in finally.

Apply this diff:

 export const configureNfcAnalytics = async () => {
-  if (!MIXPANEL_NFC_PROJECT_TOKEN || mixpanelConfigured) return;
+  if (!MIXPANEL_NFC_PROJECT_TOKEN || mixpanelConfigured || mixpanelConfigInFlight) return;
+  mixpanelConfigInFlight = true;
+  try {
   const enableDebugLogs =
     String(ENABLE_DEBUG_LOGS ?? '')
       .trim()
       .toLowerCase() === 'true';
@@
   setupFlushPolicies();
   mixpanelConfigured = true;
+  } finally {
+    mixpanelConfigInFlight = false;
+  }
 };

Add this module-level flag:

// near other module-level vars
let mixpanelConfigInFlight = false;

app/src/utils/nfcScanner.ts (2)

158-166: Normalize DG2 hash type across platforms.

Android path passes through dg2Hash as-is (string/array), while iOS returns a byte array. Normalize to a byte array for consistency.

Apply this diff:

-  const dg2Hash = dgHashesObj['2'];
+  const dg2HashRaw = dgHashesObj['2'];
+  const dg2Hash =
+    Array.isArray(dg2HashRaw)
+      ? dg2HashRaw
+      : Array.from(Buffer.from(String(dg2HashRaw), 'hex'));

---

106-111: Wrap iOS PEM in header/footer to match Android
Change the pem assignment in app/src/utils/nfcScanner.ts (around lines 106–107) to:

-  const pem = JSON.parse(documentSigningCertificate).PEM.replace(/\n/g, '');
+  const pemBase64 = JSON.parse(documentSigningCertificate).PEM.replace(/\n/g, '');
+  const pem = `-----BEGIN CERTIFICATE-----${pemBase64}-----END CERTIFICATE-----`;

Update the expected certificate strings in app/tests/utils/nfcScanner.test.ts (lines 39, 61, 111) to include the -----BEGIN CERTIFICATE-----…-----END CERTIFICATE----- markers.

app/ios/PassportReader.swift (2)

146-153: Stop logging PII (passportNumber) to the native logger

Passport numbers are highly sensitive. Remove them from logs to avoid leakage to device logs or remote collectors.

Apply:

-      NativeLoggerBridge.logInfo(category: "NFC", message: "NFC passport scan started", data: [
-        "passportNumber": passportNumber,
+      NativeLoggerBridge.logInfo(category: "NFC", message: "NFC passport scan started", data: [
         "useCAN": useCANBool,
         "skipPACE": skipPACEBool,
         "skipCA": skipCABool,
         "extendedMode": extendedModeBool,
         "usePacePolling": usePacePollingBool
       ])

If you must correlate sessions, log a non-reversible digest with a salt stored client-side only (but prefer not logging any identifier at all).

---

159-165: Enforce numeric-only CAN to match the error message and reduce invalid reads

Currently only length is checked while the message says “6 digits”. Validate digits to prevent unnecessary NFC sessions.

Apply:

         if useCANBool {
-          if canNumber.count != 6 {
-            reject("E_PASSPORT_READ", "CAN number must be 6 digits", nil)
+          let isSixDigits = canNumber.count == 6 &&
+            CharacterSet.decimalDigits.isSuperset(of: CharacterSet(charactersIn: canNumber))
+          if !isSixDigits {
+            reject("E_PASSPORT_READ", "CAN number must be 6 digits (0-9)", nil)
             return
           }

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0e3e5de and 34576c7.

📒 Files selected for processing (8)

• app/ios/PassportReader.m (1 hunks)
• app/ios/PassportReader.swift (2 hunks)
• app/ios/SelfAnalytics.swift (4 hunks)
• app/src/utils/analytics.ts (1 hunks)
• app/src/utils/nfcScanner.ts (1 hunks)
• app/src/utils/passportReader.ts (1 hunks)
• app/tests/src/nativeModules/passportReader.simple.test.ts (1 hunks)
• app/tests/utils/nfcScanner.test.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

app/ios/**/*

⚙️ CodeRabbit configuration file

app/ios/**/*: Review iOS-specific code for:

• Platform-specific implementations
• Performance considerations
• Security best practices for mobile

Files:

• app/ios/PassportReader.m
• app/ios/PassportReader.swift
• app/ios/SelfAnalytics.swift

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)

**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)

Files:

• app/tests/src/nativeModules/passportReader.simple.test.ts
• app/src/utils/nfcScanner.ts
• app/tests/utils/nfcScanner.test.ts
• app/src/utils/analytics.ts
• app/src/utils/passportReader.ts

**/*.{test,spec}.{ts,js,tsx,jsx}

⚙️ CodeRabbit configuration file

**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:

• Test coverage completeness
• Test case quality and edge cases
• Mock usage appropriateness
• Test readability and maintainability

Files:

• app/tests/src/nativeModules/passportReader.simple.test.ts
• app/tests/utils/nfcScanner.test.ts

app/src/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:

• Component architecture and reusability
• State management patterns
• Performance optimizations
• TypeScript type safety
• React hooks usage and dependencies
• Navigation patterns

Files:

• app/src/utils/nfcScanner.ts
• app/src/utils/analytics.ts
• app/src/utils/passportReader.ts

🧠 Learnings (6)

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/ios/**/*.{swift} : iOS NFC: implement custom PassportReader as a Swift module

Applied to files:

• app/ios/PassportReader.m
• app/tests/src/nativeModules/passportReader.simple.test.ts
• app/src/utils/nfcScanner.ts
• app/tests/utils/nfcScanner.test.ts
• app/ios/PassportReader.swift
• app/src/utils/analytics.ts
• app/src/utils/passportReader.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/android/**/*.{kt,kts} : Android NFC: implement RNPassportReaderModule in Kotlin

Applied to files:

• app/tests/src/nativeModules/passportReader.simple.test.ts
• app/src/utils/nfcScanner.ts
• app/tests/utils/nfcScanner.test.ts
• app/src/utils/passportReader.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to tests/src/**/*.{ts,tsx,js,jsx} : Use tests/ alias for test imports

Applied to files:

• app/tests/src/nativeModules/passportReader.simple.test.ts
• app/tests/utils/nfcScanner.test.ts

📚 Learning: 2025-08-25T14:25:57.586Z

Learnt from: aaronmgdr
PR: selfxyz/self#951
File: app/src/providers/authProvider.web.tsx:17-18
Timestamp: 2025-08-25T14:25:57.586Z
Learning: The selfxyz/mobile-sdk-alpha/constants/analytics import path is properly configured with SDK exports, Metro aliases, and TypeScript resolution. Import changes from @/consts/analytics to this path are part of valid analytics migration, not TypeScript resolution issues.

Applied to files:

• app/tests/src/nativeModules/passportReader.simple.test.ts
• app/src/utils/analytics.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to contracts/contracts/IdentityVerificationHubImplV2.sol : Identity Verification Hub: manage multi-step verification for passports and EU ID cards, handle document attestation via ZK proofs, and implement E-PASSPORT and EU_ID_CARD paths in IdentityVerificationHubImplV2.sol

Applied to files:

• app/tests/src/nativeModules/passportReader.simple.test.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Provide a unified JavaScript interface for NFC with platform detection

Applied to files:

• app/tests/utils/nfcScanner.test.ts

🧬 Code graph analysis (3)

app/ios/PassportReader.swift (1)

app/ios/SelfAnalytics.swift (2)

• trackEvent (15-28)
• flush (66-68)

app/src/utils/passportReader.ts (3)

app/src/utils/nfcScanner.ts (1)

• scan (50-56)

app/android/react-native-passport-reader/index.android.js (1)

• NativeModules (5-5)

app/src/screens/MainScreen.tsx (1)

• Platform (106-115)

app/ios/SelfAnalytics.swift (1)

app/ios/PassportReader.swift (2)

• trackEvent (59-66)
• flush (68-71)

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: build-android
• GitHub Check: test
• GitHub Check: build-ios
• GitHub Check: e2e-ios
• GitHub Check: analyze-ios
• GitHub Check: analyze-android

🔇 Additional comments (7)

app/ios/SelfAnalytics.swift (1)

66-68: Flush bridge looks good.

The public flush() forwarding to Mixpanel is appropriate.

app/tests/src/nativeModules/passportReader.simple.test.ts (1)

10-10: Import migration to wrapper is correct.

Aligns tests with the cross-platform @/utils/passportReader interface.

app/tests/utils/nfcScanner.test.ts (1)

9-9: Import migration to unified wrapper is correct.

Keeps tests aligned with the platform-adaptive module.

app/ios/PassportReader.m (1)

18-22: RN bridge additions look correct

Signatures align with the Swift selectors. No issues from a platform or security standpoint.

app/ios/PassportReader.swift (1)

318-321: Return a JSON object (not a string) to minimize payload overhead and keep x-plat contract sane

Serializing to a string adds unnecessary encoding/decoding and risks API drift versus Android. Prefer resolving the dictionary directly or ensure the TS layer normalizes. If changing native is risky right now, confirm the TS wrapper always parses iOS responses before use.

Would you like me to open a follow-up PR that flips resolve(stringified) to resolve(ret) and updates the TS caller(s)?

app/src/utils/passportReader.ts (2)

69-70: Consider exporting trackEvent/flush pass-throughs for clarity

If callers expect named exports, add thin wrappers; otherwise ignore. This avoids accidental imports from NativeModules elsewhere.

Apply if desired:

-export { PassportReader, reset, scan };
+export const trackEvent = (name: string, properties?: Record<string, unknown>) =>
+  PassportReader?.trackEvent?.(name, properties);
+export const flush = () => PassportReader?.flush?.();
+
+export { PassportReader, reset, scan, trackEvent, flush };

Please confirm how app/src/utils/analytics.ts consumes this module (default vs named).

---

12-25: No interop adjustments needed for Android PassportReader

Verified that the CommonJS module spreads RNPassportReader and defines top-level scan and reset exports, so the existing require('react-native-passport-reader') usage is correct.

[coderabbitai]

⚠️ Potential issue

Guard Mixpanel import to avoid E2E/CI compile breaks

Unconditional import Mixpanel can fail in E2E or CI where Mixpanel isn’t linked. Wrap it.

Apply:

-import Mixpanel
+#if canImport(Mixpanel)
+import Mixpanel
+#endif

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	import Mixpanel
	#if canImport(Mixpanel)
	import Mixpanel
	#endif

🤖 Prompt for AI Agents

In app/ios/PassportReader.swift around line 16, the unconditional import
Mixpanel can cause compile failures in E2E/CI when the Mixpanel framework isn’t
linked; wrap the import with a compile-time check using Swift's conditional
import (e.g., #if canImport(Mixpanel) import Mixpanel #endif) and ensure any
subsequent references to Mixpanel are either guarded by the same #if
canImport(Mixpanel) blocks or replaced with a no-op alternative so the file
compiles when Mixpanel is unavailable.

[coderabbitai]

⚠️ Potential issue

Add E2E stubs for trackEvent/flush to keep the RN API consistent

The bridge declares these methods unconditionally in Objective-C. In E2E builds, missing selectors can cause runtime errors if JS calls them.

Apply near the E2E stub class:

 class PassportReader: NSObject {
     override init() {
         super.init()
     }
 
+    @objc(trackEvent:properties:)
+    func trackEvent(_ name: String, properties: [String: Any]?) {
+        // No-op in E2E testing
+    }
+
+    @objc(flush)
+    func flush() {
+        // No-op in E2E testing
+    }
+
     @objc(configure:enableDebugLogs:)
     func configure(token: String, enableDebugLogs: Bool) {
         // No-op for E2E testing
     }

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In app/ios/PassportReader.swift around lines 59 to 72, the Obj-C bridge methods
trackEvent(_:properties:) and flush() are declared unconditionally but not
present in the E2E stub class, which can cause missing-selector crashes when JS
calls them; add matching stub methods to the E2E stub class that expose
@objc(trackEvent:properties:) func trackEvent(_ name: String, properties:
[String: Any]?) and @objc(flush) func flush(), each implementing a no-op (or
safe logging) and returning without side effects so the RN API is consistent
across builds.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

app/src/utils/analytics.ts (2)

182-209: Event loss and reentrancy risk in flushMixpanelEvents.

• If PassportReader.trackEvent throws mid-drain, the popped event is lost.
• Concurrent callers can interleave flushes.

Apply:

 const flushMixpanelEvents = async () => {
   if (!MIXPANEL_NFC_PROJECT_TOKEN) return;
   // Skip flush if NFC scanning is active to prevent interference
   if (isNfcScanningActive) {
     if (__DEV__) console.log('[Mixpanel] flush skipped - NFC scanning active');
     return;
   }
-  try {
+  if (isMixpanelFlushing) {
+    if (__DEV__) console.log('[Mixpanel] flush skipped - already flushing');
+    return;
+  }
+  isMixpanelFlushing = true;
+  try {
     if (__DEV__) console.log('[Mixpanel] flush');
     // Send any queued events before flushing
     while (eventQueue.length > 0) {
       const evt = eventQueue.shift()!;
-      if (PassportReader.trackEvent) {
-        await Promise.resolve(
-          PassportReader.trackEvent(evt.name, evt.properties),
-        );
-      }
+      if (PassportReader.trackEvent) {
+        try {
+          await Promise.resolve(
+            PassportReader.trackEvent(evt.name, evt.properties),
+          );
+        } catch (err) {
+          // requeue to the front and abort this flush; will retry later
+          eventQueue.unshift(evt);
+          throw err;
+        }
+      }
     }
     if (PassportReader.flush) await Promise.resolve(PassportReader.flush());
     eventCount = 0;
   } catch (err) {
     if (__DEV__) console.warn('Mixpanel flush failed', err);
-    // re-queue on failure
-    if (typeof err !== 'undefined') {
-      // no-op, events are already queued if failure happened before flush
-    }
+    // no-op: failed event was re-queued above
+  } finally {
+    isMixpanelFlushing = false;
   }
 };

Add these defs near eventQueue:

// outside-changes: add near eventQueue/eventCount
const MAX_EVENT_QUEUE_SIZE = 500;
let isMixpanelFlushing = false;

---

274-286: Cap queued events to prevent unbounded memory growth.
Apply back-pressure when offline or scanning to avoid OOM on long sessions.

Apply:

-  if (!isConnected || isNfcScanningActive) {
-    eventQueue.push({ name, properties });
+  if (!isConnected || isNfcScanningActive) {
+    if (eventQueue.length >= MAX_EVENT_QUEUE_SIZE) {
+      eventQueue.shift(); // drop oldest
+    }
+    eventQueue.push({ name, properties });
     return;
   }

Mirror the same cap in the catch block below when re-queuing the failed event.

🧹 Nitpick comments (1)

app/src/utils/passportReader.ts (1)

24-37: Android dynamic require fallback is fine; consider typing for stability.
Current any typing is pragmatic; no blocker. If churn continues, introduce a minimal PassportReaderBridge type for trackEvent/flush/scan to catch regressions at compile time.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 34576c7 and b7e2755.

📒 Files selected for processing (5)

• app/jest.setup.js (1 hunks)
• app/src/screens/passport/PassportNFCScanScreen.tsx (3 hunks)
• app/src/utils/analytics.ts (5 hunks)
• app/src/utils/nfcScanner.ts (3 hunks)
• app/src/utils/passportReader.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)

**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)

Files:

• app/src/utils/passportReader.ts
• app/src/screens/passport/PassportNFCScanScreen.tsx
• app/src/utils/nfcScanner.ts
• app/src/utils/analytics.ts

app/src/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:

• Component architecture and reusability
• State management patterns
• Performance optimizations
• TypeScript type safety
• React hooks usage and dependencies
• Navigation patterns

Files:

• app/src/utils/passportReader.ts
• app/src/screens/passport/PassportNFCScanScreen.tsx
• app/src/utils/nfcScanner.ts
• app/src/utils/analytics.ts

app/jest.setup.js

📄 CodeRabbit inference engine (.cursor/rules/mobile-sdk-migration.mdc)

Provide comprehensive Jest setup in app/jest.setup.js with required mocks

Files:

• app/jest.setup.js

🧠 Learnings (7)

📓 Common learnings

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/ios/**/*.{swift} : iOS NFC: implement custom PassportReader as a Swift module

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/android/**/*.{kt,kts} : Android NFC: implement RNPassportReaderModule in Kotlin

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/ios/**/*.{swift} : iOS NFC: implement custom PassportReader as a Swift module

Applied to files:

• app/src/utils/passportReader.ts
• app/jest.setup.js
• app/src/utils/nfcScanner.ts
• app/src/utils/analytics.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/android/**/*.{kt,kts} : Android NFC: implement RNPassportReaderModule in Kotlin

Applied to files:

• app/src/utils/passportReader.ts
• app/src/utils/nfcScanner.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to jest.setup.js : Maintain comprehensive mocks in jest.setup.js for all native modules

Applied to files:

• app/jest.setup.js

📚 Learning: 2025-08-24T18:54:04.809Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to app/jest.setup.js : Provide comprehensive Jest setup in app/jest.setup.js with required mocks

Applied to files:

• app/jest.setup.js

📚 Learning: 2025-08-24T18:54:04.809Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to app/jest.config.cjs : Use Jest in the app with a React Native preset configured in app/jest.config.cjs

Applied to files:

• app/jest.setup.js

📚 Learning: 2025-08-25T14:25:57.586Z

Learnt from: aaronmgdr
PR: selfxyz/self#951
File: app/src/providers/authProvider.web.tsx:17-18
Timestamp: 2025-08-25T14:25:57.586Z
Learning: The selfxyz/mobile-sdk-alpha/constants/analytics import path is properly configured with SDK exports, Metro aliases, and TypeScript resolution. Import changes from @/consts/analytics to this path are part of valid analytics migration, not TypeScript resolution issues.

Applied to files:

• app/src/utils/analytics.ts

🧬 Code graph analysis (5)

app/src/utils/passportReader.ts (2)

app/android/react-native-passport-reader/index.android.js (1)

• NativeModules (5-5)

app/ios/PassportReader.swift (1)

• scanPassport (78-239)

app/src/screens/passport/PassportNFCScanScreen.tsx (1)

app/src/utils/analytics.ts (1)

• setNfcScanningActive (254-265)

app/jest.setup.js (1)

app/ios/PassportReader.swift (2)

• iOS (32-364)
• scanPassport (78-239)

app/src/utils/nfcScanner.ts (3)

app/src/utils/passportReader.ts (1)

• PassportReader (88-88)

app/src/mocks/react-native-passport-reader.ts (1)

• PassportReader (8-28)

app/src/types/react-native-passport-reader.d.ts (1)

• PassportReader (48-48)

app/src/utils/analytics.ts (3)

app/src/Segment.ts (1)

• createSegmentClient (43-76)

app/src/screens/MainScreen.tsx (1)

• Platform (106-115)

app/src/utils/cameraScanner.ts (2)

• useNavigationStore (7-62)
• mrzInfo (35-56)

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build-android
• GitHub Check: build-ios
• GitHub Check: test
• GitHub Check: e2e-ios
• GitHub Check: analyze-android

🔇 Additional comments (9)

app/src/utils/nfcScanner.ts (2)

11-15: Import switch to cross-platform wrapper looks good.
Aligns usage across the codebase and centralizes platform branching.

---

78-87: Good defensive check for missing iOS bridge.
Clear warning and user-facing error; prevents undefined-call crashes.

app/jest.setup.js (1)

240-241: NativeModules.PassportReader.reset mock added — OK.
Keeps mock parity with the JS wrapper and prevents undefined access in tests.

app/src/screens/passport/PassportNFCScanScreen.tsx (1)

48-52: Correctly gating analytics flush during NFC scanning.
Setting setNfcScanningActive(true) at start, clearing it on timeout and in finally prevents flush interference and ensures queued events drain post-scan.

Also applies to: 208-210, 217-217, 379-379

app/src/utils/analytics.ts (3)

245-249: Appropriate flush gate while scanning.
Prevents Mixpanel flush during active NFC scans.

---

254-265: State toggle with post-scan drain is correct.
Simple API; logs in dev; triggers deferred flush safely after scans.

---

13-14: Bridge methods verified across platforms.
iOS: PassportReader.swift defines @objc trackEvent(name:properties:) and flush() methods.
Android: RNPassportReaderModule.kt exports @ReactMethod trackEvent and flush, and index.android.js spreads RNPassportReader, exposing both methods in JS.

app/src/utils/passportReader.ts (2)

60-77: iOS result normalization is good.
Parsing JSON string protects downstream code from platform-specific shapes.

---

45-70: Signature alignment confirmed: the Swift @objc annotation in PassportReader.swift lists scanPassport:dateOfBirth:dateOfExpiry:canNumber:useCan:skipPACE:skipCA:extendedMode:usePacePolling:resolve:reject, and the RCT_EXTERN_METHOD in PassportReader.m mirrors all nine input parameters plus the resolve/reject blocks—exactly matching the nine arguments passed from JS.

[coderabbitai]

🛠️ Refactor suggestion

Mock the aliased module name and expose ESM default to avoid resolution edge cases.
Using a relative path here can miss consumers importing via '@/...'. Also, expose __esModule to keep default import interop stable.

Apply:

-// Mock @/utils/passportReader to properly expose the interface expected by tests
-jest.mock('./src/utils/passportReader', () => {
+// Mock @/utils/passportReader to properly expose the interface expected by tests
+jest.mock('@/utils/passportReader', () => {
   const mockScanPassport = jest.fn();
   // Mock the parameter count for scanPassport (iOS native method takes 9 parameters)
   Object.defineProperty(mockScanPassport, 'length', { value: 9 });

   const mockPassportReader = {
     configure: jest.fn(),
     scanPassport: mockScanPassport,
     trackEvent: jest.fn(),
     flush: jest.fn(),
     reset: jest.fn(),
   };

   return {
+    __esModule: true,
     PassportReader: mockPassportReader,
     reset: jest.fn(),
     scan: jest.fn(),
     default: mockPassportReader,
   };
 });

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// Mock @/utils/passportReader to properly expose the interface expected by tests
	jest.mock('./src/utils/passportReader', () => {
	const mockScanPassport = jest.fn();
	// Mock the parameter count for scanPassport (iOS native method takes 9 parameters)
	Object.defineProperty(mockScanPassport, 'length', { value: 9 });
	const mockPassportReader = {
	configure: jest.fn(),
	scanPassport: mockScanPassport,
	trackEvent: jest.fn(),
	flush: jest.fn(),
	reset: jest.fn(),
	};
	return {
	PassportReader: mockPassportReader,
	reset: jest.fn(),
	scan: jest.fn(),
	default: mockPassportReader,
	};
	});
	// Mock @/utils/passportReader to properly expose the interface expected by tests
	jest.mock('@/utils/passportReader', () => {
	const mockScanPassport = jest.fn();
	// Mock the parameter count for scanPassport (iOS native method takes 9 parameters)
	Object.defineProperty(mockScanPassport, 'length', { value: 9 });
	const mockPassportReader = {
	configure: jest.fn(),
	scanPassport: mockScanPassport,
	trackEvent: jest.fn(),
	flush: jest.fn(),
	reset: jest.fn(),
	};
	return {
	__esModule: true,
	PassportReader: mockPassportReader,
	reset: jest.fn(),
	scan: jest.fn(),
	default: mockPassportReader,
	};
	});

🤖 Prompt for AI Agents

In app/jest.setup.js around lines 243 to 264, the mock uses a relative path and
doesn't expose ESM default interop; change the jest.mock target to the aliased
module '@/utils/passportReader' and return an object that includes __esModule:
true plus the existing default and named exports (PassportReader, reset, scan)
so consumers importing via the alias or using default import see the same
interface; keep the mock functions and the adjusted length on scanPassport
unchanged.

[coderabbitai]

⚠️ Potential issue

Guard and await reset to avoid TypeError and race.
reset may be null (when the native module fails to load) or async. Calling it unguarded can throw; not awaiting can leave stale state before scanDocument.

Apply:

-  reset();
+  if (typeof reset === 'function') {
+    await Promise.resolve(reset());
+  }

🤖 Prompt for AI Agents

In app/src/utils/nfcScanner.ts around lines 59 to 66, calling reset() unguarded
can throw if reset is null and must be awaited if it returns a Promise to avoid
a race; change the code to first check that reset is a function (e.g. typeof
reset === 'function'), await reset() inside a try/catch to handle any errors
(log or surface as rejection), then proceed to the existing scanDocument guard
and rejection when the native module is missing; also ensure the containing
function is declared async so you can use await.

[transphorm]

fyi @seshanthS added a flush method to the analytics package