-
Notifications
You must be signed in to change notification settings - Fork 180
chore: Manually bump and release v2.6.4 #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
0353bb0
0c2441e
95bdc0d
a1688a2
0174b2f
9dd52b4
feaabf8
72d5eea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -314,11 +314,9 @@ const ManageDocumentsScreen: React.FC = () => { | |
| <PrimaryButton onPress={handleScanDocument}> | ||
| Scan New ID Document | ||
| </PrimaryButton> | ||
| {__DEV__ && ( | ||
| <SecondaryButton onPress={handleGenerateMock}> | ||
| Generate Mock Document | ||
| </SecondaryButton> | ||
| )} | ||
| <SecondaryButton onPress={handleGenerateMock}> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fyi @remicolin @aaronmgdr this fix only made it into the android version of |
||
| Generate Mock Document | ||
| </SecondaryButton> | ||
|
Comment on lines
+317
to
+319
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainDev-only CTA is visible in production; tap is a no-op. Disable or re-gate. The SecondaryButton now renders unconditionally while Apply this minimal fix so the control is visually disabled outside dev: - <SecondaryButton onPress={handleGenerateMock}>
+ <SecondaryButton onPress={handleGenerateMock} disabled={!__DEV__}>
Generate Mock Document
</SecondaryButton>And update the handler to inform users in non-dev builds (outside the changed range): const handleGenerateMock = () => {
if (!__DEV__) {
Alert.alert('Not available', 'Mock document generation is only available in development builds.');
return;
}
impactLight();
trackEvent(DocumentEvents.ADD_NEW_MOCK_SELECTED);
navigation.navigate('CreateMock');
};Alternatively, render the button only in dev: {__DEV__ && (
<SecondaryButton onPress={handleGenerateMock}>Generate Mock Document</SecondaryButton>
)}🏁 Script executed: #!/bin/bash
# Display relevant lines around the button and handler in ManageDocumentsScreen.tsx
sed -n '250,350p' app/src/screens/settings/ManageDocumentsScreen.tsx
# Locate the definition of handleGenerateMock
grep -R "const handleGenerateMock" -n app/src/screens/settings/ManageDocumentsScreen.tsx
# Check for any usage of __DEV__ in this file
grep -R "__DEV__" -n app/src/screens/settings/ManageDocumentsScreen.tsxLength of output: 2333 Disable or re-gate the “Generate Mock Document” button in non-dev builds The “Generate Mock Document” SecondaryButton is rendered unconditionally, but its handler early-returns when • File: Please apply one of the following fixes:
Both options prevent a no-op tap and improve UX. 🤖 Prompt for AI Agents |
||
| </ButtonsContainer> | ||
| </YStack> | ||
| </YStack> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,10 +1,10 @@ | ||||||
| { | ||||||
| "ios": { | ||||||
| "build": 167, | ||||||
| "lastDeployed": "2025-08-08T22:35:10Z" | ||||||
| "build": 169, | ||||||
| "lastDeployed": "2025-08-026T16:35:10Z" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix invalid iOS lastDeployed timestamp (blocking automations). There’s an extra 0 in the date: "2025-08-026T..." → "2025-08-26T...". This can break parsers. Apply: - "lastDeployed": "2025-08-026T16:35:10Z"
+ "lastDeployed": "2025-08-26T16:35:10Z"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| }, | ||||||
| "android": { | ||||||
| "build": 87, | ||||||
| "lastDeployed": "2025-08-20T21:30:05Z" | ||||||
| "build": 89, | ||||||
| "lastDeployed": "2025-08-26T16:30:05Z" | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unhide Generate Mock Document link. will push out a new build