feat: improve mixpanel flush strategy #960
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ | |
| "mobile-local-deploy": "FORCE_UPLOAD_LOCAL_DEV=true node scripts/mobile-deploy-confirm.cjs both", | ||
| "mobile-local-deploy:android": "FORCE_UPLOAD_LOCAL_DEV=true node scripts/mobile-deploy-confirm.cjs android", | ||
| "mobile-local-deploy:ios": "FORCE_UPLOAD_LOCAL_DEV=true node scripts/mobile-deploy-confirm.cjs ios", | ||
| "nice": "yarn build:deps && yarn imports:fix && yarn lint:fix && yarn fmt:fix", | ||
| "reinstall": "yarn clean && yarn install && yarn install-app", | ||
| "release": "./scripts/release.sh", | ||
| "release:major": "./scripts/release.sh major", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ import { | |
| createClient, | ||
| EventPlugin, | ||
| PluginType, | ||
| StartupFlushPolicy, | ||
| } from '@segment/analytics-react-native'; | ||
|
|
||
| import '@ethersproject/shims'; | ||
|
|
@@ -48,14 +49,16 @@ export const createSegmentClient = () => { | |
| return segmentClient; | ||
| } | ||
|
|
||
| const flushPolicies = [new BackgroundFlushPolicy(), new StartupFlushPolicy()]; | ||
|
|
||
| const client = createClient({ | ||
| writeKey: SEGMENT_KEY, | ||
| trackAppLifecycleEvents: true, | ||
| trackDeepLinks: true, | ||
| debug: __DEV__, | ||
| collectDeviceId: false, | ||
| flushAt: 20, // Flush every 20 events | ||
| flushInterval: 20000, // Flush every 20 seconds | ||
| defaultSettings: { | ||
| integrations: { | ||
| 'Segment.io': { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,9 +7,7 @@ import React, { Component } from 'react'; | |
| import { Text, View } from 'react-native'; | ||
|
|
||
| import { captureException } from '@/Sentry'; | ||
| import { flushAllAnalytics, trackNfcEvent } from '@/utils/analytics'; | ||
|
|
||
| interface Props { | ||
| children: React.ReactNode; | ||
|
|
@@ -30,8 +28,12 @@ class ErrorBoundary extends Component<Props, State> { | |
| } | ||
|
|
||
| componentDidCatch(error: Error, info: ErrorInfo) { | ||
| trackNfcEvent('error_boundary', { | ||
| message: error.message, | ||
| stack: info.componentStack, | ||
| }); | ||
| // Flush all analytics before the app crashes | ||
| flushAllAnalytics(); | ||
| captureException(error, { | ||
| componentStack: info.componentStack, | ||
| errorBoundary: true, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // SPDX-FileCopyrightText: 2025 Social Connect Labs, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| // NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE. | ||
|
|
||
| // Web mock for react-native-passport-reader | ||
| export const reset = async () => { | ||
| // No-op for web | ||
| return Promise.resolve(); | ||
| }; | ||
|
|
||
| export const scan = async () => { | ||
| throw new Error('NFC scanning is not supported on web'); | ||
| }; | ||
transphorm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Mock parity with types: add
scanalias to match d.ts and potential callsitesThe default export for
react-native-passport-readeronly exposesscanPassport, while the d.ts (and likely some callsites) referencescan. This will cause test failures or undefined calls in environments that import the default module instead ofNativeModules.Apply this diff to add a
scanalias:jest.mock('react-native-passport-reader', () => ({ default: { configure: jest.fn(), - scanPassport: jest.fn(), + scanPassport: jest.fn(), + // Alias to align with TS types/callsites + scan: jest.fn(), readPassport: jest.fn(), cancelPassportRead: jest.fn(), trackEvent: jest.fn(), flush: jest.fn(), reset: jest.fn(), }, }));Run to spot any lingering
scanPassport(vsscan(mismatches:🏁 Script executed:
Length of output: 228
🏁 Script executed:
Length of output: 1200
Add
scanalias to the PassportReader mock to cover Android callsitesYour Android scanner helper calls
PassportReader.scan(…)(app/src/utils/nfcScanner.ts line 128), but your Jest setup only mocksscanPassport. Without ascanmock, tests hittingscanAndroidwill fail withundefined is not a function.Apply this diff in app/jest.setup.js (around lines 203–213):
jest.mock('react-native-passport-reader', () => ({ default: { configure: jest.fn(), scanPassport: jest.fn(), + // Alias to align with TS types/callsites (e.g. scanAndroid) + scan: jest.fn(), readPassport: jest.fn(), cancelPassportRead: jest.fn(), trackEvent: jest.fn(), flush: jest.fn(), reset: jest.fn(), }, }));— without this, any
PassportReader.scan(...)calls will be unmocked and break your Android tests.📝 Committable suggestion
🤖 Prompt for AI Agents