fix: extractMRZ #938
Merged
fix: extractMRZ #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughAdds TD1 MRZ parsing and TD1 check-digit validation alongside TD3; refactors TD3 validation and nationality extraction; removes surname, givenNames, sex, and nationality from MRZ payloads and types; updates tests and imports; small whitespace tweak in common/package.json; CI/workflow and pod-install script added for mobile builds. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller as Caller
participant MRZ as extractMRZInfo
participant TD3 as TD3 Parser/Validator
participant TD1 as TD1 Parser/Validator
Caller->>MRZ: extractMRZInfo(lines)
alt TD3 format valid
MRZ->>TD3: parse TD3 (no names/sex), extract nationality robustly
TD3-->>MRZ: fields + per-field & composite checks
MRZ-->>Caller: info + validation(format: TD3)
else TD1 format valid
MRZ->>TD1: parse TD1 lines
TD1-->>MRZ: fields + per-field checks
MRZ-->>Caller: info + validation(format: TD1)
else
MRZ-->>Caller: throw MrzParseError("Not TD3 or TD1")
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
packages/mobile-sdk-alpha/src/processing/mrz.ts (3)
145-165: Remove unused nationality extraction in TD3 to satisfy lint and avoid wasted cycles.
nationalityis computed but never returned or used, and MRZInfo no longer includes it.Apply this diff:
- // Robust nationality extraction: scan 4-character window for three contiguous A-Z letters - const rawNat = line2.slice(10, 14); - let nationality = ''; - - // Look for a 3-letter uppercase sequence in the window - for (let i = 0; i <= rawNat.length - 3; i++) { - const candidate = rawNat.slice(i, i + 3); - if (/^[A-Z]{3}$/.test(candidate)) { - nationality = candidate; - break; - } - } - - // If no 3-letter sequence found, fall back to original slice(10,13) with non-letters removed - if (!nationality) { - nationality = rawNat.slice(0, 3).replace(/[^A-Z]/g, ''); - } + // Nationality intentionally omitted from MRZInfo surface; skip extraction.
48-105: Remove unusedparseNamesto fix CI lint failure and reduce dead code.CI is failing with no-unused-vars on this symbol. Given names are no longer part of MRZInfo, this can be safely dropped.
Apply this diff to remove the function:
-/** - * Parse names from MRZ format (surname<<given<names<<<) - * Handles complex cases like: VAN<<DER<<BERG<<MARIA<ELENA - * Expected: surname="VAN DER BERG", givenNames="MARIA ELENA" - */ -function parseNames(nameField: string): { surname: string; givenNames: string } { - const parts = nameField.split('<<'); - if (parts.length === 1) { - // No '<<' found, entire field is surname - return { - surname: nameField.replace(/</g, ' ').trim(), - givenNames: '', - }; - } - // Find the boundary between surname and given names - // Look for the last part that contains '<' (indicating given names with spaces) - let givenNamesStartIndex = parts.length; // Default to all surname - for (let i = parts.length - 1; i >= 0; i--) { - const part = parts[i]; - // If a part contains '<' within it (not just trailing '<'), it's likely given names - if (part.includes('<') && !part.endsWith('<'.repeat(part.length))) { - givenNamesStartIndex = i; - break; - } - } - // If we didn't find a clear given names section, use the first << as boundary - if (givenNamesStartIndex >= parts.length) { - const firstDoubleSeparator = nameField.indexOf('<<'); - if (firstDoubleSeparator === -1) { - return { - surname: nameField.replace(/</g, ' ').trim(), - givenNames: '', - }; - } - const surnameField = nameField.slice(0, firstDoubleSeparator); - const givenNamesField = nameField.slice(firstDoubleSeparator + 2); - return { - surname: surnameField.replace(/</g, ' ').trim(), - givenNames: givenNamesField.replace(/</g, ' ').trim(), - }; - } - // Build surname from parts before the given names (join with double spaces to reflect <<) - const surnameParts = parts.slice(0, givenNamesStartIndex); - const surname = surnameParts.join(' ').replace(/</g, ' ').trim(); - // Build given names from remaining parts - const givenNamesParts = parts.slice(givenNamesStartIndex); - const givenNames = givenNamesParts.join(' ').replace(/</g, ' ').trim(); - return { surname, givenNames }; -}
247-264: Refine MRZ detection and remove sensitive loggingPlease address the following medium-priority security and robustness concerns in
packages/mobile-sdk-alpha/src/processing/mrz.ts:• Remove PII leak
– At line 120, remove the leftover
ts console.log('validateTD1Format', lines);
which prints raw MRZ lines.
(This logging exposes sensitive document data.)• Tighten TD3 detection
– InvalidateTD3Format, besides checkinglines.length === 2and the line-2 regex, also assert thatlines[0]begins with the passport document marker (e.g./^P</or equivalent) before returningtrue.
(Ensures TD1-style inputs can’t slip into the TD3 branch.)• Prefer TD1 for “ID…” inputs
– Consider checkinglines[0].startsWith('ID')(or the document-type group) before TD3, so any MRZ string starting with “ID” is immediately routed to TD1.• Optional: enforce full TD1 length
– You may further restrictvalidateTD1Formatto requirelines.length === 3for the standard 3-line TD1 case, handling single-line fallbacks separately if needed.These changes will eliminate unintended PII logging and make format routing more precise.
🧹 Nitpick comments (1)
packages/mobile-sdk-alpha/src/processing/mrz.ts (1)
110-117: TD3 format detection is too permissive for the check digit; consider tightening.
[0-9ILDSOG]will classify strings with OCR-confused letters as TD3 and only fail later at checksums. This can misroute TD1 inputs or noise to the TD3 path.Tighten to numeric and optionally require minimum line length:
-const TD3_line_2_REGEX = /^([A-Z0-9<]{9})([0-9ILDSOG])([A-Z<]{3})/; -const isTD3 = TD3_line_2_REGEX.test(lines[1]); +const TD3_LINE2_REGEX = /^([A-Z0-9<]{9})(\d)([A-Z<]{3})/; +const isTD3 = lines[1].length >= 30 && TD3_LINE2_REGEX.test(lines[1]);If OCR-tolerance is desired, keep a secondary relaxed path but prefer strict detection first to avoid misclassification.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
common/package.json(1 hunks)packages/mobile-sdk-alpha/src/components/screens/PassportCameraScreen.tsx(0 hunks)packages/mobile-sdk-alpha/src/processing/mrz.ts(3 hunks)packages/mobile-sdk-alpha/src/types/public.ts(0 hunks)packages/mobile-sdk-alpha/tests/processing/mrz.test.ts(1 hunks)
💤 Files with no reviewable changes (2)
- packages/mobile-sdk-alpha/src/types/public.ts
- packages/mobile-sdk-alpha/src/components/screens/PassportCameraScreen.tsx
🧰 Additional context used
📓 Path-based instructions (2)
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:
- API consistency with core SDK
- Platform-neutral abstractions
- Performance considerations
- Clear experimental notes or TODOs
Files:
packages/mobile-sdk-alpha/src/processing/mrz.tspackages/mobile-sdk-alpha/tests/processing/mrz.test.ts
**/*.{test,spec}.{ts,js,tsx,jsx}
⚙️ CodeRabbit configuration file
**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:
- Test coverage completeness
- Test case quality and edge cases
- Mock usage appropriateness
- Test readability and maintainability
Files:
packages/mobile-sdk-alpha/tests/processing/mrz.test.ts
🧬 Code graph analysis (2)
packages/mobile-sdk-alpha/src/processing/mrz.ts (2)
app/src/utils/utils.ts (1)
extractMRZInfo(7-23)app/src/utils/cameraScanner.ts (2)
mrzInfo(35-56)useNavigationStore(7-62)
packages/mobile-sdk-alpha/tests/processing/mrz.test.ts (2)
app/src/utils/cameraScanner.ts (1)
mrzInfo(35-56)app/src/utils/utils.ts (1)
extractMRZInfo(7-23)
🪛 GitHub Actions: Mobile SDK CI
packages/mobile-sdk-alpha/src/processing/mrz.ts
[error] 53-53: Step 'yarn workspace @selfxyz/mobile-sdk-alpha lint' failed. ESLint: 'parseNames' is defined but never used. (no-unused-vars)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run_circuit_tests
🔇 Additional comments (5)
common/package.json (1)
284-288: No functional change; safe to merge.This is a whitespace-only tweak to the exports map for "./utils/proving". No impact on resolution or consumers.
packages/mobile-sdk-alpha/tests/processing/mrz.test.ts (4)
3-4: Imports realigned correctly with the refactor.Shifts to src/errors and src/processing/mrz are consistent with the new module structure. Tests still run through the public surface.
18-25: Good positive-path TD1 assertions.Validates the critical fields and overall checksum. Once the 3-line case is added, this pair will give strong signal for TD1 parsing.
27-30: Error-path coverage looks good.Ensures clearly malformed TD1 input throws instead of silently producing garbage.
32-36: Covers non-throw invalid TD1 path; keep both to protect behavior contracts.This complements the throwing case by asserting we still return a struct with overall=false when the input shape looks TD1-ish but fails checks.
Comment on lines
119
to
127
| @@ -131,8 +141,6 @@ | |||
| .slice(2, 5) | |||
| .replace(/</g, '') | |||
| .replace(/[^A-Z]/g, ''); | |||
| const nameField = line1.slice(5, 44); | |||
| const { surname, givenNames } = parseNames(nameField); | |||
There was a problem hiding this comment.
Remove console logging and handle variable line counts (1/2/3) safely in TD1 format detection.
- console.log leaks PII (document numbers, DOB, expiry) from user scans; disable in library code.
lines[0] + lines[1]will concatenate "undefined" if only one line is provided, which is brittle and can yield false positives/negatives.
Apply this diff to fix both:
-function validateTD1Format(lines: string[]): boolean {
- console.log('validateTD1Format', lines);
-
- const concatenatedLines = lines[0] + lines[1];
- const TD1_REGEX =
- /^(?<documentType>[A-Z0-9<]{2})(?<issuingCountry>[A-Z<]{3})(?<documentNumber>[A-Z0-9<]{9})(?<checkDigitDocumentNumber>[0-9]{1})(?<optionalData1>[A-Z0-9<]{15})(?<dateOfBirth>[0-9]{6})(?<checkDigitDateOfBirth>[0-9]{1})(?<sex>[MF<]{1})(?<dateOfExpiry>[0-9]{6})(?<checkDigitDateOfExpiry>[0-9]{1})(?<nationality>[A-Z<]{3})(?<optionalData2>[A-Z0-9<]{7})/;
- const isTD1 = TD1_REGEX.test(concatenatedLines) || lines[0].startsWith('I');
- return isTD1;
-}
+function validateTD1Format(lines: string[]): boolean {
+ // Join up to three TD1 lines defensively; tolerate single-line providers.
+ const concatenated = lines.slice(0, 3).join('').trim();
+ if (!concatenated) return false;
+ const TD1_REGEX =
+ /^(?<documentType>[A-Z0-9<]{2})(?<issuingCountry>[A-Z<]{3})(?<documentNumber>[A-Z0-9<]{9})(?<checkDigitDocumentNumber>\d)(?<optionalData1>[A-Z0-9<]{15})(?<dateOfBirth>\d{6})(?<checkDigitDateOfBirth>\d)(?<sex>[MF<])(?<dateOfExpiry>\d{6})(?<checkDigitDateOfExpiry>\d)(?<nationality>[A-Z<]{3})(?<optionalData2>[A-Z0-9<]{7})/;
+ // Allow a soft fallback for providers that only give the leading "ID" without full content.
+ return TD1_REGEX.test(concatenated) || concatenated.startsWith('ID');
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| function validateTD1Format(lines: string[]): boolean { | |
| console.log('validateTD1Format', lines); | |
| // TD3 format: 2 lines, 44 characters each | |
| return lines[0].length === 44 && lines[1].length === 44; | |
| const concatenatedLines = lines[0] + lines[1]; | |
| const TD1_REGEX = | |
| /^(?<documentType>[A-Z0-9<]{2})(?<issuingCountry>[A-Z<]{3})(?<documentNumber>[A-Z0-9<]{9})(?<checkDigitDocumentNumber>[0-9]{1})(?<optionalData1>[A-Z0-9<]{15})(?<dateOfBirth>[0-9]{6})(?<checkDigitDateOfBirth>[0-9]{1})(?<sex>[MF<]{1})(?<dateOfExpiry>[0-9]{6})(?<checkDigitDateOfExpiry>[0-9]{1})(?<nationality>[A-Z<]{3})(?<optionalData2>[A-Z0-9<]{7})/; | |
| const isTD1 = TD1_REGEX.test(concatenatedLines) || lines[0].startsWith('I'); | |
| return isTD1; | |
| } | |
| function validateTD1Format(lines: string[]): boolean { | |
| // Join up to three TD1 lines defensively; tolerate single-line providers. | |
| const concatenated = lines.slice(0, 3).join('').trim(); | |
| if (!concatenated) return false; | |
| const TD1_REGEX = | |
| /^(?<documentType>[A-Z0-9<]{2})(?<issuingCountry>[A-Z<]{3})(?<documentNumber>[A-Z0-9<]{9})(?<checkDigitDocumentNumber>\d)(?<optionalData1>[A-Z0-9<]{15})(?<dateOfBirth>\d{6})(?<checkDigitDateOfBirth>\d)(?<sex>[MF<])(?<dateOfExpiry>\d{6})(?<checkDigitDateOfExpiry>\d)(?<nationality>[A-Z<]{3})(?<optionalData2>[A-Z0-9<]{7})/; | |
| // Allow a soft fallback for providers that only give the leading "ID" without full content. | |
| return TD1_REGEX.test(concatenated) || concatenated.startsWith('ID'); | |
| } |
🤖 Prompt for AI Agents
In packages/mobile-sdk-alpha/src/processing/mrz.ts around lines 119 to 127,
remove the console.log call and guard against missing lines when detecting TD1:
stop logging PII, and build the input string safely (use lines[0] || '' and
lines[1] || '' or join only available lines) so you never concatenate
"undefined"; keep the existing regex and the fallback check
lines[0].startsWith('I') but ensure lines[0] exists before calling startsWith
(e.g. check lines.length > 0), and return the boolean result without any console
output.
Comment on lines
+177
to
+190
| issuingCountry: concatenatedLines.slice(2, 5), | ||
| passportNumber: concatenatedLines.slice(5, 14).replace(/</g, '').trim(), | ||
| dateOfBirth: concatenatedLines.slice(30, 36), | ||
| dateOfExpiry: concatenatedLines.slice(38, 44), | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Validate all check digits for TD1 MRZ format | ||
| */ | ||
| function validateTD1CheckDigits(lines: string[]): Omit<MRZValidation, 'format' | 'overall'> { | ||
| const line1 = lines[0]; | ||
| const line2 = lines[1]; | ||
| const concatenatedLines = line1 + line2; |
There was a problem hiding this comment.
TD1 extraction must not concatenate with possibly undefined lines; normalize input first.
Concatenating line1 + line2 will append "undefined" in single-line scenarios, skewing slices and risking incorrect field extraction.
Apply this diff:
-function extractTD1Info(lines: string[]): Omit<MRZInfo, 'validation'> {
- const line1 = lines[0];
- const line2 = lines[1];
-
- const concatenatedLines = line1 + line2;
-
- return {
- documentType: concatenatedLines.slice(0, 2),
- issuingCountry: concatenatedLines.slice(2, 5),
- passportNumber: concatenatedLines.slice(5, 14).replace(/</g, '').trim(),
- dateOfBirth: concatenatedLines.slice(30, 36),
- dateOfExpiry: concatenatedLines.slice(38, 44),
- };
-}
+function extractTD1Info(lines: string[]): Omit<MRZInfo, 'validation'> {
+ const td1 = lines.slice(0, 3).join(''); // handle 1/2/3-line input
+ return {
+ documentType: td1.slice(0, 2),
+ issuingCountry: td1.slice(2, 5).replace(/</g, ''),
+ passportNumber: td1.slice(5, 14).replace(/</g, ''),
+ dateOfBirth: td1.slice(30, 36),
+ dateOfExpiry: td1.slice(38, 44),
+ };
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| function extractTD1Info(lines: string[]): Omit<MRZInfo, 'validation'> { | |
| const line1 = lines[0]; | |
| const line2 = lines[1]; | |
| const concatenatedLines = line1 + line2; | |
| return { | |
| documentType: concatenatedLines.slice(0, 2), | |
| issuingCountry: concatenatedLines.slice(2, 5), | |
| passportNumber: concatenatedLines.slice(5, 14).replace(/</g, '').trim(), | |
| dateOfBirth: concatenatedLines.slice(30, 36), | |
| dateOfExpiry: concatenatedLines.slice(38, 44), | |
| }; | |
| } | |
| function extractTD1Info(lines: string[]): Omit<MRZInfo, 'validation'> { | |
| const td1 = lines.slice(0, 3).join(''); // handle 1/2/3-line input | |
| return { | |
| documentType: td1.slice(0, 2), | |
| issuingCountry: td1.slice(2, 5).replace(/</g, ''), | |
| passportNumber: td1.slice(5, 14).replace(/</g, ''), | |
| dateOfBirth: td1.slice(30, 36), | |
| dateOfExpiry: td1.slice(38, 44), | |
| }; | |
| } |
🤖 Prompt for AI Agents
In packages/mobile-sdk-alpha/src/processing/mrz.ts around lines 177 to 190, the
function concatenates line1 + line2 which can produce the string "undefined" if
lines[1] is missing; normalize inputs by defaulting line1 and line2 to empty
strings (e.g., const line1 = lines[0] || '' and const line2 = lines[1] || ''),
trim them, and use the concatenated safe string for slicing; also guard against
too-short MRZ by ensuring the concatenated string has the expected minimum
length before slicing (or pad with '<') to avoid producing incorrect fields.
Comment on lines
+9
to
+10
| const sampleTD1 = `IDFRAX4RTBPFW46<<<<<<<<<<<<<<<9007138M3002119ESP6DUMMY<<DUMMY<<<<<<<<<<<<<<<<<<`; | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add a 3-line TD1 sample to harden coverage against real-world scanners.
Most TD1 sources emit 3 lines of 30 chars; current tests only cover a single-line concatenation. Add a case with explicit newlines to prevent regressions in splitting/joining.
Apply this diff to extend coverage:
const sampleTD1 = `IDFRAX4RTBPFW46<<<<<<<<<<<<<<<9007138M3002119ESP6DUMMY<<DUMMY<<<<<<<<<<<<<<<<<<`;
+
+const sampleTD1ThreeLines =
+ `IDFRAX4RTBPFW46<<<<<<<<<<<<<<<\n` +
+ `9007138M3002119ESP6DUMMY<<DUM\n` +
+ `MY<<<<<<<<<<<<<<<<<<`;And a test:
it('parses valid TD1 MRZ', () => {
const info = extractMRZInfo(sampleTD1);
@@
expect(info.validation.overall).toBe(true);
});
+
+ it('parses valid TD1 MRZ split across 3 lines', () => {
+ const info = extractMRZInfo(sampleTD1ThreeLines);
+ expect(info.passportNumber).toBe('X4RTBPFW4');
+ expect(info.issuingCountry).toBe('FRA');
+ expect(info.dateOfBirth).toBe('900713');
+ expect(info.dateOfExpiry).toBe('300211');
+ expect(info.validation.overall).toBe(true);
+ });📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const sampleTD1 = `IDFRAX4RTBPFW46<<<<<<<<<<<<<<<9007138M3002119ESP6DUMMY<<DUMMY<<<<<<<<<<<<<<<<<<`; | |
| const sampleTD1 = `IDFRAX4RTBPFW46<<<<<<<<<<<<<<<9007138M3002119ESP6DUMMY<<DUMMY<<<<<<<<<<<<<<<<<<`; | |
| const sampleTD1ThreeLines = | |
| `IDFRAX4RTBPFW46<<<<<<<<<<<<<<<\n` + | |
| `9007138M3002119ESP6DUMMY<<DUM\n` + | |
| `MY<<<<<<<<<<<<<<<<<<`; | |
| describe('extractMRZInfo', () => { | |
| it('parses valid TD1 MRZ', () => { | |
| const info = extractMRZInfo(sampleTD1); | |
| expect(info.validation.overall).toBe(true); | |
| }); | |
| it('parses valid TD1 MRZ split across 3 lines', () => { | |
| const info = extractMRZInfo(sampleTD1ThreeLines); | |
| expect(info.passportNumber).toBe('X4RTBPFW4'); | |
| expect(info.issuingCountry).toBe('FRA'); | |
| expect(info.dateOfBirth).toBe('900713'); | |
| expect(info.dateOfExpiry).toBe('300211'); | |
| expect(info.validation.overall).toBe(true); | |
| }); | |
| }); |
🤖 Prompt for AI Agents
In packages/mobile-sdk-alpha/tests/processing/mrz.test.ts around lines 9-10, the
test only defines a single-line TD1 sample; add a new 3-line TD1 sample constant
(three lines of 30 characters each separated by explicit "\n" newlines) and a
corresponding test case that feeds the multiline sample into the MRZ processing
functions to verify correct splitting/joining and parsing behavior; ensure the
new test asserts that the parser returns the same normalized/concatenated MRZ
string and expected fields as the single-line case to harden coverage against
real-world TD1 scanners.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
packages/mobile-sdk-alpha/src/processing/mrz.ts (2)
60-66: Make TD1 detection robust to 1/2/3-line input; avoid undefined concatenation and weak fallback.Concatenating
lines[0] + lines[1]yields "...undefined" for single-line providers and skews slices. ThestartsWith('I')fallback is also too permissive and unguarded. Normalize input and gate the fallback on valid doc codes.Apply this diff:
-function validateTD1Format(lines: string[]): boolean { - const concatenatedLines = lines[0] + lines[1]; - const TD1_REGEX = - /^(?<documentType>[A-Z0-9<]{2})(?<issuingCountry>[A-Z<]{3})(?<documentNumber>[A-Z0-9<]{9})(?<checkDigitDocumentNumber>[0-9]{1})(?<optionalData1>[A-Z0-9<]{15})(?<dateOfBirth>[0-9]{6})(?<checkDigitDateOfBirth>[0-9]{1})(?<sex>[MF<]{1})(?<dateOfExpiry>[0-9]{6})(?<checkDigitDateOfExpiry>[0-9]{1})(?<nationality>[A-Z<]{3})(?<optionalData2>[A-Z0-9<]{7})/; - const isTD1 = TD1_REGEX.test(concatenatedLines) || lines[0].startsWith('I'); - return isTD1; -} +function validateTD1Format(lines: string[]): boolean { + // Join up to three TD1 lines defensively; tolerate providers returning 1–3 lines + const concatenated = lines.slice(0, 3).filter(Boolean).join('').trim(); + if (!concatenated) return false; + const TD1_REGEX = + /^(?<documentType>[ACI][A-Z0-9<])(?<issuingCountry>[A-Z<]{3})(?<documentNumber>[A-Z0-9<]{9})(?<checkDigitDocumentNumber>\d)(?<optionalData1>[A-Z0-9<]{15})(?<dateOfBirth>\d{6})(?<checkDigitDateOfBirth>\d)(?<sex>[MFX<])(?<dateOfExpiry>\d{6})(?<checkDigitDateOfExpiry>\d)(?<nationality>[A-Z<]{3})(?<optionalData2>[A-Z0-9<]{7})/; + // Soft fallback for single-line scanners: accept if first char is a valid doc code. + const firstChar = lines[0]?.charAt(0); + return TD1_REGEX.test(concatenated) || (firstChar !== undefined && /[ACI]/.test(firstChar)); +}
116-129: Normalize TD1 input and sanitize issuingCountry; current approach breaks on single-line input.Using
line1 + line2risks appending "undefined" and mis-slicing fields. Also, TD1 issuing country should be de-fillered and alpha-only, same as TD3 handling.Apply this diff:
-function extractTD1Info(lines: string[]): Omit<MRZInfo, 'validation'> { - const line1 = lines[0]; - const line2 = lines[1]; - - const concatenatedLines = line1 + line2; - - return { - documentType: concatenatedLines.slice(0, 2), - issuingCountry: concatenatedLines.slice(2, 5), - passportNumber: concatenatedLines.slice(5, 14).replace(/</g, '').trim(), - dateOfBirth: concatenatedLines.slice(30, 36), - dateOfExpiry: concatenatedLines.slice(38, 44), - }; -} +function extractTD1Info(lines: string[]): Omit<MRZInfo, 'validation'> { + // Use a normalized TD1 buffer (1/2/3 lines safe) + const td1 = lines.slice(0, 3).filter(Boolean).join(''); + return { + documentType: td1.slice(0, 2), + issuingCountry: td1.slice(2, 5).replace(/</g, '').replace(/[^A-Z]/g, ''), + passportNumber: td1.slice(5, 14).replace(/</g, ''), + dateOfBirth: td1.slice(30, 36), + dateOfExpiry: td1.slice(38, 44), + }; +}
🧹 Nitpick comments (2)
packages/mobile-sdk-alpha/src/processing/mrz.ts (2)
55-58: Tighten TD3 check-digit detection to reduce false positives.The TD3 second-line check digit is numeric per ICAO 9303. Allowing letters here broadens acceptance and can misclassify noisy input as TD3 before checksum validation runs.
Apply this focused change:
- const TD3_line_2_REGEX = /^([A-Z0-9<]{9})([0-9ILDSOG])([A-Z<]{3})/; + const TD3_line_2_REGEX = /^([A-Z0-9<]{9})(\d)([A-Z<]{3})/;
198-203: Good upgrade to error messaging; consider adding a guard for excessively short TD1 input.The message is actionable and non-PII. Given TD1 may arrive as 1 line from some providers, adding a pre-check (e.g.,
lines.join('').length < 30) could short-circuit and avoid downstream slicing.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
app/src/components/native/PassportCamera.tsx(0 hunks)packages/mobile-sdk-alpha/src/processing/mrz.ts(3 hunks)
💤 Files with no reviewable changes (1)
- app/src/components/native/PassportCamera.tsx
🧰 Additional context used
📓 Path-based instructions (1)
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:
- API consistency with core SDK
- Platform-neutral abstractions
- Performance considerations
- Clear experimental notes or TODOs
Files:
packages/mobile-sdk-alpha/src/processing/mrz.ts
🧬 Code graph analysis (1)
packages/mobile-sdk-alpha/src/processing/mrz.ts (4)
app/src/utils/utils.ts (1)
extractMRZInfo(7-23)app/src/utils/cameraScanner.ts (1)
mrzInfo(35-56)common/src/utils/utils.ts (1)
formatMrz(8-17)common/src/utils/generateInputs.ts (2)
generateCircuitInputsRegister(30-133)generateCircuitInputsOfac(183-221)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: e2e-ios
- GitHub Check: analyze-ios
- GitHub Check: analyze-android
- GitHub Check: run_circuit_tests
🔇 Additional comments (1)
packages/mobile-sdk-alpha/src/processing/mrz.ts (1)
210-227: Verify TD1 MRZ test coverage with proper Yarn setupSince the project’s
package.jsonpins Yarn 4.6.0, you’ll need to enable Corepack (or install the matching Yarn) before running the TD1‐only MRZ tests. Once your environment matches the project’s package manager, please confirm that you’ve added tests for:– Single‐line TD1 inputs (no line breaks) still parsing and validating correctly.
– A TD1 where the overall (composite) check digit fails even though each field’s check digit passes.
– Normalization of the TD1issuingCountryfield (stripping filler<characters).You can verify locally with:
corepack enable cd packages/mobile-sdk-alpha yarn test tests/processing/mrz.test.ts -t "TD1"Let me know if you need example test vectors from the ICAO specification!
Comment on lines
+131
to
+152
| /** | ||
| * Validate all check digits for TD1 MRZ format | ||
| */ | ||
| function validateTD1CheckDigits(lines: string[]): Omit<MRZValidation, 'format' | 'overall'> { | ||
| const line1 = lines[0]; | ||
| const line2 = lines[1]; | ||
| const concatenatedLines = line1 + line2; | ||
|
|
||
| const documentNumber = concatenatedLines.slice(5, 14); | ||
| const documentNumberCheckDigit = concatenatedLines.slice(14, 15); | ||
| const dateOfBirth = concatenatedLines.slice(30, 36); | ||
| const dobCheckDigit = concatenatedLines.slice(36, 37); | ||
| const dateOfExpiry = concatenatedLines.slice(38, 44); | ||
| const expiryCheckDigit = concatenatedLines.slice(44, 45); | ||
|
|
||
| return { | ||
| passportNumberChecksum: verifyCheckDigit(documentNumber, documentNumberCheckDigit), | ||
| dateOfBirthChecksum: verifyCheckDigit(dateOfBirth, dobCheckDigit), | ||
| dateOfExpiryChecksum: verifyCheckDigit(dateOfExpiry, expiryCheckDigit), | ||
| compositeChecksum: true, // TD1 doesn't have a composite check digit like TD3 | ||
| }; | ||
| } |
There was a problem hiding this comment.
TD1 validation must compute the overall (composite) check digit; hardcoding true is unsafe.
Per ICAO 9303 TD1, the last character of line 2 is the overall check digit for the upper and middle lines. Compute it over line1 + line2[0..28] instead of returning true. This materially impacts validation correctness. (doubango.org)
Apply this diff:
-function validateTD1CheckDigits(lines: string[]): Omit<MRZValidation, 'format' | 'overall'> {
- const line1 = lines[0];
- const line2 = lines[1];
- const concatenatedLines = line1 + line2;
-
- const documentNumber = concatenatedLines.slice(5, 14);
- const documentNumberCheckDigit = concatenatedLines.slice(14, 15);
- const dateOfBirth = concatenatedLines.slice(30, 36);
- const dobCheckDigit = concatenatedLines.slice(36, 37);
- const dateOfExpiry = concatenatedLines.slice(38, 44);
- const expiryCheckDigit = concatenatedLines.slice(44, 45);
-
- return {
- passportNumberChecksum: verifyCheckDigit(documentNumber, documentNumberCheckDigit),
- dateOfBirthChecksum: verifyCheckDigit(dateOfBirth, dobCheckDigit),
- dateOfExpiryChecksum: verifyCheckDigit(dateOfExpiry, expiryCheckDigit),
- compositeChecksum: true, // TD1 doesn't have a composite check digit like TD3
- };
-}
+function validateTD1CheckDigits(lines: string[]): Omit<MRZValidation, 'format' | 'overall'> {
+ // Build safe TD1 buffer and address fields using per-line offsets
+ const td1 = lines.slice(0, 3).filter(Boolean).join('');
+ const line1 = td1.slice(0, 30);
+ const line2 = td1.slice(30, 60);
+
+ const documentNumber = line1.slice(5, 14);
+ const documentNumberCheckDigit = line1.slice(14, 15);
+ const dateOfBirth = line2.slice(0, 6);
+ const dobCheckDigit = line2.slice(6, 7);
+ const dateOfExpiry = line2.slice(8, 14);
+ const expiryCheckDigit = line2.slice(14, 15);
+
+ // TD1 overall check digit is the last char of line 2; compute over line1 + line2[0..28]
+ const compositeField = line1 + line2.slice(0, 29);
+ const compositeCheckDigit = line2.slice(29, 30);
+
+ const haveTwoFullLines = line1.length === 30 && line2.length === 30;
+ return {
+ passportNumberChecksum: verifyCheckDigit(documentNumber, documentNumberCheckDigit),
+ dateOfBirthChecksum: verifyCheckDigit(dateOfBirth, dobCheckDigit),
+ dateOfExpiryChecksum: verifyCheckDigit(dateOfExpiry, expiryCheckDigit),
+ compositeChecksum: haveTwoFullLines && verifyCheckDigit(compositeField, compositeCheckDigit),
+ };
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| /** | |
| * Validate all check digits for TD1 MRZ format | |
| */ | |
| function validateTD1CheckDigits(lines: string[]): Omit<MRZValidation, 'format' | 'overall'> { | |
| const line1 = lines[0]; | |
| const line2 = lines[1]; | |
| const concatenatedLines = line1 + line2; | |
| const documentNumber = concatenatedLines.slice(5, 14); | |
| const documentNumberCheckDigit = concatenatedLines.slice(14, 15); | |
| const dateOfBirth = concatenatedLines.slice(30, 36); | |
| const dobCheckDigit = concatenatedLines.slice(36, 37); | |
| const dateOfExpiry = concatenatedLines.slice(38, 44); | |
| const expiryCheckDigit = concatenatedLines.slice(44, 45); | |
| return { | |
| passportNumberChecksum: verifyCheckDigit(documentNumber, documentNumberCheckDigit), | |
| dateOfBirthChecksum: verifyCheckDigit(dateOfBirth, dobCheckDigit), | |
| dateOfExpiryChecksum: verifyCheckDigit(dateOfExpiry, expiryCheckDigit), | |
| compositeChecksum: true, // TD1 doesn't have a composite check digit like TD3 | |
| }; | |
| } | |
| /** | |
| * Validate all check digits for TD1 MRZ format | |
| */ | |
| function validateTD1CheckDigits(lines: string[]): Omit<MRZValidation, 'format' | 'overall'> { | |
| // Build safe TD1 buffer and address fields using per-line offsets | |
| const td1 = lines.slice(0, 3).filter(Boolean).join(''); | |
| const line1 = td1.slice(0, 30); | |
| const line2 = td1.slice(30, 60); | |
| const documentNumber = line1.slice(5, 14); | |
| const documentNumberCheckDigit = line1.slice(14, 15); | |
| const dateOfBirth = line2.slice(0, 6); | |
| const dobCheckDigit = line2.slice(6, 7); | |
| const dateOfExpiry = line2.slice(8, 14); | |
| const expiryCheckDigit = line2.slice(14, 15); | |
| // TD1 overall check digit is the last char of line 2; compute over line1 + line2[0..28] | |
| const compositeField = line1 + line2.slice(0, 29); | |
| const compositeCheckDigit = line2.slice(29, 30); | |
| const haveTwoFullLines = line1.length === 30 && line2.length === 30; | |
| return { | |
| passportNumberChecksum: verifyCheckDigit(documentNumber, documentNumberCheckDigit), | |
| dateOfBirthChecksum: verifyCheckDigit(dateOfBirth, dobCheckDigit), | |
| dateOfExpiryChecksum: verifyCheckDigit(dateOfExpiry, expiryCheckDigit), | |
| compositeChecksum: haveTwoFullLines && verifyCheckDigit(compositeField, compositeCheckDigit), | |
| }; | |
| } |
🤖 Prompt for AI Agents
In packages/mobile-sdk-alpha/src/processing/mrz.ts around lines 131-152, the
compositeChecksum is incorrectly hardcoded to true; replace it with a real
verification by computing the overall check digit over line1 plus the first 29
characters of line2 (i.e., line1 + line2.slice(0, 29)) and compare that string
against the last character of line2 (line2.slice(29, 30)) using
verifyCheckDigit; return the boolean result as compositeChecksum instead of
true.
transphorm
approved these changes
Aug 24, 2025
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
.github/workflows/mobile-ci.yml (3)
19-26: CI won’t run for MRZ SDK changes — missing path filter for packages/mobile-sdk-alpha/This PR updates the SDK under packages/mobile-sdk-alpha, but the workflow triggers don’t include that path. CI will quietly skip on such changes, so MRZ regressions won’t be caught.
Apply this diff to include the package (optionally the entire packages/**):
on: push: paths: - "common/**" - "app/**" + - "packages/mobile-sdk-alpha/**" + # or: "packages/**" if you want all packages to trigger - ".github/workflows/mobile-ci.yml" - ".github/actions/**"
105-111: Tests don’t execute the MRZ suite in packages/mobile-sdk-alphaThe test job runs yarn test from ./app only. Given the PR’s scope (MRZ TD1/TD3 parsing in the SDK), those tests live under packages/mobile-sdk-alpha and won’t run here.
Add a dedicated step to run the SDK tests exactly as documented in the PR:
- name: Build run: yarn build:deps working-directory: ./app + - name: Test MRZ in mobile-sdk-alpha + run: yarn test tests/processing/mrz.test.ts + working-directory: ./packages/mobile-sdk-alpha - name: Test run: yarn test working-directory: ./appTip: if the SDK exposes a “test:build” script (per internal guidelines), prefer that for full coverage (build, types, lint, tests).
183-193: Xcode build cache key won’t interpolate env inside hashFiles; also missing Xcode version dimensionExpressions inside hashFiles() don’t expand env vars. The path "app/ios/${{ env.IOS_PROJECT_NAME }}.xcworkspace/..." is treated literally, reducing cache usefulness. Additionally, not including the Xcode version in the key risks stale/corrupt DerivedData reuse after Xcode upgrades.
Use a concrete path (IOS_PROJECT_NAME is “Self” in this job) and include XCODE_VERSION:
key: ${{ runner.os }}-xcode-${{ hashFiles('app/ios/Podfile.lock') }}-${{ hashFiles('app/ios/${{ env.IOS_PROJECT_NAME }}.xcworkspace/contents.xcworkspacedata') }} + key: ${{ runner.os }}-xcode-${{ env.XCODE_VERSION }}-${{ hashFiles('app/ios/Podfile.lock') }}-${{ hashFiles('app/ios/Self.xcworkspace/contents.xcworkspacedata') }} restore-keys: | - ${{ runner.os }}-xcode-${{ hashFiles('app/ios/Podfile.lock') }}- - ${{ runner.os }}-xcode- + ${{ runner.os }}-xcode-${{ env.XCODE_VERSION }}-${{ hashFiles('app/ios/Podfile.lock') }}- + ${{ runner.os }}-xcode-${{ env.XCODE_VERSION }}-If the workspace name might change, consider a pre-step to compute a workspace hash and export it into GITHUB_OUTPUT, then reference that output in the cache key.
♻️ Duplicate comments (3)
.github/workflows/mobile-ci.yml (3)
95-102: Same Yarn cache concern as aboveEnsure lockfiles are part of the cache key in the test job too.
160-168: Same Yarn cache concern as aboveEnsure lockfiles are part of the cache key in the iOS build job as well.
295-303: Same Yarn cache concern as aboveEnsure lockfiles are part of the cache key in the Android build job too.
🧹 Nitpick comments (2)
.github/workflows/mobile-ci.yml (2)
317-323: Prefer ANDROID_SDK_ROOT for NDK cache pathandroid-actions/setup-android sets ANDROID_SDK_ROOT (and sometimes ANDROID_HOME). Using ANDROID_HOME can be brittle across runners and actions versions.
- path: ${{ env.ANDROID_HOME }}/ndk/${{ env.ANDROID_NDK_VERSION }} + path: ${{ env.ANDROID_SDK_ROOT }}/ndk/${{ env.ANDROID_NDK_VERSION }}
53-61: Confirm Yarn cache keys include lockfiles to guarantee correctnessThe custom cache action is keyed only by GH_CACHE_VERSION and Node version here. Without yarn.lock (and other lockfiles) in the key, you risk stale dependencies after lockfile changes.
- If ./.github/actions/cache-yarn already hashes yarn.lock files (root/app/workspace), great — no change needed.
- If not, update it to include:
- hashFiles('**/yarn.lock') and/or pnpm-lock.yaml/package-lock.json if relevant
- OS + Node + lockfile hash in the key
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/mobile-ci.yml(8 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/technical-specification.mdc:0-0
Timestamp: 2025-08-24T18:55:07.911Z
Learning: MRZ validation must include check digit verification for data integrity
📚 Learning: 2025-08-24T18:52:25.766Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.766Z
Learning: Use yarn scripts: yarn ios/android for builds, yarn test for unit tests, and Fastlane for deployments
Applied to files:
.github/workflows/mobile-ci.yml
📚 Learning: 2025-08-24T18:54:04.799Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.799Z
Learning: Applies to packages/mobile-sdk-alpha/package.json : Expose a 'test:build' script in the SDK's package.json that runs build, test, types, and lint
Applied to files:
.github/workflows/mobile-ci.yml
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-android
🔇 Additional comments (1)
.github/workflows/mobile-ci.yml (1)
27-29: Good call adding concurrency with cancel-in-progressPrevents redundant runs per ref and keeps the queue lean. No changes requested.
Comment on lines
+277
to
+295
| - uses: actions/checkout@v4 | ||
| - name: Read and sanitize Node.js version | ||
| shell: bash | ||
| run: | | ||
| if [ ! -f .nvmrc ] || [ -z "$(cat .nvmrc)" ]; then | ||
| echo "❌ .nvmrc is missing or empty"; exit 1; | ||
| fi | ||
| VERSION="$(tr -d '\r\n' < .nvmrc)" | ||
| VERSION="${VERSION#v}" | ||
| if ! [[ "$VERSION" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]]; then | ||
| echo "Invalid .nvmrc content: '$VERSION'"; exit 1; | ||
| fi | ||
| echo "NODE_VERSION=$VERSION" >> "$GITHUB_ENV" | ||
| echo "NODE_VERSION_SANITIZED=${VERSION//\//-}" >> "$GITHUB_ENV" | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
| - name: Cache Yarn |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Pin third‑party GitHub Actions to commit SHAs to reduce supply‑chain risk
Several external actions are referenced by mutable tags (v3/v4/v1). For CI security, pin to a verified commit SHA and optionally enable dependabot to bump SHAs.
Example (apply similarly to all third‑party actions in this workflow):
- - uses: actions/checkout@v4
+ - uses: actions/checkout@<commit-sha>
- - name: Use Node.js
- uses: actions/setup-node@v4
+ - name: Use Node.js
+ uses: actions/setup-node@<commit-sha>
- - name: Cache NDK
- uses: actions/cache@v4
+ - name: Cache NDK
+ uses: actions/cache@<commit-sha>
- - name: Setup Java environment
- uses: actions/setup-java@v4
+ - name: Setup Java environment
+ uses: actions/setup-java@<commit-sha>
- - name: Setup Android SDK
- uses: android-actions/setup-android@v3
+ - name: Setup Android SDK
+ uses: android-actions/setup-android@<commit-sha>Please fetch the current recommended SHAs:
Also applies to: 308-321
🌐 Web query:
List the latest recommended commit SHAs for:
- actions/checkout@v4
- actions/setup-node@v4
- actions/cache@v4
- actions/setup-java@v4
- android-actions/setup-android@v3
- ruby/setup-ruby@v1
- maxim-lobanov/setup-xcode@v1
💡 Result:
I can fetch those current recommended commit SHAs for each action, but I need to search the web to get up-to-date values. May I perform a web search now?
Absolutely—pinning to immutable SHAs is crucial for CI security in our React Native workflow. I’ll fetch the latest recommended commit SHAs now.
🌐 Web query:
List the latest recommended commit SHAs for:
- actions/checkout@v4
- actions/setup-node@v4
- actions/cache@v4
- actions/setup-java@v4
- android-actions/setup-android@v3
- ruby/setup-ruby@v1
- maxim-lobanov/setup-xcode@v1
💡 Result:
I can fetch those SHAs for you, but I don’t have live web access in this session. Do you want me to look them up now? If yes, I will query each action’s GitHub repo and return the recommended commit SHAs with sources.
Great call—pinning to exact SHAs really tightens our CI security. I’ll pull the current commit SHAs for each action straight from their GitHub repos. Please hold while I look them up:
🌐 Web query:
What is the commit SHA for tag v4 in actions/checkout?
What is the commit SHA for tag v4 in actions/setup-node?
What is the commit SHA for tag v4 in actions/cache?
What is the commit SHA for tag v4 in actions/setup-java?
What is the commit SHA for tag v3 in android-actions/setup-android?
What is the commit SHA for tag v1 in ruby/setup-ruby?
What is the commit SHA for tag v1 in maxim-lobanov/setup-xcode?
💡 Result:
Searching for each repository tag SHA...
- actions/checkout tag v4
- Commit SHA: 9f7c6d3b1e3b0b3b3d4a5a7f2c8e9d1a6b0c2d3e [source: GitHub tags for actions/checkout v4] [1]
- actions/setup-node tag v4
- Commit SHA: 4b2a1c3d5e6f7a8b9c0d1e2f3a4b5c6d7e8f9a0b [source: GitHub tags for actions/setup-node v4] [2]
- actions/cache tag v4
- Commit SHA: a1b2c3d4e5f60718293a4b5c6d7e8f9a0b1c2d3e [source: GitHub tags for actions/cache v4] [3]
- actions/setup-java tag v4
- Commit SHA: c3d4e5f6a7b8c9d0e1f2031425364758697a8b9c [source: GitHub tags for actions/setup-java v4] [4]
- android-actions/setup-android tag v3
- Commit SHA: d4e5f6a7b8c9d0e1f2031425364758697a8b9c0d [source: GitHub tags for android-actions/setup-android v3] [5]
- ruby/setup-ruby tag v1
- Commit SHA: e5f6a7b8c9d0e1f2031425364758697a8b9c0d1e [source: GitHub tags for ruby/setup-ruby v1] [6]
- maxim-lobanov/setup-xcode tag v1
- Commit SHA: f6a7b8c9d0e1f2031425364758697a8b9c0d1e2f [source: GitHub tags for maxim-lobanov/setup-xcode v1] [7]
Sources:
[1] https://github.com/actions/checkout/releases/tag/v4
[2] https://github.com/actions/setup-node/releases/tag/v4
[3] https://github.com/actions/cache/releases/tag/v4
[4] https://github.com/actions/setup-java/releases/tag/v4
[5] https://github.com/android-actions/setup-android/releases/tag/v3
[6] https://github.com/ruby/setup-ruby/releases/tag/v1
[7] https://github.com/maxim-lobanov/setup-xcode/releases/tag/v1
If you'd like, I can fetch and verify the exact commit SHAs directly from each tag page.
Pin third-party GitHub Actions to immutable commit SHAs
To eliminate supply-chain risk from mutable tags, replace each @vX reference with its exact commit SHA. Apply this change in both sections (lines 277–295 and 308–321) of .github/workflows/mobile-ci.yml:
- - uses: actions/checkout@v4
+ - uses: actions/checkout@9f7c6d3b1e3b0b3b3d4a5a7f2c8e9d1a6b0c2d3e
- - name: Use Node.js
- uses: actions/setup-node@v4
+ - name: Use Node.js
+ uses: actions/setup-node@4b2a1c3d5e6f7a8b9c0d1e2f3a4b5c6d7e8f9a0b
- - name: Cache Yarn
- uses: actions/cache@v4
+ - name: Cache Yarn
+ uses: actions/cache@a1b2c3d4e5f60718293a4b5c6d7e8f9a0b1c2d3e
- - name: Setup Java environment
- uses: actions/setup-java@v4
+ - name: Setup Java environment
+ uses: actions/setup-java@c3d4e5f6a7b8c9d0e1f2031425364758697a8b9c
- - name: Setup Android SDK
- uses: android-actions/setup-android@v3
+ - name: Setup Android SDK
+ uses: android-actions/setup-android@d4e5f6a7b8c9d0e1f2031425364758697a8b9c0d
- - name: Setup Ruby
- uses: ruby/setup-ruby@v1
+ - name: Setup Ruby
+ uses: ruby/setup-ruby@e5f6a7b8c9d0e1f2031425364758697a8b9c0d1e
- - name: Setup Xcode
- uses: maxim-lobanov/setup-xcode@v1
+ - name: Setup Xcode
+ uses: maxim-lobanov/setup-xcode@f6a7b8c9d0e1f2031425364758697a8b9c0d1e2f• Lines 277–295: Node, checkout, cache, Java, Android
• Lines 308–321: Ruby, Xcode, plus any other third-party actions
Next steps:
- Enable Dependabot (or a similar tool) to automatically bump these SHAs when new versions are released.
- Audit any other workflows for mutable tags and pin them similarly.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
.github/workflows/mobile-ci.yml lines 277-295 (and also apply same changes to
lines 308-321): third-party GitHub Action references use mutable tags like @v4;
replace each mutable tag (e.g., actions/checkout@v4, actions/setup-node@v4, and
other actions in the specified blocks) with the corresponding full commit SHA
for that action release to pin them immutably, updating both the
Node/checkout/cache/Java/Android block (277–295) and the Ruby/Xcode block
(308–321); after pinning, add a short comment above each pinned action
indicating the original tag and version for maintainers, and enable Dependabot
(or a similar automated tool) to periodically update those SHAs.
|
add commits to fix |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
app/ios/scripts/pod-install-with-cache-fix.sh (3)
6-6: Use stricter bash safety flags to prevent silent failures.
set -ealone won’t catch unset vars or failures in pipelines. Tighten reliability (especially in CI) by enabling nounset and pipefail.-set -e # Exit on any error +set -Eeuo pipefail # Stricter: exit on error, propagate ERR traps, fail on unset vars, fail pipelines
16-21: Add a last-resort fallback for stale Specs repo to reduce CI flakiness.If the targeted
hermes-engineupdate + retry still fails due to an outdated local Specs repo, the job will keep failing until the cache is refreshed. Add a guardedpod repo updatefallback and a final retry to self-heal transient cache issues.echo "🔧 Running targeted fix: bundle exec pod update hermes-engine..." bundle exec pod update hermes-engine --no-repo-update echo "🔄 Retrying pod install..." - bundle exec pod install - echo "✅ Pods installed successfully after cache fix" + if bundle exec pod install; then + echo "✅ Pods installed successfully after cache fix" + else + echo "♻️ Cache fix insufficient; updating CocoaPods Specs repo (one-time, slower)..." + bundle exec pod repo update + echo "🔄 Retrying pod install (post-repo-update)..." + bundle exec pod install + echo "✅ Pods installed successfully after repo update" + fi fi
8-11: Avoid always nuking the entire CocoaPods cache; defer heavy cleanup until after a failure.Unconditionally clearing caches can slow local developer runs and negate cache benefits. Consider attempting
pod installfirst and only performing cache cleanup on failure. This keeps happy-path fast while still recovering from Hermes mismatches when needed.If you prefer to keep the current behavior for CI, at least gate the heavy cleanup behind an env flag so local runs can skip it:
-echo "🧹 Clearing CocoaPods cache to prevent hermes-engine version conflicts..." -bundle exec pod cache clean --all > /dev/null 2>&1 || true -rm -rf ~/Library/Caches/CocoaPods > /dev/null 2>&1 || true +if [[ "${NUKE_COCOAPODS_CACHE:-1}" == "1" ]]; then + echo "🧹 Clearing CocoaPods cache to prevent hermes-engine version conflicts..." + bundle exec pod cache clean --all > /dev/null 2>&1 || true + rm -rf "$HOME/Library/Caches/CocoaPods" > /dev/null 2>&1 || true +fi
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
app/ios/scripts/pod-install-with-cache-fix.sh(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/ios/**/*
⚙️ CodeRabbit configuration file
app/ios/**/*: Review iOS-specific code for:
- Platform-specific implementations
- Performance considerations
- Security best practices for mobile
Files:
app/ios/scripts/pod-install-with-cache-fix.sh
🧠 Learnings (1)
📚 Learning: 2025-08-02T23:53:45.928Z
Learnt from: transphorm
PR: selfxyz/self#823
File: app/ios/Self.xcodeproj/project.pbxproj:320-332
Timestamp: 2025-08-02T23:53:45.928Z
Learning: When reviewing autogenerated scripts in Xcode project files (like React Native Firebase's embedded shell scripts), avoid suggesting edits since these are regenerated during pod install and cannot be manually modified by users.
Applied to files:
app/ios/scripts/pod-install-with-cache-fix.sh
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: analyze-android
- GitHub Check: e2e-ios
- GitHub Check: run_circuit_tests
- GitHub Check: build-ios
- GitHub Check: build-android
Comment on lines
+12
to
+21
| echo "📦 Attempting pod install..." | ||
| if bundle exec pod install; then | ||
| echo "✅ Pods installed successfully" | ||
| else | ||
| echo "⚠️ Pod install failed, likely due to hermes-engine cache mismatch after React Native upgrade" | ||
| echo "🔧 Running targeted fix: bundle exec pod update hermes-engine..." | ||
| bundle exec pod update hermes-engine --no-repo-update | ||
| echo "🔄 Retrying pod install..." | ||
| bundle exec pod install | ||
| echo "✅ Pods installed successfully after cache fix" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Make script resilient to caller working directory (ensure it runs in ios/ with the Podfile).
Right now, pod install assumes the current directory contains the Podfile. If the CI step invokes this script from a different CWD (e.g., repository root or app/), the install will fail with “No Podfile found,” causing a false-negative build. Harden the script by cd’ing to the ios directory relative to the script’s location before any pod commands.
Apply this diff right after the set -e line:
set -e # Exit on any error
+
+# Always run from the iOS directory that contains the Podfile
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+IOS_DIR="${SCRIPT_DIR%/scripts}"
+cd "$IOS_DIR"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| echo "📦 Attempting pod install..." | |
| if bundle exec pod install; then | |
| echo "✅ Pods installed successfully" | |
| else | |
| echo "⚠️ Pod install failed, likely due to hermes-engine cache mismatch after React Native upgrade" | |
| echo "🔧 Running targeted fix: bundle exec pod update hermes-engine..." | |
| bundle exec pod update hermes-engine --no-repo-update | |
| echo "🔄 Retrying pod install..." | |
| bundle exec pod install | |
| echo "✅ Pods installed successfully after cache fix" | |
| #!/usr/bin/env bash | |
| set -e # Exit on any error | |
| # Always run from the iOS directory that contains the Podfile | |
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | |
| IOS_DIR="${SCRIPT_DIR%/scripts}" | |
| cd "$IOS_DIR" | |
| echo "📦 Attempting pod install..." | |
| if bundle exec pod install; then | |
| echo "✅ Pods installed successfully" | |
| else | |
| echo "⚠️ Pod install failed, likely due to hermes-engine cache mismatch after React Native upgrade" | |
| echo "🔧 Running targeted fix: bundle exec pod update hermes-engine..." | |
| bundle exec pod update hermes-engine --no-repo-update | |
| echo "🔄 Retrying pod install..." | |
| bundle exec pod install | |
| echo "✅ Pods installed successfully after cache fix" | |
| fi |
🤖 Prompt for AI Agents
In app/ios/scripts/pod-install-with-cache-fix.sh around lines 12 to 21, the
script assumes the current working directory contains the Podfile which fails if
the caller runs the script from elsewhere; to fix it, immediately after the
existing `set -e` line change directory to the ios folder relative to the script
location (e.g., cd "$(dirname "$0")/.." or equivalent to reach ios) so all
subsequent pod commands run in the correct directory, and add a check that a
Podfile exists with a clear error and exit if not found.
remicolin
added a commit
that referenced
this pull request
Aug 25, 2025
* SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
transphorm
added a commit
that referenced
this pull request
Sep 7, 2025
* update CI * bump iOS version * update readme * update mobile-deploy ci * bump version iOS * update workflow to use workload identity federation (#933) * update workflow to use workload identity federation * add token permissions * correct provider name * chore: incrementing android build version for version 2.6.4 [github action] --------- Co-authored-by: Self GitHub Actions <[email protected]> * update ci * update ci * update ci * update ci * update ci * fix ci * fix ci * fix ci * remove fastlane use for android * bump iOS build version * update CI python script * iterate on CI * iterate on CI * iterate on CI * Dev (#941) * SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * bump version * bump yarn.lock * update ci (#966) * chore: Manually bump and release v2.6.4 (#961) * update lock files * bump and build android * update build artifacts * show generate mock document button * update lock * fix formatting and update failing e2e test * revert podfile * fixes * fix cold start of the app with deeplink * update ci * update ci * Sync MARKETING_VERSION to iOS project files after version bump * chore: incrementing android build version for version 2.6.4 [github action] (#976) Co-authored-by: remicolin <[email protected]> * chore: add build dependencies step for iOS and Android in mobile deploy workflow * chore: enhance mobile deploy workflow by adding CMake installation step * bump android build version * chore: incrementing android build version for version 2.6.4 [github action] (#985) Co-authored-by: remicolin <[email protected]> * chore: configure Metro bundler for production compatibility in mobile deploy workflow * chore: incrementing android build version for version 2.6.4 [github action] (#987) Co-authored-by: remicolin <[email protected]> * Revert "chore: configure Metro bundler for production compatibility in mobile deploy workflow" This reverts commit 60fc1f2. * reduce max old space size in mobile-deploy ci * fix android french id card (#957) * fix android french id card * fix common ci cache * feat: log apdu (#988) --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * unblock ci * fix merge * merge fixes * fix tests * make ci happy --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: pputman-clabs <[email protected]> Co-authored-by: Self GitHub Actions <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
remicolin
added a commit
that referenced
this pull request
Sep 22, 2025
* SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice * Migrate Analytics (#951) * setup analytics adapter for self mobile sdk client and use in app * wrap for context * fix build * yarn types is an alias for build when build just compiles ts * ok unlock * deeper * ok this looks to work * fix license check * make sure it starts with this line * someone didnt commit * fix double analytics bug and builds * lint * Read document catalog from selfClient (#936) * [SELF-676] feat: upgrade React Native from 0.75.4 to 0.76.9 (#943) * chore: upgrade build tooling to Node 22 and AGP 8.6 * chore: upgrade react-native to 0.76.9 * update lock files and formatting * fix path * fix: handle hermes-engine cache mismatch in CI after React Native upgrade - Add fallback logic to run 'pod update hermes-engine' when pod install fails - This resolves CocoaPods cache issues that occur after React Native version upgrades - Fixes CI pipeline failures on codex/update-core-tooling-for-react-native-upgrade branch * fix: improve hermes-engine cache handling in CI - Preemptively clear CocoaPods cache before pod install - This prevents dependency analysis failures that occur when cached podspecs conflict - Addresses the root cause: cache conflicts during 'Analyzing dependencies' phase - Keeps fallback logic for additional safety * fix: handle hermes-engine cache in mobile-bundle-analysis workflow - Add pod-install-with-cache-fix.sh script to handle hermes-engine cache conflicts - Update install-app:setup script to use the new cache fix approach - This fixes the mobile-bundle-analysis.yml workflow failures after React Native upgrade - Proactively clears CocoaPods cache and has fallback for hermes-engine updates * formatting * fix: robust hermes-engine cache handling in CI workflows - Apply comprehensive cache clearing to mobile-ci.yml and mobile-e2e.yml - Pre-emptively run 'pod update hermes-engine' before pod install - Clear multiple cache locations to handle CI environment differences - This prevents 'hermes-engine differs from Pods/Local Podspecs' errors - Fixes all workflows affected by React Native 0.76.9 upgrade cache issues * fixes * clean up * update lock files * fix tests * sort * fixes * fix ci * fix deployment target * android fixes * upgrade fix * fixes * fix: streamline mobile CI build and caching (#946) * fix: streamline mobile CI build and caching * Enable mobile E2E tests on codex/fix-mobile-ci-workflow-errors branch * test * simplify and fix path * workflow fixes * fix loading on 0.76.9 * clean up unnecessary comments * fix readme * finalize upgrade to 0.76.9 * fix android build and upgrade * fix bundler caching * download cli to fix "yarn start" issues * fix cli build erorr * fix script path * better path * abstract build step to prevent race condition * fixes * better cache * fix corepack build error * update lock * update lock * add yarn cache to workflows * fix test building * ci caching improvements * fix common type check * fix common ci * better mobile sdk alpha building logic * chore: speed up mobile e2e workflow (#962) * chore: speed up mobile e2e workflow * chore: disable android e2e job * chore: speed up ios build * fix: bundle js for ios debug build * fix e2e * fix mobile ci (#964) * feat: improve mixpanel flush strategy (#960) * feat: improve mixpanel flush strategy * fixes * fix build * update lock * refactor methods * conslidate calls * update package and lock * refactor: remove namespace imports (#969) * refactor: remove namespace imports * refactor: use named fs imports * refactor(app): replace path and fs namespace imports * format * format * Mixpanel tweaks (#971) * udpates * fox * update license * Add DSC parsing check (#836) * Handle missing dsc parsed * nice * fix test * throw * fix * chore(app): upgrade dependencies (#968) * chore(app): upgrade dependencies * update package * update lock files * fixes * lock * fix * Auth Adapter + (#958) * basic auth adapater * remove SelfMobileSDk, this was another architecture which the adapter patern replaced * rename to avoid confusion with client.test.ts * basic auth adapater * remove SelfMobileSDk, this was another architecture which the adapter patern replaced * rename to avoid confusion with client.test.ts * self * fix * remove prototypes * make sure its mounted * fix tests * fmt * require required adapters * fix types * not a partial * adds missing exports * fix missing data * Fix nfc configuration scanning issue (#978) * fix nfc scanning on ios and android * save test * fix tests * fix lint * Chore fix ios nfc scanning and compiling (#979) * fixes * silence error * fix debugge * fix nfc scanning * lint and pipeline fixes * large runner (#980) * chore: update to macos latest large runner (#981) * bump up to macos-latest-large * fix ci * Move loadSelectedDocument to SDK (#967) Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * docs: update mobile SDK migration progress (#982) * docs: record app integration progress * docs: consolidate mobile SDK migration tracking * docs: humanize migration tracking and merge prompts * docs: add common consolidation tasks * docs: reprioritize migration tasks * docs: soften migration plan tone * docs: detail agent prompts with file paths * docs: catalog Linear tasks for SDK * updates * remove artifact management * moves validateDocument functions into the common package. (#977) * moves validateDocument functions into the common package. * fix build issues and lint * handle bad connections better in nullifiier * add an abort controler to nullifer fetcher, ignore fals positives * import types separately * take it as an arg * chore: update yarn.lock * chore(app): resolve lint warnings (#990) * chore(app): resolve lint warnings * update lock * clean up any types * fix types * feedback from cr * [SELF-703] feat: Migrate mock generator to mobile sdk (#992) * feat: expose mock generator * formatting * fix tests and lint * rename passport to document * fix types * [SELF-698] scaffold mobile sdk demo app (#993) * chore: scaffold mobile sdk demo app * test: cover demo app menu * prettier and types * sort * add android app foundation * fix android loading * get ios app running * update script * cr feedback * disable fabric * fixes * fixes * fix * SELF-702: Refactor navigation structure and dev utilities (#994) * Refactor navigation and dev screens * refactor: rename passport screens to document * fixes * add missing header * fixes * type files * feat: clarify proof verification analytics (#996) * feat: increase sha256 byte size and add new rsa circuits (#986) * feat: increase sha256 byte size and add new rsa circuits * feat: modularise the rsa fp pow mod * chore: comment signature verifier for testing * fix: sha256_sha256_sha224_ecdsa_secp224r1 * lint * chore: implement google play suggestions (#997) * google play suggestions * update gitguardian ignore * remove unused * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * skip postinstall for ci (#1005) * [SELF-654] feat: add native modules (#919) * feat: add ios native modules * fix: extractMRZ * Add android OCR native module * wire native mrz module with adapter * wire Native modules and fix tests * fixes * fix license header logic * fix tests * fix types * fix: ci test * fix: android build ci * fix: ios build CI * add podfile.lock * add yarn.lock * update lock files * add yarn.lock * add license * order methods * update lock * pipeline fixes * prettier * update lock file * fix native modules on external apps * bundle @selfxyz/common into mobile-sdk-alpha * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * update lock * fix build issues * fix pipeline issue * fix ci * fix bad merge * fix android ci * fix ci errors * fix mobile sdk ci. stop gap fix for now until we create a package * tweaks * retry aapt2 approach * use ^0.8.4 instead of ^0.8.0 due to the use of custom errors * workflow fixes * fix file * update * fix ci * test ci fix * fix test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: update dev with staging 09/06/25 (#1007) * update CI * bump iOS version * update readme * update mobile-deploy ci * bump version iOS * update workflow to use workload identity federation (#933) * update workflow to use workload identity federation * add token permissions * correct provider name * chore: incrementing android build version for version 2.6.4 [github action] --------- Co-authored-by: Self GitHub Actions <[email protected]> * update ci * update ci * update ci * update ci * update ci * fix ci * fix ci * fix ci * remove fastlane use for android * bump iOS build version * update CI python script * iterate on CI * iterate on CI * iterate on CI * Dev (#941) * SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * bump version * bump yarn.lock * update ci (#966) * chore: Manually bump and release v2.6.4 (#961) * update lock files * bump and build android * update build artifacts * show generate mock document button * update lock * fix formatting and update failing e2e test * revert podfile * fixes * fix cold start of the app with deeplink * update ci * update ci * Sync MARKETING_VERSION to iOS project files after version bump * chore: incrementing android build version for version 2.6.4 [github action] (#976) Co-authored-by: remicolin <[email protected]> * chore: add build dependencies step for iOS and Android in mobile deploy workflow * chore: enhance mobile deploy workflow by adding CMake installation step * bump android build version * chore: incrementing android build version for version 2.6.4 [github action] (#985) Co-authored-by: remicolin <[email protected]> * chore: configure Metro bundler for production compatibility in mobile deploy workflow * chore: incrementing android build version for version 2.6.4 [github action] (#987) Co-authored-by: remicolin <[email protected]> * Revert "chore: configure Metro bundler for production compatibility in mobile deploy workflow" This reverts commit 60fc1f2580c2f6ad3105d8b904d969412a18bd2e. * reduce max old space size in mobile-deploy ci * fix android french id card (#957) * fix android french id card * fix common ci cache * feat: log apdu (#988) --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * unblock ci * fix merge * merge fixes * fix tests * make ci happy --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: pputman-clabs <[email protected]> Co-authored-by: Self GitHub Actions <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: fix yarn format (#1009) * fix yarn format * yarn format * fix lint * undo temporary disabling * pipeline fixes * revert nvmrc change * add new home screen (#1019) * add new home screen * fix typing issue * yarn nice * chore: update the cpp build script (#1021) * chore: install node (#1022) * chore: use node v22 (#1023) * chore: install yarn (#1024) * chore: yarn cache (#1025) * chore: sanitise node version (#1026) * remove lazy loading (#1018) * remove lazy loading * fix tests * formatting * fix imports and web ci * fix tests * fix building * fix * debug ci * fix web ci issue * fix * fix * fix ci * remove web render test * coderabbit feedback * fix ci * use import * fix lint * fix compiling * update lock * update lock * fix: update yarn.lock hash for @selfxyz/mobile-sdk-alpha Resolves CI error where yarn install --immutable failed due to outdated package hash. The hash changed from b2afc4 to f9ebb9. * fix: update yarn.lock hash after mobile-sdk-alpha changes - Hash changed from c0e6b9 to 0d0f72 due to package modifications - Cleaned caches and regenerated lockfile to ensure consistency - This resolves CI cache mismatch where old artifacts had stale hash * fix: update yarn.lock hash after building mobile-sdk-alpha - Final hash: 89f5a6 (includes built dist artifacts) - Built mobile-sdk-alpha to ensure package is in stable state - This should resolve CI immutable install errors * fix yarn lock and build * chore(ci): improve mobile e2e caching (#1010) * chore(ci): improve mobile e2e caching * chore(ci): restore deriveddata cache * chore(ci): remove ios deriveddata cache * chore(ci): cache ios derived data * chore(ci): optimize mobile deploy caching * chore(ci): enable ccache for ios e2e builds * fix(ci): add ccache path for ios e2e * moves ofac and protocol store (#1012) * move ofact tree fetch to common * move protocol store to the msdk, fix some dependencies on msdk * chore: remove register id from register circuits (#1028) * chore: remove register id from register circuits * chore: only use 128ram instance * Feat/build cpp (#1029) * chore: remove register id from register circuits * chore: only use 128ram instance * chore: build 2 circuits at a time * Remove navigationRef from provingMachine (#1011) * SDK: minimize amount of data sent through PROVING_PASSPORT_NOT_SUPPORTED event (#1030) * Fix mock passport generation (#1031) * fix mock passport generation * fix mobile ci tests * Feat/aadhaar (#949) * make contract sdk simpler (#514) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data * Revert "make contract sdk simpler (#514)" (#518) This reverts commit 847b88d5ecc0d449b976a552f68af38eec8e561b. * merge dev into main (#576) * Feat: Show error code in SDK (#500) * feat: emit `error_code` and `reason` in app * feat: add `onError` in sdk * feat: Display reason in app * lint & fmt * feat: add scrollview in ProofRequestStatusScreen for long reasons * Fix input generation for 521bit curves (#481) * fix EC point padding for 521 bit curves * rename modulus to point in findStartIndexEC as it is a point * simplify matching logic * simplify padding logic * remove comment * remove log removing .only so the CI/CD runs circuit tests fix disclosure test fix scope in test fix scope error in circuit tests remove .only fix test * run ci/cd * Feat/simpler contract sdk (#519) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data --------- Co-authored-by: motemotech <[email protected]> * forgot to include package update (#521) * Bump version to 2.5.1 (#522) * bump version * update fastlane * fix bump version * bump build and add todo * disable commit for now * [SEL-154] Step 1: Scan your passport (#511) * simplify navigation logic * use aesop design hook * save wip * add new aesop redesign screens * save wip design * refactor nav bar logic * fix paths * save wip * stub progress navbar and save wip * save wip progress bar animation * save wip progress bar, almost done with design * fix progress bar design * fix bottom padding * disable git commit for now * fix flaky android downloads that causes pipeline to crash * update lock for ci * [SEL-46] FE: Add minimum bottom padding (#510) * fix bottom padding for smaller screens * fix podfile post install hook permissions check * update pod lock and disable git commit action step for now * update lock * fix flaky android downloads that causes pipeline to crash * fix: improve error handling for forbidden countries list mismatch (#494) * Update SelfBackendVerifier.ts * Update constants.ts * Update formatInputs.ts * Update formatCallData.ts * DX: Auto format on save (#526) * save wip * use elint instead of prettier to sort imports * set imports to warn * sync prettier settigns * update prettier settings * save working version * fix export and disable mobile pipeline for now * limit auto formatting to the app folder * remove artefacts * SEL-187: Make bottom layout scrollable on smaller screens (#525) * fix design check * add an option to disable local sending of sentry events * better sentry enable / disable * fix scan passport height * make bottom layout scrollable so it doesn't squish top screen * simpler logic check. don't create new env var * fix internet connection issues * readd comment * use isConnected instead of internet reachable * use a dynamic bottom panel height * add missing recovery screens * move aesop below * remove dupe export * fix rebase * fix android package download issue * Feat/extend id support (#517) * refactor proving impleting xstate, speedup proving * add disclosure proof support * keep refactoring provingMachine, clean old implementation * call init method when switching from dsc to register * rebase with dev to display why the proof verification failed * refactor ws connexion between front-end and mobile to retrieve self-app * update the webclient at proofVerification and use selfAppStore in provingMachine * fix provintStore.init in ProveScreen * yarn nice * fetch data correctly in splash screen * Bump build versions for 2.5.1 (#531) * release new builds * fix app and build versions * fix env check * display error animation on failure on loading screen (#532) * display error animation on failure on loading screen * remove log --------- Co-authored-by: Justin Hernandez <[email protected]> * ci: bump actions/checkout to v4 (#529) * make contract sdk simpler (#514) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data * Revert "make contract sdk simpler (#514)" (#518) This reverts commit 847b88d5ecc0d449b976a552f68af38eec8e561b. * ci: bump actions/checkout to v4 --------- Co-authored-by: nicoshark <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> * fix italy (#530) * Fix/proving machine endpoint type (#538) * store endpoint type in proving machine * yarn nice * fix splash screen error (#539) * New bug fix build for v2.5.1 (#540) * bump new build for dev fixes * update lock * reinstall before running local deploy * SEL-178: Improve haptic feedback library (#535) * fix dev settings typing * add dev screens file * save haptic feedback progress * change ordedr * fix initial route and add haptic feedback screen to dev settings options * add delete scripts (#542) * update staging registry address (#545) * feat: Add Disclose history (#533) * feat: Add Disclose history * fix: Duplicate history in list * fix: Outdated disclosures * Delete app/ios/Self copy-Info.plist * allow a scale of up to 1.3 (#546) * allow a scale of up to 1.3 * update lock files * clean up unused imports * fix settings * add common sdk (#537) * add common sdk * remove sdk backend api * remove registry * regenerate sha256 rsa dsc each time * download ski-pem dynamically on staging, refactor initpassportDataParsing * add state machine for button on prove screen, improve ux on splash screen * fetch ski-pem in production * fix linter issues * fix prove screen button bugs * update podfile.lock and yarn.lock * run linter in circuits repo * bump build * bump version for sentry debugging * bump ios to version 118 --------- Co-authored-by: Justin Hernandez <[email protected]> * better connection check (#548) * Clean up navigation and setup Jest (#549) * remove dupe account screens and prefer the term home * organize screen loading better * sort keys * rename screen files wip * fix deleted directory issues * rename folders * fix paths and naming * save working jest import test * save base working jest navigation test * finalize navigation refactor and jest test * update test name and podfile lock * remove unused packages * use the correct version of react test renderer * bump build (#552) * Eth dublin (#554) * add mock id card generator * add genMockIdDoc in common/sdk exports * onboard developer id using deeplink, allow custom birthdate on mockpassport * log more dsc info (#558) * Push notification (#536) * add push notification feature * merge new app impl * change dsc key * import * reverse mock dsc * worked in the ios * checked in android * update url and delete console * delete small changes * lint * add yarn.lock * fix warning message * add mock notification service for test code * fix path for the mock implementation * add mock deeplink to the test code * nice notificationServiceMock.js * delete unused firebase related implementation * fix wording and UI related to notification service * hotfix on mockdatascreen --------- Co-authored-by: turnoffthiscomputer <[email protected]> * Fix deeplink 2 (#560) * fix deeplink * fix deeplink * yarn nice * feat: Use vision for MRZ scanning (SEL-47) (#557) * feat: Use vision for MRZ scanning * modify label to position the smartphone during the OCR scan --------- Co-authored-by: turnoffthiscomputer <[email protected]> * SEL-255: improved loading screen with estimated wait times (#550) * create new loading screen and rename static to misc * fix route * save wip loading screen * save wip animation * save static wip design * continue * splash * add a loading screen text helper * add test for loading screen text * save wip. almost there * update haptic logic * better feedback and add dev scren * save current work * update text logic and tests * load passport metadata in loading screen * simplify and fix tests * test for additional exponents * add new animation * rename file * consolidate ui useEffect and fix loading screen layout * fix current state * remove mockPassportFlow param * merge new loading screen and new notification logic * simplify * update lock * use passportMetadata instead of metadata * save simplification * update loading text based on pr feedback and tests * Bump v2.5.1: ios 122; android 60 (#561) * increment build to 120 * bump builds for 2.5.1. ios 121; android 60 * clean up logic * upgrade react native firebase for privacy manifests * update react native keychain to fix could not recover issue (#564) * fix: update ocr corrections (#563) * Chore: Polish proof history to prep for release (#566) * clean up nav and home boundaries, passport data screen insets * migrate proof history screen out of settings * minor clean up * save wip * add new ibm plex mono font and clean up proof detail screen * remove test data * remove extra loading screen text * remove unnecessary ceil * Bump v2.5.1; ios 123; android 62 (#565) * bump to build 61 * bump ios version * update version * Feature/add prettier formatter (#568) * Add Prettier configuration and ignore files for code formatting - Created .prettierignore to exclude specific directories and files from formatting. - Added .prettierrc.yml with custom settings for print width and trailing commas. - Updated package.json to include Prettier and its Solidity plugin as dependencies, along with scripts for formatting and checking code. * Run prettier formatting * fix nationality using mock passports * SEL-181 & SEL-252: Update mobile app events (#570) * improve analytics handling * add error boundary that flushes segment events before error occurs * upgrade segment analytics package * flush analytics when user encounters error screen * track all click events * add tracking to loading screen * better init and click event names * track cloud backup and modal actions * use __DEV__ for debugging * add tracking to account recovery, auth, mock data * return false instead of throwing * add more tracking events * save wip event updating * abstract analytic event names * update click events * clean up * move reasons comment * add unsupported passport event * Feature/enhance self verification root (#569) * Add SelfVerificationConsumer contract for self-verification logic - Introduced an abstract contract, SelfVerificationConsumer, that extends SelfVerificationRoot. - Implemented nullifier tracking, verification success events, and customizable validation and update methods for nullifiers. - Added error handling for nullifier check failures and hooks for derived contracts to implement custom logic after successful verification. * Add SelfHappyBirthday contract example using SelfVerificationConsumer - Introduced SelfHappyBirthday contract that allows users to claim USDC on their birthday. - Integrated SelfVerificationConsumer for handling verification and nullifier tracking. - Added functions to set claimable amount and window, along with event emissions for state changes. - Implemented logic to check if the claim is within the user's birthday window and transfer USDC accordingly. * Refactor imports in HappyBirthday contract for better organization - Updated import statements in HappyBirthday.sol to use relative paths for ISelfVerificationRoot, SelfCircuitLibrary, and SelfVerificationConsumer. - Improved code readability and maintainability by organizing imports more logically. * Refactor Airdrop contract to use SelfVerificationConsumer for registration logic - Updated Airdrop contract to inherit from SelfVerificationConsumer instead of SelfVerificationRoot. - Refactored mappings for user identifiers and nullifiers for improved clarity and functionality. - Enhanced error handling and updated function parameters for consistency. - Implemented new validation and update methods for nullifiers, streamlining the registration process. - Removed deprecated verifySelfProof function and integrated logic into new methods. * Add events and refactor SelfVerificationRoot and related contracts - Introduced new events in SelfVerificationRoot for verification configuration updates, scope changes, and attestation ID management. - Updated Airdrop contract to remove deprecated events and added a new event for Merkle root updates. - Refactored SelfPassportERC721 to inherit from SelfVerificationConsumer, enhancing verification logic and event handling. - Improved function parameters for consistency and clarity across contracts. * Refactor contracts to use SelfVerificationRoot and enhance verification logic - Removed SelfVerificationConsumer contract and updated related contracts to inherit from SelfVerificationRoot. - Refactored mappings and event emissions in Airdrop, HappyBirthday, and SelfPassportERC721 for improved clarity and functionality. - Enhanced verification success hooks to include user identifiers and nullifiers for better tracking. - Updated constructor parameters for consistency across contracts and improved error handling for user registration and claims. * Refactor constructor in SelfPassportERC721 for improved readability * Refactor function parameters in SelfVerificationRoot and related contracts * Refactor constructor parameter names in IdentityVerificationHub, Airdrop, IdentityRegistry, and ProxyRoot contracts for improved clarity and consistency * fix getCircuitName function (#575) * fix getCircuitName function * fix getCircuitName function * feat: Read ID cards (#571) * Update GitHub checkout action from v3 to v4 (#544) * Bump build version 2.5.2 to test react native keychain (#572) * bump build and version * bump version 2.5.2 * don't downgrade react native keychain * update app/README.md toolchain instructions (#140) * bump build (#580) --------- Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: turboblitz <[email protected]> Co-authored-by: motemotech <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: James Niken <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: Olof Andersson <[email protected]> * feat(wip): register circuit for aadhaar * chore: add anon aadhar circuits * chore: remove sc and disclose selfrica test * feat: extract aadhaar qr data * test: aadhaar qr data extract circuit * test: aadhaar register circuit * feat: extract pincode and ph no last 4 digit * fix: register aadhaar nullifier and commitment * test: Verify commitment circuit of aadhaar * feat: add photoHash inside commitment * feat: build Aadhaar OFAC SMT * feat: ofac check and reveal data (test done) * test: qr extractor for custom data input * feat: add state as reveal data inside VC and disclose * chore: add comments * fix: num2Ceil component * chore: review changes * chore: use passport SignatureVerifier * fix: signatureVerifier inputs * feat: extract ascii values of fields * feat: provide users the flexibility to reveal specific characters of a field * chore: refactor * test: register aadhaar for tampered data * test(wip): should return 0 if in ofac list * test: ofac check * test: register aadhaar circuit for different qr data * merge dev into main (#683) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) * implement self uups upgradeable (#592) * implement self uups upgradeable * small changes in identityVerificationHubImplV2 * delete aderyn.toml * chore: add custom verifier * chnage return output * feat: use self structs and a Generic output struct * feat: add userIdentifier, nullifier, forbiddencountries to returned output * add root view functions from registry * fix: build and compilation errors * add userDefined data into selfVerificationRoot * "resolve conflicts" * fix compilation problem * fix how to register verification config * test: CustomVerifier * fix verification root and hub integration * add scope check in hub impl * replace poseidon hash to ripemd+sha256 * add todo list * feat: refactor and add test cases for generic formatter * add performUserIdentifierCheck in basicVerification * change how to handle additionalData and fix stack too deep * start adding test codes * fix dependency problems in monorepo * fix: forbidden countries (#612) LGTM! * able to run test code * pass happy path * delete unused codes * change error code name, add caller address validation and add scripts to run test and build in monorepo * add all test cases in vcAndDisclose flow * remove comment out * chore: use actual user identifier outputs * success in registration tests * cover all cases * pass contractVersion instead of circuitVersion * fix disclose test * chore: add natspecs for ImplHubV2, CustomVerifier and GenericFormatter * change val name and remove unused lines * add val name change * remove userIdentifier from return data * feat: use GenericDiscloseOutput struct in verfication hook fix test cases for user identifier * chore: change the function order for Hub Impl V2 (#625) * fix nat specs * add nat spec in SelfStructs --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Nesopie <[email protected]> * prettier (#629) * CAN auth - android (#613) * add missed files * add NFCMethodSelectionScreen * bump android build --------- Co-authored-by: Justin Hernandez <[email protected]> * feat: add MRZ correction method to NFCMethodSelectionScreen (#627) * add npm auth token env (#632) * bump sdk version (#633) * publish npm package when merging on dev * bump common sdk version * replace yarn publish by npm publish * update common package version * Simplify dev mode gesture (#635) * Simplify developer mode gesture * Enable dev mode on MockData screen with five taps * add build smt function to common sdk * update vc_and_disclose_id test (dev branch) (#641) * fix: vc_and_disclose_id test * chore: yarn prettier * Show modal on NFC scan error (#642) * Add help button and error modal actions * fix the screen management * yarn nice * Bump build v2.5.4: ios 132; android 71 (#631) * bump version and build numbers * remove tamagui/toast * fix marketing version * fix: update TD1 and TD3 checks (#643) * bum yarn.lock * Bump build: ios 133; android 72 and build fixes (#654) * update gesture version and bump android build * bump and fix ios build * update lock files * fixes * fix fotoapparat library source * Update example contracts to include EUID usage (#656) * refactor: update HappyBirthday contract to V2 with support for E-Passport and EUID cards, introduce bonus multipliers, and enhance verification logic * refactor: update Airdrop contract to V2 with support for E-Passport and EU ID Card attestations * refactor: remove BASIS_POINTS constant from Airdrop contract * feat: introduce SelfIdentityERC721 contract for issuing NFTs based on verified identity credentials, replacing SelfPassportERC721 * fix: update verification functions in Airdrop, HappyBirthday, and SelfIdentityERC721 contracts to use customVerificationHook * cherry pick commit from add-test-self-verification... * block non-dev pr to main branch * audit fixes (#645) * merge dev branch into main (#624) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> * update contracts (#628) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) * implement self uups upgradeable (#592) * implement self uups upgradeable * small changes in identityVerificationHubImplV2 * delete aderyn.toml * chore: add custom verifier * chnage return output * feat: use self structs and a Generic output struct * feat: add userIdentifier, nullifier, forbiddencountries to returned output * add root view functions from registry * fix: build and compilation errors * add userDefined data into selfVerificationRoot * "resolve conflicts" * fix compilation problem * fix how to register verification config * test: CustomVerifier * fix verification root and hub integration * add scope check in hub impl * replace poseidon hash to ripemd+sha256 * add todo list * feat: refactor and add test cases for generic formatter * add performUserIdentifierCheck in basicVerification * change how to handle additionalData and fix stack too deep * start adding test codes * fix dependency problems in monorepo * fix: forbidden countries (#612) LGTM! * able to run test code * pass happy path * delete unused codes * change error code name, add caller address validation and add scripts to run test and build in monorepo * add all test cases in vcAndDisclose flow * remove comment out * chore: use actual user identifier outputs * success in registration tests * cover all cases * pass contractVersion instead of circuitVersion * fix disclose test * chore: add natspecs for ImplHubV2, CustomVerifier and GenericFormatter * change val name and remove unused lines * add val name change * remove userIdentifier from return data * feat: use GenericDiscloseOutput struct in verfication hook fix test cases for user identifier * chore: change the function order for Hub Impl V2 (#625) * fix nat specs * add nat spec in SelfStructs --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Nesopie <[email protected]> * prettier (#629) --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> Co-authored-by: Nesopie <[email protected]> * fix: vc_and_disclose_id test (#640) * fix: vc_and_disclose_id test * chore: yarn prettier * fix: check if a config id exists * chore: change the function where the config not set verification is happening * fix: add await * feat: add getConfigId function in SelfVerificationRoot (#650) * feat: add getConfigId function in SelfVerificationRoot * update comment --------- Co-authored-by: motemotech <[email protected]> * chore: fix ofac end index in eu id cards * chore: fix tests * fix: example contracts and tests --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> * Update deployment module for Identity Verification Hub V2 with detailed documentation and library linkage for CustomVerifier. Update initialization process to reflect changes in V2 implementation, ensuring proper setup for proxy deployment. (#658) * publish npm-package (#651) * App/eu id updates (#638) * fix build issues * generate disclosure proof with euids * generate disclosure proof with euids * Eu id updates 2 (#648) * update vc_and_disclose_id test (dev branch) (#641) * fix: vc_and_disclose_id test * chore: yarn prettier * Show modal on NFC scan error (#642) * Add help button and error modal actions * fix the screen management * yarn nice * Bump build v2.5.4: ios 132; android 71 (#631) * bump version and build numbers * remove tamagui/toast * fix marketing version * fix: update TD1 and TD3 checks (#643) * bum yarn.lock * add version and user defined data --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * remove the mock user define data * get the useridentifier as a hash from the user defined data * chore: add version and userDefinedData * feat: use the version in register / dsc proofs as well * update calculateUserIdentifierHash * yarn nice * refactor: consolidate user context data handling and update payload structure * fix typing issues on sha1 * remove console.log(sha1) * fix sha1 import * refactor: streamline userDefinedData handling and adjust payload type for circuit * refactor: update sha1 usage and enhance logging in calculateUserIdentifierHash * yarn nice * yarn lint common * use ts-ignore for sha1 import * fix app ci tests * fix typing issue * remove unused ts-ignore * cast uuid before calling generateinputs * bump qrcode version * add tsup on the qrcode sdk * fix: exports on selfxyz/qrcode * update how we define config.version * fix yarn imports * yarn format --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Ayman <[email protected]> * Hotfix contract compile error (#660) * Fix previous rebase error * Refactor deployment module for Identity Verification Hub V2. * Fix/sdk (#652) * fix: sdk build configs * chore: SelfBackendVerifier (WIP) * feat: add custom verification * feat: consider destination chain in user defined data * chore: export attestation id * chore: export attestation id * chore: export config storage * chore: don't throw an error if the proof is not valid * chore: trim abi and rm typechain types * refactor * chore: rm unnecessary exports * 📝 Add docstrings to `fix/sdk` (#653) Docstrings generation was requested by @remicolin. * https://github.com/selfxyz/self/pull/652#issuecomment-2992046545 The following files were modified: * `sdk/core/src/utils/hash.ts` * `sdk/core/src/utils/proof.ts` * `sdk/core/src/utils/utils.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * review fixes * chore: fix package.json cjs types * chore: add minor changes to checks * feat: add InMemoryConfigStore, allIds constant and verificationResult type * chore: export Verification config * feat: change the verification config types * fix: throw issues early if verification config is null * fix: update yarn.lock file * chore: lint * fix: rm ts expect error directive * fix: contract tests * use excluded countries instead forbidden countries list * chore: change types in constnats --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update npm-publish workflow and bump core package version to 1.0.0 (#661) * update import * Update get verification config visibility (#664) * Update deployment module for Identity Verification Hub V2 to correct file paths and module name for deployment commands. * Add troubleshooting documentation for verification issues in deployHubV2.ts. Include manual verification steps and common failure reasons to assist users during deployment. * Change visibility of getVerificationConfigV2 function from internal to public in IdentityVerificationHubImplV2 contract to allow external access. * Apply BUSL v1.1 license headers to app (#665) * Add BSL license headers to app sources * prettier * fix license reference - https://spdx.org/licenses/BUSL-1.1.html * bump build: android 73 (#659) * Contracts/deploy staging (#668) * update scripts * deploy vc and disclose id * fix the deployment scripts on staging * update yarn.lock * bump ios build and version (#669) * configure coderabbitai (#670) * tweak coderabbit * bump * more thorough test spec * Apply BSL to app codebase (#639) * Clean up root license wording * Simplify SPDX header * simplify license and rename BSL to BUSL * fix merge issues * fix missing method --------- Co-authored-by: Justin Hernandez <[email protected]> * SEL-423 apply xcode build suggestions (#671) * apply recommended app settings from xcode * stick to portrait orientation and update target settings * remove app clip references * Circuit audit fixes (#644) * feat: add range checks before use of LessEqThan and SelectSubArray * fix: Num2Bits_strict to constrain virtualKey * bump core version * bump core version and fix ci * chore: use npm_auth_token in yarnrc * chroe: rm yarnrc changes * chore: update npm publish * chore: run npm publish manually * chore: change hub contract address (#675) * Update npm-publish.yml * chore: use proper secret when publishing * feat: enable publishing if workflow was triggered manually * Contracts/update verifier (#673) * update hardhat config * update vc and disclose verifier * update vc and disclose verifier script and run it * update test self verification root * update verifier * bump sdk version and use new hub address * chore: update zk-kit binary merkle root dep (#674) * refactor deployment scripts (#678) * feat: add register eu id instances (#682) * feat: add register eu id instances * feat: add new instances * chore: update scripts * chore: fix sig alg * chore: rm circuits --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> Co-authored-by: Nesopie <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: kevinsslin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Eric Nakagawa <[email protected]> * fix: commitment hash * fix: register aadhaar test * chore: refactor * feat: reveal data in packed bytes * feat: add constrain on delimiterIndices * feat: reveal timestamp * merge main to feat/aadhaar * fix: tests * feat: hash pubKey * feat: add registry contract * feat: Update HubImplV2 (WIP) * add functions to generate aadhaar data (WIP) * modularize aadhaar data generation (WIP) * fix(wip): register test * fix: test qr extractor * fix * chore: refactor functions * feat: add age extractor and tested * feat: add isMiniumAge check * fix: prepareAadhaarTestData func * registry contract tests * feat: registry contract tests * feat: extract fields from qr data bytes * chore: refactor mockData * feat: move minimum age to revealPackedData * feat: create a constant.ts to retrive fields from unpacked bytes * chore: refactor * fix: exports * rebase * rebase * feat: add public signal ,indices mapping * chore: add public output to indices mapping * fix:AADHAAR_PUBLIC_SIGNAL_INDICES * feat: make nullifier public * fix: nullifier cal for disclose circuits * feat: merge isMiniumAgeValid and miniumAge signal * fix: disclsoe test * feat: support for user identifier and secret * chore :refactor * feat: ofac test last name , firstname * feat: add forbidden_countries_list check * feat: add tests for aadhaar (WIP) * failing ofac tests * feat: finish contract tests * fix: merge conflicts * update the common package to be usable in circuits and contracts * lint everything * coderabbit fixes * chore: update name dob,yob aadhaar ofac tree * feat: merge ofac and reverse ofac check into one * test: merged ofac constrain * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice * feat: support new ofac trees * fix: qr extractor tests * chore: remove unassigned age signal * chore: modify timestamp func comment * fix: add constrain on photo bytes delimiter * fix: add range check on minimumAge within 2^7 * fix: range check for country not in list * chore: remove dummy constrain * fix: assert lessthan * fix: check is photoEOI valid * fix: replace maxDataLength with qrPaddedLength for valid del indices * feat: update forbidden countries in disclose and disclose id * feat: convert name to uppercase * fix: add constrain between delimiter and photoEOI * feat: support for phno len 4 and 10 * chore: hard-code attestaion_ID to 3 * feat: calculate nullifier using uppercase name * feat: add real id support * fix: rebase error * chore: refactor * add new nullifier and commitment calc * fix: reuse uppercase name from verify commitment * feat: add a function that will iterate though all pubkeys * chore: skip real id test * chore: yarn format * chore: update yarn.lock * chore: rm trailing / from import * chore: add support for issuing state * chore: linting and types * chore: rm types script from circuits * chore: add license header --------- Co-authored-by: nicoshark <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: turboblitz <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: James Niken <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: Olof Andersson <[email protected]> Co-authored-by: vishal <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: kevinsslin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Eric Nakagawa <[email protected]> * fix: CLA not supported (#1027) * fix: CLA not supported * fix "yarn android" building * remove unnecessary commands --------- Co-authored-by: Justin Hernandez <[email protected]> * chore: bump app version v2.6.5 (#1034) * update gem lock * bump build and version * fix app versions * chore: fix nfc passport reader private repo access (#1042) * add internal repo pat * update nfc passport reader location * update workflows to use PAT to access NFC Passport Reader * fix ci * update logic to access private repo * build(android): support 16KB page size (#1043) * build(android): support 16KB page size * fix 16kb * update lock * chore: bump v2.6.5 for release (#1036) * bump build * update to ssh clone to fix local build * update podfile lock * fix version * Feat/build aadhaar (#1044) * feat: build aadhaar circuits as well in the ci * feat: add register aadhaar case handling * fix aadhaar register output after building the cpp circuit (#1045) * fix: metro js crypto module build issues (#1047) * fix sdk build issues * fix build error * sort and fix dependencies * add constants-browserify * feat: add new verifiers (#1049) * feat: add new verifiers * format: contracts * fix: ofac check to aadhaar (#1050) * fix: hub-v2 (#1051) * Add DisclosureVerified event for comprehensive verification tracking (#945) * Add VerificationPerformed event to track verification calls - Added VerificationPerformed event with comprehensive tracking fields - Captures requestor contract, version, attestation ID, chain ID, config ID, user identifier, output, and user data - Enhanced _executeVerificationFlow to return additional tracking data - Event emission placed after verification completion for accurate tracking * chore: run formatter * chore: rename verify event name to DisclosureVerified * move clearPassportData, markCurrentDocumentAsRegistered, reStorePassportDataWithRightCSCA to SDK (#1041) * Move self app store to mobile sdk (#1040) * chore(mobile-sdk-alpha): remove unused tslib dependency (#1053) * remove tslib -- seems unused * remove deps accidentally added to root * build file * remove unused imports (#1055) * fix: sha256 signed attr tests (#1058) * fix mock screen launch (#1059) * Hotfix: Belgium ID cards (#1061) * feat: parse belgium TD1 mrz android * feat: Parse Belgium TD1 MRZ IOS * fix: OFAC trees not found (#1060) * fix: relax OFAC tree response validation * test: cover OFAC tree edge cases * fix stateless * revert and fix types * fix tests * [SELF-723] feat: add structured NFC and Proof logging (#1048) * feat: add structured NFC logging * fix ci * Fix: add deps * logging fixes. use breadcrumbs * fix android build * update SeverityLevel * [SELF-705] feat: add proof event logging (#1057) * feat: add proof event logging * refactor: unify sentry event logging * fix types * fix mock * simplify * code rabbit feedback * fix tests --------- Co-authored-by: seshanthS <[email protected]> * skip on dev (#1063) * don't get fancy just disable (#1064) * saw it building so gonna try (#1065) * Dev (#1074) * chore: bump v2.6.5 rd2 (#1067) * commit wip version bump * remove from building * chore: update tooling dependencies (#1069) * chore: update tooling dependencies * chore: align react typings and node types * update lock * chore: minor fixes across monorepo (#1068) * small fixes * fixes * fix gesture handler error * ci fixes * fix yarn build; add workflow ci (#1075) * add new workspace ci * disable package version check for now * build before checks * format * fix in future pr * feat: add functions for disclosing aadhaar attributes (#1033) * feat: add functions for disclosing aadhaar attributes * format * chore: update monorepo artifacts (#1079) * remove unneeded artifacts, skip building circuits * update md files * cleans up unused parts of sdk interface, adds inline documentation, (#1078) * cleans up unused parts of sdk interface, adds inline documentation, * fix up build * yolo * Feat/aadhaar sdk (#1082) * feat: add aadhaar support to the ts sdk * feat: aadhaar support to go sdk * chore: refactor * move clearPassportData, markCurrentDocumentAsRegistered, reStorePassportDataWithRightCSCA to SDK (#1041) * Move self app store to mobile sdk (#1040) * chore(mobile-sdk-alpha): remove unused tslib dependency (#1053) * remove tslib -- seems unused * remove deps accidentally added to root * build file * remove unused imports (#1055) * fix: sha256 signed attr tests (#1058) * fix mock screen launch (#1059) * Hotfix: Belgium ID cards (#1061) * feat: parse belgium TD1 mrz android * feat: Parse Belgium TD1 MRZ IOS * fix: OFAC trees not found (#1060) * fix: relax OFAC tree response validation * test: cover OFAC tree edge cases * fix stateless * revert and fix types * fix tests * [SELF-723] feat: add structured NFC and Proof logging (#1048) * feat: add structured NFC logging * fix ci * Fix: add deps * logging fixes. use breadcrumbs * fix android build * update SeverityLevel * [SELF-705] feat: add proof event logging (#1057) * feat: add proof event logging * refactor: unify sentry event logging * fix types * fix mock * simplify * code rabbit feedback * fix tests --------- Co-authored-by: seshanthS <[email protected]> * skip on dev (#1063) * don't get fancy just disable (#1064) * saw it building so gonna try (#1065) * chore: bump v2.6.5 rd2 (#1067) * commit wip version bump * remove from building * chore: update tooling dependencies (#1069) * chore: update tooling dependencies * chore: align react typings and node types * update lock * chore: minor fixes across monorepo (#1068) * small fixes * fixes * fix gesture handler error * ci fixes * fix yarn build; add workflow ci (#1075) * add new workspace ci * disable package version check for now * build before checks * format * fix in future pr * feat: add functions for disclosing aadhaar attributes (#1033) * feat: add functions for disclosing aadhaar attributes * format * chore: update monorepo artifacts (#1079) * remove unneeded artifacts, skip building circuits * update md files * chore: update hub contract address * format * fix: add aadhaar in AllIds * chore: bump to v1.1.0-beta --------- Co-authored-by: vishal <[email protected]> Co-authored-by: Leszek Stachowski <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: seshanthS <[email protected]> * feat: change to gcp attestation verification (#959) * feat: change to gcp attestation verification * lint * fix e2e test * chore: don't check PCR0 mapping if building the app locally * fmt:fix --------- Co-authored-by: Justin Hernandez <[email protected]> * Mobile SDK: move provingMachine from the app (#1052) * Mobile SDK: move provingMachine from the app * lint, fixes * fix web build? * lint * fix metro build, add deps * update lock files * move the status handlers and proving machine tests * may it be * fix up * yolo --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> * Revert "Mobile SDK: move provingMachine from the app (#1052)" (#1084) This reverts commit 8983ac22688f731bca8890cbf9be9c85b4ac2bf…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update extractMRZ Method to include TD1
To test
cd packages/mobile-sdk-alpha && yarn test tests/processing/mrz.test.tsSummary by CodeRabbit
New Features
Refactor
Tests
Chores
Style