Skip to content

chore(ci): upgrade checkout to v5 #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(ci): upgrade checkout to v5 #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/mobile-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ runs:
sudo update-locale LANG=en_US.UTF-8

- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup Ruby environment
uses: ruby/setup-ruby@v1
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
lint:
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Dependencies
uses: ./.github/actions/yarn-install
- name: Run linter
Expand All @@ -32,7 +32,7 @@ jobs:
test:
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Dependencies
uses: ./.github/actions/yarn-install

Expand All @@ -45,15 +45,15 @@ jobs:
build:
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
# some cocoapods won't compile with xcode 16.3
xcode-version: "16.2"

- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Mobile Dependencies
uses: ./.github/actions/mobile-setup
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

steps:
- name: Checkout Repository
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Install cpp dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/circuits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
environment: development
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

# Circom installation from https://github.com/erhant/circomkit/blob/main/.github/workflows/tests.yml
- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ jobs:
runs-on: ubuntu-latest
environment: development
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 20
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Dependencies
uses: ./.github/actions/yarn-install
- name: Build Common Dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/general-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Dependencies
uses: ./.github/actions/yarn-install
- name: Run linter
Expand All @@ -15,7 +15,7 @@ jobs:
type-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Dependencies
uses: ./.github/actions/yarn-install
- name: Build dependencies
Expand All @@ -24,7 +24,7 @@ jobs:
test-common:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Dependencies
uses: ./.github/actions/yarn-install
- name: Build dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mobile-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
# some cocoapods won't compile with xcode 16.3
xcode-version: "16.2"

- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Mobile Dependencies
uses: ./.github/actions/mobile-setup
with:
Expand Down Expand Up @@ -367,7 +367,7 @@ jobs:
if: false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Install Mobile Dependencies
uses: ./.github/actions/mobile-setup
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
qrcode_changed: ${{ steps.check-version.outputs.qrcode_changed }}
common_changed: ${{ steps.check-version.outputs.common_changed }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
fetch-depth: 2

Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
if: needs.detect-changes.outputs.core_changed == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up Node.js
uses: actions/setup-node@v4
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
if: needs.detect-changes.outputs.qrcode_changed == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up Node.js
uses: actions/setup-node@v4
Expand Down Expand Up @@ -107,13 +107,13 @@ jobs:
if: needs.detect-changes.outputs.common_changed == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
registry-url: 'https://registry.npmjs.org'
- uses: actions/checkout@v4
- uses: actions/checkout@v5
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove duplicate checkout within the same job

This second checkout is redundant and can reset working directory state (e.g., any git config or files modified/created by prior steps), potentially causing flaky behavior.

Apply this diff to remove it:

-      - uses: actions/checkout@v5
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/checkout@v5
🤖 Prompt for AI Agents 
.github/workflows/npm-publish.yml around line 116: there is a duplicate "uses:
actions/checkout@v5" within the same job which can reset working-directory
state; remove this redundant checkout step (or delete the single line/step
containing that second checkout) so only the initial checkout remains, and if
the later step relied on specific checkout options, merge those options into the
primary checkout instead.

- name: Install Dependencies
uses: ./.github/actions/yarn-install

Expand Down