Add tests for minor deployment fixes

[transphorm]

Summary

tests for #745

• add negative scenarios for cleanup-ios-build.sh
• test Fastfile APP_NAME fallbacks
• cover Slack helper for deploy source and missing token
• expose internals of mobile-deploy-confirm.cjs for testing
• ensure cleanup function is invoked in local deploy

Testing

• RBENV_VERSION=3.2.3 bundle exec ruby -Itest fastlane/test/helpers_test.rb
• RBENV_VERSION=3.2.3 bundle exec ruby -Itest fastlane/test/app_name_test.rb
• node --test scripts/tests/cleanup-ios-build.test.cjs
• node --test scripts/tests/mobile-deploy-confirm-module.test.cjs
• node --test scripts/tests/mobile-deploy-confirm.test.cjs

---

https://chatgpt.com/codex/tasks/task_b_686b15df9e5c832d8d265e1a8ccfd4ac

Summary by CodeRabbit

• New Features

  • Added comprehensive tests for determining iOS app name precedence and handling of malformed or missing configuration files.
  • Introduced unit tests for deployment helper functions, including Slack integration and deployment source messaging.
  • Added tests for iOS build cleanup script, covering error scenarios such as missing project files and malformed version information.

• Refactor

  • Updated deployment confirmation script to support both direct execution and module usage, allowing external injection of dependencies and improved testability.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

• main
• dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update introduces new and expanded test suites for Fastlane and deployment scripts, refactors mobile-deploy-confirm.cjs to support both CLI and module usage with injectable dependencies, and adds targeted tests for iOS build cleanup and deployment confirmation logic. The changes increase test isolation, error handling, and modularity across deployment tooling.

Changes

File(s)	Change Summary
app/fastlane/test/app_name_test.rb	New Minitest suite AppNameTest for verifying iOS app name resolution logic with environment, JSON, and fallback handling.
app/fastlane/test/helpers_test.rb	Added tests for Slack file upload error handling and dynamic deploy source messages based on CI environment.
app/scripts/mobile-deploy-confirm.cjs	Refactored to support both CLI and module usage; allows dependency injection for execSync and cleanup logic; exports setters.
app/scripts/tests/cleanup-ios-build.test.cjs	Added tests for missing .pbxproj and malformed version info; improved script path resolution and error assertions.
app/scripts/tests/mobile-deploy-confirm-module.test.cjs	New test suite for mobile-deploy-confirm.cjs module: verifies iOS build cleanup and Fastlane deployment logic with dependency mocks.

Sequence Diagram(s)

sequenceDiagram
    participant TestSuite as Test Suite
    participant Module as mobile-deploy-confirm.cjs
    participant Shell as Shell Script

    TestSuite->>Module: _setExecSync(mock)
    TestSuite->>Module: performIOSBuildCleanup('ios')
    Module->>Shell: execSync('cleanup-ios-build.sh')
    Shell-->>Module: (Cleanup Complete)
    Module-->>TestSuite: (Return)

    TestSuite->>Module: executeLocalFastlaneDeployment()
    Module->>Shell: execSync('fastlane deploy')
    Shell-->>Module: (Deployment Complete)
    Module->>Module: performIOSBuildCleanup()
    Module-->>TestSuite: (Return)

Loading

Poem

In the land of scripts and test delight,
New checks and mocks now shine so bright.
With modules that swap and tests that assert,
No bug or mishap can sneak or subvert.
Fastlane and cleanup, all tightly in tow—
Our deployments are safer, and confidence will grow! 🚀

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[transphorm]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

app/scripts/tests/mobile-deploy-confirm-module.test.cjs (2)

1-4: Clean test setup with proper imports.

The test file structure follows Node.js testing conventions well.

Remove the extra blank line at line 5 for consistent formatting:

 const assert = require('node:assert');
 const child_process = require('child_process');
-

 describe('performIOSBuildCleanup', () => {

---

14-16: Consider using optional chaining for cleaner code.

The assertion logic is correct but could be more concise.

Use optional chaining for a more idiomatic check:

-    assert(called && called.includes('cleanup-ios-build.sh'));
+    assert(called?.includes('cleanup-ios-build.sh'));

app/fastlane/test/helpers_test.rb (1)

358-380: Comprehensive test for deployment source messaging.

Excellent test that verifies the correct deployment source is included in Slack messages based on the CI environment. The stubbing approach is clean and effective.

Remove the trailing comma after the last parameter at line 371:

         Fastlane::Helpers.upload_file_to_slack(
           file_path: file.path,
           channel_id: "C123",
-          initial_comment: "Deploy via #{deploy_source}",
+          initial_comment: "Deploy via #{deploy_source}"
         )

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76aa872 and cf2178a.

📒 Files selected for processing (5)

• app/fastlane/test/app_name_test.rb (1 hunks)
• app/fastlane/test/helpers_test.rb (1 hunks)
• app/scripts/mobile-deploy-confirm.cjs (4 hunks)
• app/scripts/tests/cleanup-ios-build.test.cjs (2 hunks)
• app/scripts/tests/mobile-deploy-confirm-module.test.cjs (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

app/scripts/tests/mobile-deploy-confirm-module.test.cjs

[error] 16-16: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

🪛 GitHub Check: lint

app/scripts/tests/mobile-deploy-confirm-module.test.cjs

[warning] 5-5:
Delete ⏎

🪛 RuboCop (1.75.5)

app/fastlane/test/helpers_test.rb

[convention] 371-371: Avoid comma after the last parameter of a method call.

(Style/TrailingCommaInArguments)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (11)

app/scripts/mobile-deploy-confirm.cjs (3)

5-5: Good use of dependency injection pattern for testability.

Converting execSync to a mutable variable allows for proper mocking in tests, which is a clean approach for dependency injection.

---

421-445: Well-structured function refactoring for modularity.

Converting performIOSBuildCleanup to a mutable function variable enables dependency injection while maintaining the original functionality. The error handling with non-fatal cleanup failures is appropriate.

---

579-595: Clean module export pattern with proper encapsulation.

The conditional export based on require.main === module is a good pattern. The setter functions prefixed with underscore indicate internal use, which is a clear convention. This enables both CLI and module usage effectively.

app/scripts/tests/cleanup-ios-build.test.cjs (3)

5-5: Good improvements to test infrastructure.

Using spawnSync provides synchronous control over subprocess execution, and path.resolve ensures absolute paths which is more reliable than relative paths.

Also applies to: 9-9

---

45-56: Excellent negative test case for missing project file.

This test properly verifies error handling when the pbxproj file doesn't exist, ensuring the script fails gracefully with an appropriate error message.

---

58-87: Comprehensive test for malformed version data.

Good coverage of the edge case where version information cannot be extracted. The test properly sets up a git repository and verifies the expected error message.

app/scripts/tests/mobile-deploy-confirm-module.test.cjs (1)

32-49: Well-structured test for cleanup invocation.

Excellent test that verifies the cleanup function is called after deployment, properly managing mock restoration.

app/fastlane/test/helpers_test.rb (1)

345-356: Good test coverage for missing Slack token scenario.

This test properly verifies that the helper raises an appropriate exception when the Slack API token is missing, ensuring proper error handling.

app/fastlane/test/app_name_test.rb (3)

1-22: Well-structured test setup with proper isolation.

Good use of temporary directories and environment variable backup/restore to ensure test isolation.

---

23-34: Comprehensive app name evaluation logic.

The evaluate_app_name method properly implements the precedence logic: environment variable > app.json > default. Good error handling for JSON parsing and file access errors.

---

47-57: Creative approach to test logging behavior.

The singleton method redefinition to capture log messages is unconventional but effective for testing the logging behavior without depending on the logging infrastructure.