-
Notifications
You must be signed in to change notification settings - Fork 179
merge dev to main #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
merge dev to main #657
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
cfd2058
remove sdk/tests (#622)
remicolin 095ceeb
fix: add range check on paddedInLength of shaBytesDynamic (#623)
Vishalkulkarni45 9efe1b0
fix ci (#626)
remicolin 7cab29d
implement self uups upgradeable (#592)
motemotech aca1474
prettier (#629)
motemotech 498b89c
CAN auth - android (#613)
seshanthS e99e473
feat: add MRZ correction method to NFCMethodSelectionScreen (#627)
seshanthS 6750848
add npm auth token env (#632)
remicolin f3f7028
bump sdk version (#633)
remicolin 4e57997
publish npm package when merging on dev
remicolin 2d53b89
bump common sdk version
remicolin 40edfd7
replace yarn publish by npm publish
remicolin cfed790
update common package version
remicolin 08c1ead
Simplify dev mode gesture (#635)
remicolin f00b21d
add build smt function to common sdk
remicolin 27990f0
update vc_and_disclose_id test (dev branch) (#641)
Vishalkulkarni45 93312c0
Show modal on NFC scan error (#642)
remicolin e4541a8
Bump build v2.5.4: ios 132; android 71 (#631)
transphorm d89d202
fix: update TD1 and TD3 checks (#643)
seshanthS 63b21a1
bum yarn.lock
remicolin ae0dca3
Bump build: ios 133; android 72 and build fixes (#654)
transphorm df13f4e
Update example contracts to include EUID usage (#656)
kevinsslin 2607dac
cherry pick commit from add-test-self-verification...
kevinsslin ddcaac9
block non-dev pr to main branch
remicolin a193278
audit fixes (#645)
Nesopie f769680
Update deployment module for Identity Verification Hub V2 with detail…
kevinsslin d79563c
publish npm-package (#651)
motemotech be83be9
merge main
Nesopie 0468719
App/eu id updates (#638)
remicolin 02a0ee3
Hotfix contract compile error (#660)
kevinsslin 72a7f81
Fix/sdk (#652)
Nesopie 42eff71
Update npm-publish workflow and bump core package version to 1.0.0 (#…
Nesopie aa0cb50
update import
remicolin b3e4d13
Update get verification config visibility (#664)
kevinsslin 60bfe43
Apply BUSL v1.1 license headers to app (#665)
transphorm f08cfe1
bump build: android 73 (#659)
seshanthS dd02d04
Contracts/deploy staging (#668)
remicolin 9e74f11
bump ios build and version (#669)
transphorm c2e958f
configure coderabbitai (#670)
transphorm 4d4efff
Apply BSL to app codebase (#639)
ericnakagawa 37528f8
SEL-423 apply xcode build suggestions (#671)
transphorm 22681b1
Circuit audit fixes (#644)
Vishalkulkarni45 6f53872
bump core version
remicolin 0a17717
bump core version and fix ci
Nesopie 5f5eb90
chore: use npm_auth_token in yarnrc
Nesopie 018da75
chroe: rm yarnrc changes
Nesopie 8e5065a
chore: update npm publish
Nesopie bc486e1
chore: run npm publish manually
Nesopie 12e3598
chore: change hub contract address (#675)
Nesopie 650e9b9
Update npm-publish.yml
Nesopie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
|
|
||
| language: "en-US" | ||
| tone_instructions: | | ||
| You are an expert code reviewer for a React Native/TypeScript mobile application with smart contract integration. | ||
| Focus on security, performance, and best practices. Be thorough but constructive in your feedback. | ||
|
|
||
| reviews: | ||
| profile: "chill" | ||
| request_changes_workflow: false | ||
| high_level_summary: true | ||
| poem: true | ||
| review_status: true | ||
| auto_review: | ||
| enabled: true | ||
| drafts: false | ||
| base_branches: ["main", "dev"] | ||
| path_instructions: | ||
| - path: "app/src/**/*.{ts,tsx,js,jsx}" | ||
| instructions: | | ||
| Review React Native TypeScript code for: | ||
| - Component architecture and reusability | ||
| - State management patterns | ||
| - Performance optimizations | ||
| - TypeScript type safety | ||
| - React hooks usage and dependencies | ||
| - Navigation patterns | ||
| - path: "contracts/**/*.sol" | ||
| instructions: | | ||
| Review Solidity smart contracts for: | ||
| - Security vulnerabilities (reentrancy, overflow, etc.) | ||
| - Gas optimization opportunities | ||
| - Access control patterns | ||
| - Event emission for important state changes | ||
| - Code documentation and NatSpec comments | ||
| - path: "circuits/**/*.circom" | ||
| instructions: | | ||
| Review ZK circuit code for: | ||
| - Circuit correctness and completeness | ||
| - Constraint efficiency | ||
| - Input validation | ||
| - Security considerations for zero-knowledge proofs | ||
| - path: "**/*.{test,spec}.{ts,js,tsx,jsx}" | ||
| instructions: | | ||
| Review test files for: | ||
| - Test coverage completeness | ||
| - Test case quality and edge cases | ||
| - Mock usage appropriateness | ||
| - Test readability and maintainability | ||
| - path: "app/android/**/*" | ||
| instructions: | | ||
| Review Android-specific code for: | ||
| - Platform-specific implementations | ||
| - Performance considerations | ||
| - Security best practices for mobile | ||
| - path: "app/ios/**/*" | ||
| instructions: | | ||
| Review iOS-specific code for: | ||
| - Platform-specific implementations | ||
| - Performance considerations | ||
| - Security best practices for mobile | ||
|
|
||
| chat: | ||
| auto_reply: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: Block non-dev PRs to main | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| check-source: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Block PRs not from dev | ||
| run: | | ||
| if [[ "${{ github.head_ref }}" != "dev" ]]; then | ||
| echo "You can only merge from dev to main." | ||
| exit 1 | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,4 @@ | ||
| MIT License | ||
| This repository contains multiple packages, each with its own LICENSE file. | ||
| Refer to the LICENSE file in each package directory for the terms that govern | ||
| that package. | ||
|
|
||
| Copyright (c) 2023 Proof of Passport | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| Business Source License 1.1 | ||
|
|
||
| Parameters | ||
|
|
||
| Licensor: Social Connect Labs, Inc. | ||
|
|
||
| Licensed Work: The code in this folder and all folders nested within it, including all files and components unless explicitly stated otherwise. | ||
|
|
||
| Additional Use Grant: Any use for development, testing, and deployment on networks approved by Social Connect Labs, Inc., including internal business operations and academic research. | ||
|
|
||
| Change Date: 2029-06-11 | ||
|
|
||
| Change License: Apache License, Version 2.0 | ||
|
|
||
| ================================================================ | ||
|
|
||
| Business Source License 1.1 | ||
|
|
||
| Copyright (C) 2025 Social Connect Labs, Inc. | ||
|
|
||
| The contents of this repository are licensed under the Business Source License 1.1 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at: | ||
|
|
||
| https://spdx.org/licenses/BUSL-1.1.html | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
|
|
||
| Change Date | ||
|
|
||
| The Change Date is the later of four years from the date this repository was published or 2029-06-11. | ||
|
|
||
| Change License | ||
|
|
||
| On the Change Date, the contents of this repository will be made available under the terms of the Apache License, Version 2.0, as published by the Apache Software Foundation. | ||
|
|
||
| See the License for the specific language governing permissions and limitations under the Business Source License. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/CameraActivityPackage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/MainActivity.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/MainApplication.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/QRCodeScannerPackage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/ui/CameraMLKitFragment.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/ui/PassportOCRViewManager.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/ui/QRCodeScannerViewManager.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/ui/QrCodeScannerFragment.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
app/android/app/src/main/java/com/proofofpassportapp/utils/QrCodeDetectorProcessor.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security: Avoid direct use of potentially untrusted input in shell scripts.
Using
${{ github.head_ref }}directly in shell scripts poses a security risk as it can contain malicious commands. Use an environment variable instead.Apply this diff to fix the security vulnerability:
📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.7)
12-12: "github.head_ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions for more details
(expression)
🤖 Prompt for AI Agents