Skip to content

Bump build v2.5.4: ios 132; android 71 #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Bump build v2.5.4: ios 132; android 71 #631

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
783cbda
bump version and build numbers
transphorm Jun 16, 2025
151e10e
remove tamagui/toast
transphorm Jun 16, 2025
a9048cc
fix marketing version
transphorm Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ android {
applicationId "com.proofofpassportapp"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 70
versionName "2.5.3"
versionCode 71
versionName "2.5.4"
externalNativeBuild {
cmake {
cppFlags += "-fexceptions -frtti -std=c++11"
Expand Down
5 changes: 1 addition & 4 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import './src/utils/ethers';

import { config } from '@tamagui/config/v2-native';
import { ToastProvider } from '@tamagui/toast';
import React from 'react';
import { AppRegistry, LogBox } from 'react-native';
import { createTamagui, TamaguiProvider } from 'tamagui';
Expand All @@ -22,9 +21,7 @@ LogBox.ignoreLogs([

const Root = () => (
<TamaguiProvider config={tamaguiConfig}>
<ToastProvider swipeDirection="up">
<App />
</ToastProvider>
<App />
</TamaguiProvider>
);

Expand Down
2 changes: 1 addition & 1 deletion app/ios/OpenPassport/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>2.5.3</string>
<string>2.5.4</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand Down
8 changes: 4 additions & 4 deletions app/ios/Self.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
CODE_SIGN_ENTITLEMENTS = OpenPassport/OpenPassportDebug.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 129;
CURRENT_PROJECT_VERSION = 132;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 5B29R5LYHQ;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -538,7 +538,7 @@
"$(PROJECT_DIR)",
"$(PROJECT_DIR)/MoproKit/Libs",
);
MARKETING_VERSION = 2.5.3;
MARKETING_VERSION = 2.5.4;
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
Expand All @@ -561,7 +561,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = OpenPassport/OpenPassport.entitlements;
CURRENT_PROJECT_VERSION = 129;
CURRENT_PROJECT_VERSION = 132;
DEBUG_INFORMATION_FORMAT = dwarf;
Comment on lines +564 to 565
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Inconsistent Release MARKETING_VERSION
MARKETING_VERSION is set to 4 instead of 2.5.4, which will misalign release metadata. Update to match the new version bump.

Also applies to: 678-678

🤖 Prompt for AI Agents 
In app/ios/Self.xcodeproj/project.pbxproj at lines 564-565 and line 678, the
MARKETING_VERSION is incorrectly set to 4 instead of the correct version 2.5.4.
Update the MARKETING_VERSION value to 2.5.4 in both locations to ensure release
metadata consistency with the new version bump.

Copy link
Member Author

@transphorm transphorm Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. fixed

Copy link
Contributor

@coderabbitai coderabbitai bot Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinhernandez Great! Thanks for fixing the MARKETING_VERSION inconsistency. The release configuration should now properly show 2.5.4 instead of 4, ensuring the build metadata aligns correctly with your version bump.

DEVELOPMENT_TEAM = 5B29R5LYHQ;
FRAMEWORK_SEARCH_PATHS = (
Expand Down Expand Up @@ -675,7 +675,7 @@
"$(PROJECT_DIR)",
"$(PROJECT_DIR)/MoproKit/Libs",
);
MARKETING_VERSION = 2.5.3;
MARKETING_VERSION = 4;
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@selfxyz/mobile-app",
"version": "2.5.3",
"version": "2.5.4",
"private": true,
"type": "module",
"scripts": {
Expand Down