Skip to content

fix getCircuitName function #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

fix getCircuitName function #575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36306cc
fix getCircuitName function
remicolin May 27, 2025
04768a2
fix getCircuitName function
remicolin May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions common/src/utils/circuits/circuitsName.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function getDSCircuitNameFromPassportData(passportData: PassportData) {
throw new Error("Passport data are not parsed");
}
const passportMetadata = passportData.passportMetadata;

if (!passportMetadata.cscaFound) {
console.error('CSCA not found in passport metadata');
throw new Error("CSCA not found");
Expand All @@ -42,7 +42,7 @@ function getDSCircuitNameFromPassportData(passportData: PassportData) {
const bits = passportMetadata.cscaSignatureAlgorithmBits;
console.log('RSA exponent:', exponent);
console.log('RSA bits:', bits);

if (bits <= 4096) {
const circuitName = `dsc_${hashFunction}_${signatureAlgorithm}_${exponent}_${4096}`;
console.log('Generated circuit name:', circuitName);
Expand Down Expand Up @@ -89,8 +89,6 @@ function getRegisterNameFromPassportData(passportData: PassportData) {
throw new Error("CSCA not found");
}

const parsedDsc = passportData.dsc_parsed;

const dgHashAlgo = passportMetadata.dg1HashFunction;
const eContentHashAlgo = passportMetadata.eContentHashFunction;
const signedAttrHashAlgo = passportMetadata.signedAttrHashFunction;
Expand All @@ -101,7 +99,7 @@ function getRegisterNameFromPassportData(passportData: PassportData) {
console.log('Signed Attributes Hash Algorithm:', signedAttrHashAlgo);
console.log('Signature Algorithm:', sigAlg);

if (parsedDsc.signatureAlgorithm === 'ecdsa') {
if (sigAlg=== 'ecdsa') {
console.log('Processing ECDSA signature...');
const {
curveOrExponent,
Expand All @@ -111,7 +109,7 @@ function getRegisterNameFromPassportData(passportData: PassportData) {
console.log('Generated circuit name:', circuitName);
return circuitName;

} else if (parsedDsc.signatureAlgorithm === 'rsa') {
} else if (sigAlg === 'rsa') {
console.log('Processing RSA signature...');
const {
curveOrExponent,
Expand All @@ -129,7 +127,7 @@ function getRegisterNameFromPassportData(passportData: PassportData) {
throw new Error(`Unsupported key length: ${signatureAlgorithmBits}`);
}

} else if (parsedDsc.signatureAlgorithm === 'rsapss') {
} else if (sigAlg === 'rsapss') {
console.log('Processing RSA-PSS signature...');
const {
curveOrExponent,
Expand All @@ -149,7 +147,7 @@ function getRegisterNameFromPassportData(passportData: PassportData) {
throw new Error(`Unsupported key length: ${signatureAlgorithmBits}`);
}
} else {
console.error('Unsupported signature algorithm:', parsedDsc.signatureAlgorithm);
console.error('Unsupported signature algorithm:', sigAlg);
throw new Error('Unsupported signature algorithm');
}
}
}