SELF-1219: DocumentCameraScreen copy changes

[shazarre]

Note

Updates the document camera screen disclaimer to “Self will not capture an image of your ID.” across app and SDK.

• UI Copy
  • Update disclaimer text on document camera screens:
    • app/src/screens/documents/scanning/DocumentCameraScreen.tsx
    • packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx
  • Change from SELF WILL NOT CAPTURE AN IMAGE OF YOUR PASSPORT. to Self will not capture an image of your ID.

^{Written by Cursor Bugbot for commit 481281d. This will update automatically on new commits. Configure here.}

Summary by CodeRabbit

• Chores
  • Updated disclaimer messaging displayed across document camera screens within the mobile application to enhance overall consistency and clarity. The user-facing messaging now employs generalized language for identification document capture requirements rather than document-type-specific references, and text formatting has been refined throughout for improved readability and a better overall user experience.

[coderabbitai]

Walkthrough

Disclaimer text updated across two document camera screen components from "SELF WILL NOT CAPTURE AN IMAGE OF YOUR PASSPORT." to "Self will not capture an image of your ID." Changes are purely textual with no modifications to logic, control flow, or error handling.

Changes

Cohort / File(s)	Summary
Disclaimer text standardization app/src/screens/documents/scanning/DocumentCameraScreen.tsx, packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx	Updated user-facing disclaimer message from passport-specific, all-caps phrasing to generalized, title-cased ID wording

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Simple text/content update with no logic changes across two related files
• Purely cosmetic modifications to user-facing strings

Possibly related PRs

• SEL-479: Multi-ID onboarding mvp flow #688: Updates the same user-facing ID/passport disclaimer wording in document camera screen components.

Suggested labels

codex

Suggested reviewers

• transphorm
• remicolin

Poem

A passport becomes an ID so free, 🆔
Disclaimers refined for clarity—
Self won't capture your face with flair,
Just text that's polished with care,
Standards aligned, from sea to sea ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'SELF-1219: DocumentCameraScreen copy changes' directly references the main change in the changeset—updating disclaimer text in DocumentCameraScreen files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch shazarre/DocumentCameraScreen_copy_changes

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67eb0d4 and 481281d.

📒 Files selected for processing (2)

• app/src/screens/documents/scanning/DocumentCameraScreen.tsx (1 hunks)
• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

packages/mobile-sdk-alpha/**/*.{ts,tsx}

📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)

packages/mobile-sdk-alpha/**/*.{ts,tsx}: Use strict TypeScript type checking across the codebase
Follow ESLint TypeScript-specific rules
Avoid introducing circular dependencies

Files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx

**/*.{js,ts,tsx,jsx,sol,nr}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{js,ts,tsx,jsx,sol,nr}: NEVER log sensitive data including PII (names, DOB, passport numbers, addresses), credentials, tokens, API keys, private keys, or session identifiers.
ALWAYS redact/mask sensitive fields in logs using consistent patterns (e.g., ***-***-1234 for passport numbers, J*** D*** for names).

Files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx
• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:

• API consistency with core SDK
• Platform-neutral abstractions
• Performance considerations
• Clear experimental notes or TODOs

Files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx

app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (app/AGENTS.md)

Type checking must pass before PRs (yarn types)

Files:

• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

app/src/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:

• Component architecture and reusability
• State management patterns
• Performance optimizations
• TypeScript type safety
• React hooks usage and dependencies
• Navigation patterns

Files:

• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

🧠 Learnings (9)

📓 Common learnings

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-09-22T11:10:57.879Z
Learning: Applies to app/ios/**/*.{m,mm,swift} : Document complex native iOS module changes in the PR

Learnt from: aaronmgdr
Repo: selfxyz/self PR: 889
File: app/src/utils/utils.ts:20-29
Timestamp: 2025-08-25T14:07:52.997Z
Learning: In the SELF passport/identity verification app, the primary PII concerns are MRZ data from passports and document numbers. SSNs and credit cards are not relevant to this domain, so PII redaction should focus on passport-specific data patterns rather than general financial/personal identifiers.

Learnt from: shazarre
Repo: selfxyz/self PR: 1236
File: packages/mobile-sdk-alpha/src/flows/onboarding/document-nfc-screen.tsx:356-378
Timestamp: 2025-10-23T12:08:55.529Z
Learning: In packages/mobile-sdk-alpha/src/flows/onboarding/document-nfc-screen.tsx, the NFC native events emitted via NativeEventEmitter are generic status strings (e.g., "PACE succeeded", "BAC failed", "Reading DG1 succeeded") and do not contain sensitive MRZ data or passport numbers, so they do not require sanitization before logging.

📚 Learning: 2025-10-23T12:08:55.529Z

Learnt from: shazarre
Repo: selfxyz/self PR: 1236
File: packages/mobile-sdk-alpha/src/flows/onboarding/document-nfc-screen.tsx:356-378
Timestamp: 2025-10-23T12:08:55.529Z
Learning: In packages/mobile-sdk-alpha/src/flows/onboarding/document-nfc-screen.tsx, the NFC native events emitted via NativeEventEmitter are generic status strings (e.g., "PACE succeeded", "BAC failed", "Reading DG1 succeeded") and do not contain sensitive MRZ data or passport numbers, so they do not require sanitization before logging.

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx
• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx
• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

📚 Learning: 2025-08-24T18:54:04.809Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/README.md : Document new/updated SDK modules and usage in packages/mobile-sdk-alpha/README.md

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx

📚 Learning: 2025-07-16T02:20:44.173Z

Learnt from: transphorm
Repo: selfxyz/self PR: 636
File: app/src/components/native/QRCodeScanner.tsx:135-142
Timestamp: 2025-07-16T02:20:44.173Z
Learning: In app/src/components/native/QRCodeScanner.tsx, the Android camera dimension multipliers (screenWidth * 3 and screenHeight * 2) are intentionally set to these values and should not be changed. These multipliers are correct and any visual issues with black areas in the camera preview are caused by other factors, not the dimension calculations.

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx
• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Test isPassportDataValid() with realistic synthetic passport data (never real user data)

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx

📚 Learning: 2025-09-10T14:47:40.945Z

Learnt from: shazarre
Repo: selfxyz/self PR: 1041
File: app/src/providers/passportDataProvider.tsx:297-301
Timestamp: 2025-09-10T14:47:40.945Z
Learning: In app/src/providers/passportDataProvider.tsx: The deleteDocumentDirectlyFromKeychain function is a low-level utility used by the DocumentsAdapter and should not include error handling since callers like deleteDocument() already implement appropriate try/catch with logging for Keychain operations.

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx
• app/src/screens/documents/scanning/DocumentCameraScreen.tsx

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Never use real user PII in tests; use only synthetic, anonymized, or approved test vectors

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx

📚 Learning: 2025-07-12T22:00:02.041Z

Learnt from: transphorm
Repo: selfxyz/self PR: 636
File: app/src/utils/cameraPermission.ts:19-21
Timestamp: 2025-07-12T22:00:02.041Z
Learning: The Android permission handling in app/src/utils/cameraPermission.ts is robust and properly implemented using PermissionsAndroid.request() and PermissionsAndroid.check(). Previous issues with Android permission assumptions have been resolved in the current implementation.

Applied to files:

• packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: build-android
• GitHub Check: build-ios
• GitHub Check: test
• GitHub Check: ios-e2e
• GitHub Check: android-e2e
• GitHub Check: android-build-test
• GitHub Check: e2e-ios
• GitHub Check: analyze-ios
• GitHub Check: analyze-android

🔇 Additional comments (2)

app/src/screens/documents/scanning/DocumentCameraScreen.tsx (1)

92-92: LGTM! Disclaimer copy updated appropriately.

The change from "PASSPORT" to "ID" makes the disclaimer more generic and suitable for various document types. The text transform style will ensure consistent uppercase display.

packages/mobile-sdk-alpha/src/flows/onboarding/document-camera-screen.tsx (1)

82-82: LGTM! SDK disclaimer copy updated consistently.

The change from "PASSPORT" to "ID" aligns with the app implementation and makes the SDK more flexible for various document types. The text transform style ensures consistent uppercase display.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}