-
Notifications
You must be signed in to change notification settings - Fork 187
fix mobile e2e test #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
transphorm
wants to merge
7
commits into
dev
Choose a base branch
from
justin/fix-mobile-e2e-with-turnkey
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+175
−25
Open
fix mobile e2e test #1399
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2134080
fix mobile e2e test
transphorm 606b5fc
try again
transphorm 525cf92
update workflow
transphorm 38fe526
Merge branch 'dev' into justin/fix-mobile-e2e-with-turnkey
transphorm 8ed71d9
fix linting
transphorm c62c5a8
try bumping up the runner
transphorm 8d86086
try bumping cache
transphorm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -311,13 +311,12 @@ jobs: | |
| xcodebuild -version | ||
| echo "Xcode path:" | ||
| xcode-select -p | ||
| # Temporarily disabled ccache to debug CI issues | ||
| # - name: Setup ccache | ||
| # uses: hendrikmuhs/[email protected] | ||
| # with: | ||
| # key: ${{ github.job }}-${{ runner.os }} | ||
| # - name: Add ccache to PATH | ||
| # run: echo "/usr/local/opt/ccache/libexec" >> $GITHUB_PATH | ||
| - name: Setup ccache | ||
| uses: hendrikmuhs/[email protected] | ||
| with: | ||
| key: ${{ github.job }}-${{ runner.os }}-${{ env.XCODE_VERSION }} | ||
| - name: Add ccache to PATH | ||
| run: echo "/usr/local/opt/ccache/libexec" >> $GITHUB_PATH | ||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
|
|
@@ -331,14 +330,36 @@ jobs: | |
| app/ios/Pods | ||
| ~/Library/Caches/CocoaPods | ||
| lock-file: app/ios/Podfile.lock | ||
| # DerivedData caching disabled - caused intermittent build failures due to stale cache | ||
| # Pod caching still speeds up pod install significantly | ||
| - name: Cache Xcode build | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| app/ios/build | ||
| ~/Library/Developer/Xcode/DerivedData | ||
| ~/Library/Caches/com.apple.dt.Xcode | ||
| key: ${{ runner.os }}-xcode-e2e-${{ env.XCODE_VERSION }}-${{ hashFiles('app/ios/Podfile.lock', 'app/ios/OpenPassport.xcworkspace/contents.xcworkspacedata', 'app/ios/Self.xcworkspace/contents.xcworkspacedata') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-xcode-e2e-${{ env.XCODE_VERSION }}-${{ hashFiles('app/ios/Podfile.lock') }}- | ||
| ${{ runner.os }}-xcode-e2e-${{ env.XCODE_VERSION }}- | ||
| - name: Cache Xcode Index | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: app/ios/build/Index.noindex | ||
| key: ${{ runner.os }}-xcode-index-e2e-${{ env.XCODE_VERSION }}-${{ hashFiles('app/ios/Podfile.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-xcode-index-e2e-${{ env.XCODE_VERSION }}- | ||
| - name: Verify iOS Runtime | ||
| run: | | ||
| echo "📱 Verifying iOS Runtime availability..." | ||
| echo "Available iOS runtimes:" | ||
| xcrun simctl list runtimes | grep iOS | ||
| - name: Cache Built Dependencies | ||
| id: built-deps | ||
| uses: ./.github/actions/cache-built-deps | ||
| with: | ||
| cache-version: ${{ env.GH_CACHE_VERSION }}-${{ env.NODE_VERSION_SANITIZED }} | ||
| - name: Build dependencies (outside main flow) | ||
| if: steps.built-deps.outputs.cache-hit != 'true' | ||
transphorm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| run: | | ||
transphorm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| echo "Building dependencies..." | ||
| yarn workspace @selfxyz/mobile-app run build:deps || { echo "❌ Dependency build failed"; exit 1; } | ||
|
|
@@ -472,14 +493,15 @@ jobs: | |
|
|
||
| # Use cached derived data and enable parallel builds for faster compilation | ||
| # Additional flags disable indexing, restrict architecture, and use whole-module Swift compilation | ||
| # Use Release configuration for faster builds (still fully testable for E2E) | ||
| # Use the simulator that was set up earlier in the workflow | ||
| FORCE_BUNDLING=1 RCT_NO_LAUNCH_PACKAGER=1 \ | ||
| xcodebuild -workspace "$WORKSPACE_PATH" -scheme ${{ env.IOS_PROJECT_SCHEME }} -configuration Debug -destination "id=${{ env.IOS_SIMULATOR_ID }}" -derivedDataPath app/ios/build -jobs "$(sysctl -n hw.ncpu)" -parallelizeTargets -quiet COMPILER_INDEX_STORE_ENABLE=NO ONLY_ACTIVE_ARCH=YES SWIFT_COMPILATION_MODE=wholemodule || { echo "❌ iOS build failed"; exit 1; } | ||
| xcodebuild -workspace "$WORKSPACE_PATH" -scheme ${{ env.IOS_PROJECT_SCHEME }} -configuration Release -destination "id=${{ env.IOS_SIMULATOR_ID }}" -derivedDataPath app/ios/build -jobs "$(sysctl -n hw.ncpu)" -parallelizeTargets -quiet COMPILER_INDEX_STORE_ENABLE=NO ONLY_ACTIVE_ARCH=YES SWIFT_COMPILATION_MODE=wholemodule || { echo "❌ iOS build failed"; exit 1; } | ||
| echo "✅ iOS build succeeded" | ||
| - name: Install and Test on iOS | ||
| run: | | ||
| echo "Installing app on simulator..." | ||
| APP_PATH=$(find app/ios/build/Build/Products/Debug-iphonesimulator -name "*.app" | head -1) | ||
| APP_PATH=$(find app/ios/build/Build/Products/Release-iphonesimulator -name "*.app" | head -1) | ||
| [ -z "$APP_PATH" ] && { echo "❌ Could not find built iOS app"; exit 1; } | ||
| echo "Found app at: $APP_PATH" | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.