Aaronmgdr/msdk fix publish flow

[aaronmgdr]

Summary by CodeRabbit

• Chores
  • Enhanced release automation workflow to improve build responsiveness to configuration changes.
  • Extended build trigger detection to monitor additional package configuration files during automated deployments.
  • Refined build process sequencing to ensure dependencies are compiled in the correct order before primary package builds.
  • These improvements contribute to more reliable and consistent automated deployments.

[coderabbitai]

Walkthrough

Modified GitHub Actions npm-publish workflow to include packages/mobile-sdk-alpha/package.json in push-based change detection. Renamed the build step to "Build package dependencies" and added an explicit pre-build of @selfxyz/common prior to compiling mobile-sdk-alpha.

Changes

Cohort / File(s)	Change Summary
CI/CD Workflow Enhancement .github/workflows/npm-publish.yml	Extended path-based triggers to include packages/mobile-sdk-alpha/package.json for push events. Renamed "Build package" step to "Build package dependencies" and added explicit build invocation for @selfxyz/common before building mobile-sdk-alpha to satisfy dependency resolution.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Push
    participant WF as npm-publish Workflow
    participant Common as Build @selfxyz/common
    participant MSDK as Build mobile-sdk-alpha
    participant Publish as Publish Packages

    GH->>WF: Trigger on path change<br/>(includes mobile-sdk-alpha/package.json)
    WF->>Common: Build @selfxyz/common
    Common-->>WF: ✓ Complete
    WF->>MSDK: Build mobile-sdk-alpha<br/>(with common available)
    MSDK-->>WF: ✓ Complete
    WF->>Publish: Publish updated packages
    Publish-->>GH: ✓ Published

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• #1068: Updates mobile-sdk-alpha's react-native.config.cjs, overlapping package scope
• #1296: Modifies the same npm-publish workflow with msdk change detection and publish job additions
• #1140: Related CI workflow modifications for mobile SDK build and publish orchestration

Suggested labels

codex

Suggested reviewers

• remicolin
• shazarre

Poem

🔄 A workflow refined in the night,

Common built first—dependencies aligned just right,

Mobile SDK stands strong, no more alone,

Build chains orchestrated, seeds of speed sown! 📦✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "Aaronmgdr/msdk fix publish flow" directly references the main objective and change of this pull request. The core message—fixing the mobile SDK (msdk) publish flow—accurately reflects the changes made to the GitHub Actions workflow, which enhance the publishing pipeline by ensuring the common dependency is built before the mobile SDK package. While the title includes the user handle prefix ("Aaronmgdr/"), which is unconventional formatting noise, the essential content is clear, specific, and fully related to the changeset's primary purpose.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch aaronmgdr/msdk-fix-publish-flow

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3017660 and 1c5d748.

📒 Files selected for processing (1)

• .github/workflows/npm-publish.yml (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

.github/workflows/**/*.{yml,yaml}

📄 CodeRabbit inference engine (AGENTS.md)

.github/workflows/**/*.{yml,yaml}: In GitHub workflows, use the shared composite actions in .github/actions for dependency caching instead of calling actions/cache directly
Use the cache-yarn composite action for Yarn dependency caching in workflows
Use the cache-bundler composite action for Ruby gems caching in workflows
Use the cache-gradle composite action for Gradle caching in workflows
Use the cache-pods composite action for CocoaPods caching in workflows

Files:

• .github/workflows/npm-publish.yml

🧠 Learnings (5)

📓 Common learnings

Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/package.json : Expose a 'test:build' script in the SDK's package.json that runs build, test, types, and lint

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Ensure package exports are properly configured

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Ensure package exports are properly configured

Applied to files:

• .github/workflows/npm-publish.yml

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Verify package conditions are valid (e.g., exports conditions)

Applied to files:

• .github/workflows/npm-publish.yml

📚 Learning: 2025-08-24T18:54:04.809Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/package.json : Expose a 'test:build' script in the SDK's package.json that runs build, test, types, and lint

Applied to files:

• .github/workflows/npm-publish.yml

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Avoid introducing circular dependencies

Applied to files:

• .github/workflows/npm-publish.yml

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: type-check

🔇 Additional comments (2)

.github/workflows/npm-publish.yml (2)

11-11: Path trigger change is sound.

Adding packages/mobile-sdk-alpha/package.json to the push trigger paths correctly enables the workflow to be triggered when the mobile SDK package.json changes.

---

222-225: Explicit dependency build order improves reliability.

Building @selfxyz/common prior to @selfxyz/mobile-sdk-alpha is good practice if mobile-sdk-alpha depends on it. This ensures dependency code is compiled before the dependent package builds.

Please verify that @selfxyz/mobile-sdk-alpha actually has a build-time dependency on @selfxyz/common in its package.json or build configuration. If mobile-sdk-alpha doesn't depend on common, the extra build step is unnecessary overhead.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}